Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: MYp7U9pZXSVy6xlP0yKBXYMKQ1RkknhfFm6lrrxcIY9NsQJt8zlJrvAxlQ5mDCGZX0kqH9NnKA
 MVK7wHHnsILw==
IronPort-SDR: X6u1oR2wAu1++657bT/db7CSkzbjkXMGxusSlH9mmpyr4mSLmulnYxsuDL8ICqK3rqNQH0YTEh
 VbI8/qCm3fWQ==
Subject: Re: [PATCH] KVM: VMX: Enable Notify VM exit
To:     Sean Christopherson <sean.j.christopherson@intel.com>
Cc:     pbonzini@redhat.com, vkuznets@redhat.com, wanpengli@tencent.com,
        jmattson@google.com, joro@8bytes.org, tglx@linutronix.de,
        mingo@redhat.com, bp@alien8.de, hpa@zytor.com, x86@kernel.org,
        kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
        Xiaoyao Li <xiaoyao.li@intel.com>
References: <20201102061445.191638-1-tao3.xu@intel.com>
 <20201102173236.GD21563@linux.intel.com>
From:   Tao Xu <tao3.xu@intel.com>
Message-ID: <31218420-f20c-aa7f-089d-54e9fecf35aa@intel.com>
Date:   Tue, 3 Nov 2020 13:36:22 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <20201102173236.GD21563@linux.intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 11/3/20 1:32 AM, Sean Christopherson wrote:
> On Mon, Nov 02, 2020 at 02:14:45PM +0800, Tao Xu wrote:
>> There are some cases that malicious virtual machines can cause CPU stuck
>> (event windows don't open up), e.g., infinite loop in microcode when
>> nested #AC (CVE-2015-5307). No event window obviously means no events,
>> e.g. NMIs, SMIs, and IRQs will all be blocked, may cause the related
>> hardware CPU can't be used by host or other VM.
>>
>> To resolve those cases, it can enable a notify VM exit if no
>> event window occur in VMX non-root mode for a specified amount of
>> time (notify window).
>>
>> Expose a module param for setting notify window, default setting it to
>> the time as 1/10 of periodic tick, and user can set it to 0 to disable
>> this feature.
>>
>> TODO:
>> 1. The appropriate value of notify window.
>> 2. Another patch to disable interception of #DB and #AC when notify
>> VM-Exiting is enabled.
>>
>> Co-developed-by: Xiaoyao Li <xiaoyao.li@intel.com>
>> Signed-off-by: Tao Xu <tao3.xu@intel.com>
>> Signed-off-by: Xiaoyao Li <xiaoyao.li@intel.com>
> 
> Incorrect ordering, since you're sending the patch, you "handled" it last,
> therefore your SOB should come last, i.e.:
> 
>    Co-developed-by: Xiaoyao Li <xiaoyao.li@intel.com>
>    Signed-off-by: Xiaoyao Li <xiaoyao.li@intel.com>
>    Signed-off-by: Tao Xu <tao3.xu@intel.com>
> 
OK, I will correct this.