Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] drm/amdgpu: do not initialise global variables to 0 or
 NULL
To:     Greg KH <gregkh@linuxfoundation.org>
Cc:     Alex Deucher <alexdeucher@gmail.com>,
        Deepak R Varma <mh12gx2825@gmail.com>,
        David Airlie <airlied@linux.ie>,
        LKML <linux-kernel@vger.kernel.org>,
        Maling list - DRI developers 
        <dri-devel@lists.freedesktop.org>,
        Melissa Wen <melissa.srw@gmail.com>,
        amd-gfx list <amd-gfx@lists.freedesktop.org>,
        Daniel Vetter <daniel@ffwll.ch>,
        Daniel Vetter <daniel.vetter@ffwll.ch>,
        Alex Deucher <alexander.deucher@amd.com>
References: <20201102184147.GA42288@localhost>
 <CADnq5_OnA3T_p4pTEOpoqQ=NZyso2VFoDiOHu=+h7dKOeKHq-A@mail.gmail.com>
 <c916ae88-5933-ab06-ad32-d87f00cac21f@gmail.com>
 <20201103065324.GD75930@kroah.com>
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
Message-ID: <c6292ea5-4559-f8e5-d10a-9acb884b2ce8@amd.com>
Date:   Mon, 2 Nov 2020 21:48:25 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
In-Reply-To: <20201103065324.GD75930@kroah.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from [IPv6:2a02:908:1252:fb60:be8a:bd56:1f94:86e7] (2a02:908:1252:fb60:be8a:bd56:1f94:86e7) by AM0PR04CA0017.eurprd04.prod.outlook.com (2603:10a6:208:122::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.18 via Frontend Transport; Tue, 3 Nov 2020 07:42:57 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-HT: Tenant
X-MS-Office365-Filtering-Correlation-Id: 2339e187-b06f-46ab-6b6e-08d87fcc1617
X-MS-TrafficTypeDiagnostic: MN2PR12MB4304:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <MN2PR12MB4304D956036BDC5FDF03C85F83110@MN2PR12MB4304.namprd12.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: LKL83+fGm6NmWfDU+QvnmIxMYWkMPDeToW7QNU277ebBigbWVbHBBTeAjbQYvCfOZLlh52pqM6cQ1cWSW3b0jkvE0fNKk8GBbpTyVFj9lpCUq7QlWRk7Y9UajhYY/qRaK+TxTjoEgWglZhsYmrWC8F5bRieKUmsnpKytBdSSpL/OtQuYOIiEwJNoQbCOCFsvQN6rfP2KAXKAAuSHZOZqxm2ZzMDA5mIlW+YSoICH1mYUSNP1Gb46xpyMDLyAD+3ul0qfZ/nQDsmxq6M9hDxLU0/omxoymuEvLOQ+lrGjEHlZuouNselIIMNyLeszDRbGtXO1hul3wB+X2IsctZpZI2aZR1Jg6ug18yk2d6z5qXdwNT/qmUfsw8rtCTZe0FMr
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR12MB3775.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(39860400002)(366004)(346002)(396003)(136003)(8676002)(316002)(66476007)(52116002)(66946007)(66556008)(2906002)(31686004)(66574015)(53546011)(8936002)(5660300002)(4326008)(6486002)(6666004)(186003)(6916009)(16526019)(86362001)(36756003)(2616005)(478600001)(7416002)(31696002)(54906003)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: IMhctfzGYN9rPliP7utQqZFymlJjlbu9PLP2JB9a1qm62ycwBL9TV3A3ODOwgxXcBcUcAhxQaducoy6qWIWEvWB9Ud38j/DqAwEEqODcNZc5t8fTV4q581yaNgc2OCQowenfLyZKfw/iFAIFhGBacO7eYps/HM1sOpgU5UFk687H/i3o0+Gr0QvJTYAjUydVrloec5B2QvgxZ6H9k7TCxBvZZH/57EMLvuqJvkxld738W5PGdMFCkAaZIpWDMdwFJ6dNEirz+rs03NkRyNoKPiJWHOjxgvoMfvdhFYSxdflFxfcgZDsoNGYtW/QCjM0WRrXMUg3taljxLlikPyug820rmsx56CYjuvD9Q510DJX3xPBPsWgHPpBDbg7EZGtRblc8sYI97d9cCCRa50Lz/6gOQMT/fDr+Jx1l/n5ffp/kJlzPQR6XJpeyaNYvsXkCZVp1dGPyEh+gorVpB1GheMtf5sgJGeQSjYlh5nhc/waobl5ajrz5Gz6Eq9Ye4GH2TN+ZOZJfrSPoehSD7V1FmrEycxedPXcqe2MIB/oqS+kPFHX4XwmqATeCFflAESfWzI/SC1gEME9vaOOmSRCSI0dgKAy+JiZ5SfihsQpK7nwSXj0aihQb0aUYgP1upjhBxpiYcEcrtLPUdJ35/claW1C05kclUE3ji+gpVZhMMFHzP11tQkCg87nnuaWe54wwQGWzINg6go9+7iotKgFgDQ==
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2339e187-b06f-46ab-6b6e-08d87fcc1617
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3775.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2020 07:42:59.5143
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: olgH7Bv7J9Nt+86NZYtbvLDg7FBaCJnVAIUwdzoZbmiDzwV5r7Tk1PaEUt1B5fC9
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4304
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 03.11.20 um 07:53 schrieb Greg KH:
> On Mon, Nov 02, 2020 at 09:06:21PM +0100, Christian König wrote:
>> Am 02.11.20 um 20:43 schrieb Alex Deucher:
>>> On Mon, Nov 2, 2020 at 1:42 PM Deepak R Varma <mh12gx2825@gmail.com> wrote:
>>>> Initializing global variable to 0 or NULL is not necessary and should
>>>> be avoided. Issue reported by checkpatch script as:
>>>> ERROR: do not initialise globals to 0 (or NULL).
>>> I agree that this is technically correct, but a lot of people don't
>>> seem to know that so we get a lot of comments about this code for the
>>> variables that are not explicitly set.  Seems less confusing to
>>> initialize them even if it not necessary.  I don't have a particularly
>>> strong opinion on it however.
>> Agree with Alex.
>>
>> Especially for the module parameters we should have a explicit init value
>> for documentation purposes, even when it is 0.
> Why is this one tiny driver somehow special compared to the entire rest
> of the kernel?  (hint, it isn't...)

And it certainly shouldn't :)

> Please follow the normal coding style rules, there's no reason to ignore
> them unless you like to constantly reject patches like this that get
> sent to you.

Yeah, that's a rather good point.

Not a particular strong opinion on this either, but when something 
global is set to 0 people usually do this to emphases that it is 
important that it is zero.

Regards,
Christian.

>
> thnaks,
>
> greg k-h