Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 3 Nov 2020 09:27:21 +0100
From:   Greg KH <gregkh@linuxfoundation.org>
To:     luojiaxing <luojiaxing@huawei.com>
Cc:     akpm@linux-foundation.org, viro@zeniv.linux.org.uk,
        andriy.shevchenko@linux.intel.com, linux-kernel@vger.kernel.org,
        martin.petersen@oracle.com, john.garry@huawei.com,
        himanshu.madhani@cavium.com, felipe.balbi@linux.intel.com,
        uma.shankar@intel.com, anshuman.gupta@intel.com,
        animesh.manna@intel.com, linux-usb@vger.kernel.org,
        linux-scsi@vger.kernel.org, linuxarm@huawei.com
Subject: Re: [PATCH v2 0/5] Introduce a new helper marco
 DEFINE_SHOW_STORE_ATTRIBUTE at seq_file.c
Message-ID: <20201103082721.GA2510248@kroah.com>
References: <1604046722-15531-1-git-send-email-luojiaxing@huawei.com>
 <20201030084448.GA1625087@kroah.com>
 <d4852df0-d7e0-ee7e-352c-58eaf47c2c72@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <d4852df0-d7e0-ee7e-352c-58eaf47c2c72@huawei.com>
Precedence: bulk

On Tue, Nov 03, 2020 at 04:19:09PM +0800, luojiaxing wrote:
> Hi
> 
> On 2020/10/30 16:44, Greg KH wrote:
> > On Fri, Oct 30, 2020 at 04:31:57PM +0800, Luo Jiaxing wrote:
> > > We already own DEFINE_SHOW_ATTRIBUTE() helper macro for defining attribute
> > > for read-only file, but we found many of drivers also want a helper marco for
> > > read-write file too.
> > > 
> > > So we try to add this macro to help decrease code duplication.
> > > 
> > > Luo Jiaxing (5):
> > >    seq_file: Introduce DEFINE_SHOW_STORE_ATTRIBUTE() helper macro
> > >    scsi: hisi_sas: Introduce DEFINE_SHOW_STORE_ATTRIBUTE for debugfs
> > >    scsi: qla2xxx: Introduce DEFINE_SHOW_STORE_ATTRIBUTE for debugfs
> > >    usb: dwc3: debugfs: Introduce DEFINE_SHOW_STORE_ATTRIBUTE
> > >    drm/i915/display: Introduce DEFINE_SHOW_STORE_ATTRIBUTE for debugfs
> > What changed from v1?
> 
> 
> Sorry, I should add a commit for the change.
> 
> 
> In v1, Andy pointed out that the old name of DEFINE_STORE_ATTRIBUTE was
> easily misunderstood as a write-only file rather than a read-write file.
> 
> Therefore, it is changed to DEFINE_SHOW_STORE_ATTRIBUTE according to his
> suggestion.

All of that needs to go in the patch, below the --- line, or in the
00/XX email here, like is documented.

Please fix that up and resend a v3 if you wish for people to look at
this series and know what is going on.

thanks,

greg k-h