Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Madalin Bucur <madalin.bucur@nxp.com>
To:     Zou Wei <zou_wei@huawei.com>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "kuba@kernel.org" <kuba@kernel.org>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH -next] dpaa_eth: use false and true for bool variables
Thread-Topic: [PATCH -next] dpaa_eth: use false and true for bool variables
Thread-Index: AQHWsdfxVunRuryS/kCLXNLVwfyWWqm2UX9Q
Date:   Tue, 3 Nov 2020 12:13:29 +0000
Message-ID: <AM6PR04MB397628B89D6A10C973FF3162EC110@AM6PR04MB3976.eurprd04.prod.outlook.com>
References: <1604405100-33255-1-git-send-email-zou_wei@huawei.com>
In-Reply-To: <1604405100-33255-1-git-send-email-zou_wei@huawei.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: b8c4778b-533a-4e1d-155a-08d87ff1dfd8
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Nov 2020 12:13:29.1411
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: kn3kIufSDQqCJUaEgc0NuuMPO/pXTSR2sm4vRplzqnpRPdlJ3wJpTxvyBKGXOo780NeA0lu9hEOB1OwTQRzqvQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0401MB2452
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -----Original Message-----
> From: Zou Wei <zou_wei@huawei.com>
> Sent: 03 November 2020 14:05
> To: Madalin Bucur <madalin.bucur@nxp.com>; davem@davemloft.net;
> kuba@kernel.org
> Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Zou Wei
> <zou_wei@huawei.com>
> Subject: [PATCH -next] dpaa_eth: use false and true for bool variables
>=20
> Fix coccicheck warnings:
>=20
> ./dpaa_eth.c:2549:2-22: WARNING: Assignment of 0/1 to bool variable
> ./dpaa_eth.c:2562:2-22: WARNING: Assignment of 0/1 to bool variable
>=20
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zou Wei <zou_wei@huawei.com>
> ---
>  drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>=20
> diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
> b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
> index d9c2859..31407c1 100644
> --- a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
> +++ b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
> @@ -2546,7 +2546,7 @@ static void dpaa_eth_napi_enable(struct dpaa_priv
> *priv)
>  	for_each_online_cpu(i) {
>  		percpu_priv =3D per_cpu_ptr(priv->percpu_priv, i);
>=20
> -		percpu_priv->np.down =3D 0;
> +		percpu_priv->np.down =3D false;
>  		napi_enable(&percpu_priv->np.napi);
>  	}
>  }
> @@ -2559,7 +2559,7 @@ static void dpaa_eth_napi_disable(struct dpaa_priv
> *priv)
>  	for_each_online_cpu(i) {
>  		percpu_priv =3D per_cpu_ptr(priv->percpu_priv, i);
>=20
> -		percpu_priv->np.down =3D 1;
> +		percpu_priv->np.down =3D true;
>  		napi_disable(&percpu_priv->np.napi);
>  	}
>  }
> --
> 2.6.2

Acked-by: Madalin Bucur <madalin.bucur@oss.nxp.com>