Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <5064a1921b0ba98289c13f325e11347b09cd3672.camel@gmail.com>
Subject: Re: [PATCH v2 5/6] ARM: dts: sun8i: s3: Add dts for the Elimo
 Initium SBC
From:   Matteo Scordino <matteo.scordino@gmail.com>
To:     Maxime Ripard <maxime@cerno.tech>
Cc:     wens@csie.org, robh+dt@kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Date:   Tue, 03 Nov 2020 16:33:26 +0000
In-Reply-To: <20201102100632.g5tozkzfjzzch4ny@gilmour.lan>
References: <20201029022000.601913-1-matteo.scordino@gmail.com>
         <20201030234325.5865-6-matteo.scordino@gmail.com>
         <20201102100632.g5tozkzfjzzch4ny@gilmour.lan>
Content-Type: multipart/signed; micalg="pgp-sha512";
        protocol="application/pgp-signature"; boundary="=-we+FtxMeYutOzm6ox5w0"
User-Agent: Evolution 3.36.4-2 
MIME-Version: 1.0
Precedence: bulk


--=-we+FtxMeYutOzm6ox5w0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

--=20
Matteo Scordino / Embedded Software Consultant
Mobile: +44 (0)7463701446

On Mon, 2020-11-02 at 11:06 +0100, Maxime Ripard wrote:
> On Fri, Oct 30, 2020 at 11:43:24PM +0000, Matteo Scordino wrote:
> > The Elimo Engineering Initium is an Open Source Hardware Single Board
> > Computer based on the Elimo Impetus SoM.
> >=20
> > It is meant as the first development platform for the Impetus, providin=
g
> > convenient access to the peripherals on the Impetus.
> >=20
> > It provides:
> > USB-C power input
> > UART-to-USB bridge on the USB-C connector, connected to UART1
> > USB-A connector for USB2.0 (Host, Device, OTG)
> > Audio Line In/Out
> > Pin header to access all signals on the M2 connector of the SoM
> >=20
> > Signed-off-by: Matteo Scordino <matteo.scordino@gmail.com>
> > ---
> >  arch/arm/boot/dts/Makefile                   |  1 +
> >  arch/arm/boot/dts/sun8i-s3-elimo-initium.dts | 28 ++++++++++++++++++++
> >  2 files changed, 29 insertions(+)
> >  create mode 100644 arch/arm/boot/dts/sun8i-s3-elimo-initium.dts
> >=20
> > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> > index 4f0adfead547..dcfb8d39c267 100644
> > --- a/arch/arm/boot/dts/Makefile
> > +++ b/arch/arm/boot/dts/Makefile
> > @@ -1210,6 +1210,7 @@ dtb-$(CONFIG_MACH_SUN8I) +=3D \
> >  	sun8i-r40-bananapi-m2-ultra.dtb \
> >  	sun8i-s3-lichee-zero-plus.dtb \
> >  	sun8i-s3-pinecube.dtb \
> > +	sun8i-s3-elimo-initium.dtb \
>=20
> This should be sorted as well

Ouch. Will do.

>=20
> >  	sun8i-t3-cqa3t-bv3.dtb \
> >  	sun8i-v3s-licheepi-zero.dtb \
> >  	sun8i-v3s-licheepi-zero-dock.dtb \
> > diff --git a/arch/arm/boot/dts/sun8i-s3-elimo-initium.dts b/arch/arm/bo=
ot/dts/sun8i-s3-elimo-initium.dts
> > new file mode 100644
> > index 000000000000..7677ddc07bf9
> > --- /dev/null
> > +++ b/arch/arm/boot/dts/sun8i-s3-elimo-initium.dts
> > @@ -0,0 +1,28 @@
> > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> > +/*
> > + * Copyright (C) 2020 Matteo Scordino <matteo@elimo.io>
> > + */
> > +
> > +/dts-v1/;
> > +#include "sun8i-s3-elimo-impetus.dtsi"
> > +
> > +/ {
> > +	model =3D "Elimo Initium";
> > +	compatible =3D "elimo,initium", "elimo,impetus", "sochip,s3",
> > +    "allwinner,sun8i-v3";
>=20
> You should indent that properly

Double ouch.=20
However, how is a multiline dt property supposed to be indented?=20
I have tried a few combinations but nothing seemed to make checkpatch.pl ha=
ppy,
except leaving no space at all at the beginning of the line. But I think ma=
kes it
quite unreadable?

> > +	aliases {
> > +		serial0 =3D &uart0;
> > +		serial1 =3D &uart1;
> > +	};
> > +
> > +	chosen {
> > +		stdout-path =3D "serial0:115200n8";
> > +	};
> > +};
>=20
> It's already in the DTSI, there's no need to duplicate it here

After your question about the UART1 in the Impetus dtsi, I think it makes m=
ore
sense to remove it from the dtsi, since UART1 is directly used in this boar=
d (for
an FTDI chip) but not necessarily used in the "bare" Impetus SoM.

> Maxime


--=-we+FtxMeYutOzm6ox5w0
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEzO0zAuXCENUlBKYqFH4A68XNhRoFAl+hhlYACgkQFH4A68XN
hRrd7xAAjUw+5pi5twLc9zlFmWyz493U+jS0PUZnN7y9TDX5IjTvqj6t5ufAL/Sd
Ss0jhmlN7XmoAfIylwPjJpCxIvtihAZwsvDcexOKQM397ZqrnfrmILsiCb4u2HZg
gkWA0fFv9CpD3+J7EGKhI3+2rcIJ1cdr+Q03fYBHuHFcs+9lYquPnXNjL5IkB5OK
rhiqu9JqwMIw3yldOtPMJZwRjdWghm9CZYv6V9Kqb4gXHmFstSPUnmRl+W/eTB7B
YTXyNNR1I9F5aV1dyEdTHfLuMyow+yYK8elCZ+ekAxQpmUA+qB6/tpJJx8gNUq8L
sx1/BIAkxL/9QG+6UdUfOjuW443/JKojgesZi7Hr6vvnmE0l5HaTN9jyGLbOgu2L
t/WtUCADI8gtL/aNSKtx+sMlN19vyUPPj+J/srHtBY47p5DCCf1HjaTw7QD6zGVb
eCCCvcul6TB4NkYCSUwbg/CdqvfpVM41mba94xEG3boq92o/x/y/JDmiTF/ZAFg2
zptMya87AFSl8uFoPddvCtG+TpdmdW5vxKA6U47JWgSZ9OqmpPE6PrLtulmJ9qCi
lbAKrTSGclbmPb3W8ADHYIP/YCzvI+LRnjcpAdo6BxSdK2eo9O8qErIU0VaFYM33
5W+pVqDYnlng+oMHy0904xtpWJJ8Lcuzel5JKhBKInLd8kDesNE=
=pUit
-----END PGP SIGNATURE-----

--=-we+FtxMeYutOzm6ox5w0--