Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <CGME20201103171326eucas1p25d2ea836878fb2e4f56f31c166243c40@eucas1p2.samsung.com>
 <20201103164423.GE14739@kozik-lap> <dleftjsg9qs6ss.fsf%l.stelmach@samsung.com>
In-Reply-To: <dleftjsg9qs6ss.fsf%l.stelmach@samsung.com>
From:   Krzysztof Kozlowski <krzk@kernel.org>
Date:   Tue, 3 Nov 2020 18:22:39 +0100
Message-ID: <CAJKOXPdTU74P6PDqPqoW-qF3QkvK_0wXCVSUeuExfQyHZdvcpg@mail.gmail.com>
Subject: Re: [PATCH 5/5] ARM: dts: exynos: Add Ethernet interface description
 for Odroid X/X2
To:     Lukasz Stelmach <l.stelmach@samsung.com>
Cc:     Rob Herring <robh+dt@kernel.org>, Kukjin Kim <kgene@kernel.org>,
        Anand Moon <linux.amoon@gmail.com>, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        "linux-samsung-soc@vger.kernel.org" 
        <linux-samsung-soc@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        =?UTF-8?Q?Bart=C5=82omiej_=C5=BBolnierkiewicz?= 
        <b.zolnierkie@samsung.com>,
        Marek Szyprowski <m.szyprowski@samsung.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, 3 Nov 2020 at 18:13, Lukasz Stelmach <l.stelmach@samsung.com> wrote=
:
>
> It was <2020-11-03 wto 17:44>, when Krzysztof Kozlowski wrote:
> > On Tue, Nov 03, 2020 at 01:46:18PM +0100, =C5=81ukasz Stelmach wrote:
> >> Add Ethernet interface description for Odroid X/X2.
> >>
> >> Signed-off-by: =C5=81ukasz Stelmach <l.stelmach@samsung.com>
> >> ---
> >>  arch/arm/boot/dts/exynos4412-odroidx.dts | 28 +++++++++++++++++++++++=
+
> >>  1 file changed, 28 insertions(+)
> >>
> >> diff --git a/arch/arm/boot/dts/exynos4412-odroidx.dts b/arch/arm/boot/=
dts/exynos4412-odroidx.dts
> >> index 3ea2a0101e80..8f154f431f6c 100644
> >> --- a/arch/arm/boot/dts/exynos4412-odroidx.dts
> >> +++ b/arch/arm/boot/dts/exynos4412-odroidx.dts
> >> @@ -15,6 +15,10 @@ / {
> >>      model =3D "Hardkernel ODROID-X board based on Exynos4412";
> >>      compatible =3D "hardkernel,odroid-x", "samsung,exynos4412", "sams=
ung,exynos4";
> >>
> >> +    aliases {
> >> +            ethernet =3D &ethernet;
> >> +    };
> >> +
> >>      memory@40000000 {
> >>              device_type =3D "memory";
> >>              reg =3D <0x40000000 0x3FF00000>;
> >> @@ -72,8 +76,32 @@ &buck8_reg {
> >>  };
> >>
> >>  &ehci {
> >> +    #address-cells =3D <1>;
> >> +    #size-cells =3D <0>;
> >>      phys =3D <&exynos_usbphy 2>;
> >>      phy-names =3D "hsic0";
> >> +
> >> +    hub@2 {
> >> +            compatible =3D "usb0424,3503";
> >> +            reg =3D <2>;
> >> +            #address-cells =3D <1>;
> >> +            #size-cells =3D <0>;
> >> +
> >> +            hub@1 {
> >> +                    compatible =3D "usb0424:9514";
> >
> > Does not look like correct compatible.
>
> As odd as it may seem (and considering my mistakes) this is correct.

Not the numbers, the format. Comma is needed.

Best regards,
Krzysztof