Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 3 Nov 2020 10:32:21 -0800
From:   Dmitry Torokhov <dmitry.torokhov@gmail.com>
To:     Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc:     Hans de Goede <hdegoede@redhat.com>,
        Rob Herring <robh+dt@kernel.org>,
        Douglas Anderson <dianders@chromium.org>,
        Jiri Kosina <jkosina@suse.cz>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Linux Input <linux-input@vger.kernel.org>,
        Stephen Boyd <swboyd@chromium.org>,
        Kai Heng Feng <kai.heng.feng@canonical.com>,
        andrea@borgia.bo.it, Aaron Ma <aaron.ma@canonical.com>,
        Daniel Playfair Cal <daniel.playfair.cal@gmail.com>,
        Jiri Kosina <jikos@kernel.org>, Pavel Balan <admin@kryma.net>,
        You-Sheng Yang <vicamo.yang@canonical.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 2/3] HID: i2c-hid: Allow subclasses of i2c-hid for
 power sequencing
Message-ID: <20201103183221.GA1003057@dtor-ws>
References: <20201102161210.v3.1.Ibb28033c81d87fcc13a6ba28c6ea7ac154d65f93@changeid>
 <20201102161210.v3.2.Ied4ce10d229cd7c69abf13a0361ba0b8d82eb9c4@changeid>
 <CAL_JsqLxGugWg7Xwr-NQa1h+a_=apQsfFCU0KF-97xt1ZB8jMg@mail.gmail.com>
 <28e75d51-28d8-5a9a-adf9-71f107e94dfb@redhat.com>
 <CAO-hwJK2DfU_v==uwWyyPkH9N6zb9Vh_pJOxz8dZ_mqJ1+CdsA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAO-hwJK2DfU_v==uwWyyPkH9N6zb9Vh_pJOxz8dZ_mqJ1+CdsA@mail.gmail.com>
Precedence: bulk

On Tue, Nov 03, 2020 at 01:42:47PM +0100, Benjamin Tissoires wrote:
> 
> I also want to say that I like the general idea of Doug's patch.
> Having a separate driver that handles the specific use case of goodix
> is really nice, as it allows to just load this driver without touching
> the core of i2c-hid. I believe this is in line with what Google tries
> to do with their kernel that OEMs can not touch, but only add overlays
> to it. The implementation is not polished (I don't think this new
> driver belongs to the input subsystem), but I like the general idea of
> having the "subclassing". Maybe we can make it prettier with Hans'
> suggestion, given that this mainly means we are transforming
> i2c-hid-core.c into a library.
> 
> As for where this new goodix driver goes, it can stay in
> drivers/hid/i2c-hid IMO.

Yep, I agree, it has nothing to do with input (except the device being
physically a touchscreen ;) ), so driver/hid/i2c-hid makes most sense to
me too.

Thanks.

-- 
Dmitry