Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp797917pxb; Tue, 3 Nov 2020 12:49:57 -0800 (PST) X-Google-Smtp-Source: ABdhPJyB1O/CNef4BWZ51T/APJfFLKTV38p8RR+QEaklYH6nylqTAoOf4xyVudAaM3rrDMOvlqFD X-Received: by 2002:a17:906:d8b0:: with SMTP id qc16mr21369487ejb.268.1604436597058; Tue, 03 Nov 2020 12:49:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604436597; cv=none; d=google.com; s=arc-20160816; b=0QYS0Q+TZhQxwGJXZQG+KLWkiraUp4KEakrNFT/aDwBpb3Uth6m9JltDpcSSWjdL/7 IM+UqXOOAhUhwNQZG+WdFVue5zpxmktiI8S/c4fEO/Y+l9c63B8Pfpg3Hj6yOiwjd41a ZTZroc2MMF0OjmZjht8FJsWxl3b3NN0CC01InT+mNLApyijyT+gPscrIPyVgxumfs1EB CccVQakyqJEk3PPK39rGkd65siKYD1uQq+lOrakX+En6NqTZXB1IiUp7iTgxOEJo6zVF Qrl7JDdTZMj5Roq84p16ch5hXS35uFCDRaI16Z8LTvKcq3pp9TyvziEBGDjCly7q6AFi KEyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=6WxDu7vIAXh4P+wiev2o0QfUqD395TgVgUQIp/AYCp0=; b=mLC/NXAeeIcMwKpiDOTqJMbfVD5qzPkKNFOyq3oHp3MoJ3COKi61vM7+RHpX1X4hZG TUqrvKIMsXssA107krpDcbqtn3zMwE+vhB9GIUSXMN5Xw3YGKa6bUuSSXFSCw53Id4ts Jnz3Q75b5WBQsmpB3+azNAZUTZQHYXSTipBwAtXmAN8wfLJbQNCoi1cIkAbgjGDOXK3H qXzQTeGXb+zKj0hoagDoNU9yK02KnvVNxndmzBjTO1M7m3vib1m9c+gmX1ef4EvSAEXy zyPL3N64uSaQwkrk//vvQHa48Vj8Z9iqmKyr7601dht5qYe1YY7M8e8oEplm8+48ZnYJ Vi4A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Yc1N4zfd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dd12si1136445edb.382.2020.11.03.12.49.34; Tue, 03 Nov 2020 12:49:57 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Yc1N4zfd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731287AbgKCUrE (ORCPT + 99 others); Tue, 3 Nov 2020 15:47:04 -0500 Received: from mail.kernel.org ([198.145.29.99]:36990 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731282AbgKCUrC (ORCPT ); Tue, 3 Nov 2020 15:47:02 -0500 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8420720719; Tue, 3 Nov 2020 20:47:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604436422; bh=gVcnKTRxt1r1U9E0KMjttxOctmywkcGA+mmXOXBkcKw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Yc1N4zfd9V1JtWEtuE0GMVJvEweL4vDZZpIGxhiJMufNIeFI+0RDXKEUgPDh3n7lT ClRkpk8MUtH88taZSCw8C3bOz6G0VdnNBHtu+G3DojNwWgqYl9J7saydOAQLfcU8WE je2gq+hX1IcwPo6Q5bJRKLKXGSNYwLDGml0MZyE0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Li Jun , Felipe Balbi Subject: [PATCH 5.9 243/391] usb: dwc3: core: add phy cleanup for probe error handling Date: Tue, 3 Nov 2020 21:34:54 +0100 Message-Id: <20201103203403.404723259@linuxfoundation.org> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201103203348.153465465@linuxfoundation.org> References: <20201103203348.153465465@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Li Jun commit 03c1fd622f72c7624c81b64fdba4a567ae5ee9cb upstream. Add the phy cleanup if dwc3 mode init fail, which is the missing part of de-init for dwc3 core init. Fixes: c499ff71ff2a ("usb: dwc3: core: re-factor init and exit paths") Cc: Signed-off-by: Li Jun Signed-off-by: Felipe Balbi Signed-off-by: Greg Kroah-Hartman --- drivers/usb/dwc3/core.c | 11 +++++++++++ 1 file changed, 11 insertions(+) --- a/drivers/usb/dwc3/core.c +++ b/drivers/usb/dwc3/core.c @@ -1564,6 +1564,17 @@ static int dwc3_probe(struct platform_de err5: dwc3_event_buffers_cleanup(dwc); + + usb_phy_shutdown(dwc->usb2_phy); + usb_phy_shutdown(dwc->usb3_phy); + phy_exit(dwc->usb2_generic_phy); + phy_exit(dwc->usb3_generic_phy); + + usb_phy_set_suspend(dwc->usb2_phy, 1); + usb_phy_set_suspend(dwc->usb3_phy, 1); + phy_power_off(dwc->usb2_generic_phy); + phy_power_off(dwc->usb3_generic_phy); + dwc3_ulpi_exit(dwc); err4: