Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp798470pxb; Tue, 3 Nov 2020 12:50:57 -0800 (PST) X-Google-Smtp-Source: ABdhPJyu+ZmVYRR1EqHWi+ugGhSwhCxhPLEhAg9idBHBrfEpTJSxz3lt7M0JGunmFR/SbafUcE2g X-Received: by 2002:a17:906:7190:: with SMTP id h16mr21041540ejk.221.1604436657152; Tue, 03 Nov 2020 12:50:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604436657; cv=none; d=google.com; s=arc-20160816; b=i83V3Fl5hCrDgKZjgE2n7j+XuAqWcGoNjiHmYEZu9qw2jFlJT3skf0Q5hC3KlA4bD0 Xo0ZXxA2ZdSUFdQIkx+MS1hDgnVF6uIU4RP/UvAM4okCzcPeJM9N8buuLkjI+170jE7r zoo8MXS1GIDVAvhrCCtFM/m7miZnztwfjFZhOou+1tk9AMsnUxG0go79skRkEoIJLV71 u/MqaRtsl0KZCN9aePY72gnZxRjQ9Q5Eby/vF39REW8OB7OofWzyFqmcdoYWvX2dyHEG QXobugIymm6ufe00Ja96SbRXb7LtN5rfnmiYWpa/vgdb38pOa1bpFeSJhkfGfa/NdOyG SQUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Pg3e0QiAbazhR0wt7JgJXHg1//OA47hpbOQFETkIsGI=; b=LDkgqwM3TtY0aN6n7nBZoD+fdIamV4BLg7qD1Do2sTipqAZIY7XDEyX/HL94HP1Dt9 24re51NDV68AREAJTVeiRWzhKXIk/puWSOka6w5D4fKIf15MuK5Le8inLHwf1c1ZCNIK wqPIgc7spYJb+jYc4TaJdyAPMHHL2vkEr4/oKXqncIvDBKLoFHruM4jo677J6IibklLd 3Ladpy4OEZLmz7apOFUtG/27tleJg3/+ZCSqxL1X4X/YcDUtMEskxu//B3gs4c8QqkDl MGzCTwy1ltVp8MwUMZ/3A34WO0lilUDLV4p7qbPFwJQHCaJlTlVhhARfbR5RpMzbyZ2R L08A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=q9ZvLbOY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a13si1592595edr.154.2020.11.03.12.50.34; Tue, 03 Nov 2020 12:50:57 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=q9ZvLbOY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731131AbgKCUqH (ORCPT + 99 others); Tue, 3 Nov 2020 15:46:07 -0500 Received: from mail.kernel.org ([198.145.29.99]:35036 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729851AbgKCUqE (ORCPT ); Tue, 3 Nov 2020 15:46:04 -0500 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C731D223FD; Tue, 3 Nov 2020 20:46:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604436364; bh=vYNjNsP1G2vZoouKPMCZ7fRCdGXUHmDmCr/9+CYnFOY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=q9ZvLbOYSlWC3gHId4iaYwgvxxsTCGEHiKi2zCBay7j1ug1pt6taIfyKnZY+3uH+1 RKDb8CqWutQhugZp7otvPbVv4LxkK6GQD2pX0oqRiIAgoF5KGAQmo9ZklZDWbDxJfv pcrwAR1LEt38WViHGoaaITrZrrC+L2fNeVZROf9U= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Himanshu Madhani , Arun Easi , Nilesh Javali , "Martin K. Petersen" Subject: [PATCH 5.9 217/391] scsi: qla2xxx: Fix MPI reset needed message Date: Tue, 3 Nov 2020 21:34:28 +0100 Message-Id: <20201103203401.576798835@linuxfoundation.org> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201103203348.153465465@linuxfoundation.org> References: <20201103203348.153465465@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arun Easi commit 7a6cdbd5e87515ebf6231b762ad903c7cff87b9c upstream. When printing the message: "MPI Heartbeat stop. MPI reset is not needed.." ..the wrong register was checked leading to always printing that MPI reset is not needed, even when it is needed. Fix the MPI reset message. Link: https://lore.kernel.org/r/20200929102152.32278-4-njavali@marvell.com Fixes: cbb01c2f2f63 ("scsi: qla2xxx: Fix MPI failure AEN (8200) handling") Cc: stable@vger.kernel.org Reviewed-by: Himanshu Madhani Signed-off-by: Arun Easi Signed-off-by: Nilesh Javali Signed-off-by: Martin K. Petersen Signed-off-by: Greg Kroah-Hartman --- drivers/scsi/qla2xxx/qla_isr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/scsi/qla2xxx/qla_isr.c +++ b/drivers/scsi/qla2xxx/qla_isr.c @@ -767,7 +767,7 @@ qla27xx_handle_8200_aen(scsi_qla_host_t ql_log(ql_log_warn, vha, 0x02f0, "MPI Heartbeat stop. MPI reset is%s needed. " "MB0[%xh] MB1[%xh] MB2[%xh] MB3[%xh]\n", - mb[0] & BIT_8 ? "" : " not", + mb[1] & BIT_8 ? "" : " not", mb[0], mb[1], mb[2], mb[3]); if ((mb[1] & BIT_8) == 0)