Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp798957pxb; Tue, 3 Nov 2020 12:51:50 -0800 (PST) X-Google-Smtp-Source: ABdhPJyv1OCrgix73d3JXmTjqznt/j2oxrCperGb+q6Qsx8Im3uHI6W4RRCsfN1JIa2cVznSv5MK X-Received: by 2002:aa7:ce8c:: with SMTP id y12mr24519715edv.185.1604436710274; Tue, 03 Nov 2020 12:51:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604436710; cv=none; d=google.com; s=arc-20160816; b=dps2XCsIi1QwFLVPmZwRr/MEnYPXXNOjgLmkhIaiaa4kkKQaLyyD3dYxJ6m4wWATrx SkrnTI6tgXndfvee6Gwts0Iv4aLL2Fp07mLcmx2TquDDUoKaDtGOn4VREPNALBFNIUZo 0rgkmwjLiqcKofdTqPd6ildiegcxcU1dtEn4LMgSlrSN2YdC+wcnUlRoDLIv8FYCZMcc DVD6xZ+pSVC2TCHHkB3SmgDAgiHwsS9elJWxQIlwstyW0Gr0w10vDdRxNNoiuCGvvYcX YDeMLNjfhleu7JAsqITqQkVjZPrJ5O7p5Va+yLl1IuLyDp9v5bBihLoyaivZ/EhJhsnP hqzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=QitBeuqbGEoDoaZFYyoycgUTJF/KWSRje9FxZhbZTQs=; b=sVvgufai7FR5gStAKY7W2AbA2XA6nIV4Kujv/iXhOFL13bVD/B+Vr0z/bGNZloR6k8 6+D84NGTL7s3PxPhUQb72IG/f9CyMYyRdhR36d3Ywg/gsAAvM6MYBcbkCMK2zwlN50nD fg9Gqf7uovRgZ/uqFrvyQETpnEQPepRMqWwWfrI0w5wRzkZNYQqfQCGDUvdbWSdtLHIa 3IL4Wy6uFuWw6nd7m6Jphhr3j88RoRUsMO8apivEM9rB+wwvgZELU7msyVu+nt3BXIXr MjjQmI68ytBO9dMow7HAYVTiH5dRmw/J9D5S1Gb4AF3hPyK75t5CJ+SGL37bXUuo5Z2z oWpg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=u3ji8YRp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f18si5147668edw.32.2020.11.03.12.51.27; Tue, 03 Nov 2020 12:51:50 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=u3ji8YRp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731437AbgKCUsD (ORCPT + 99 others); Tue, 3 Nov 2020 15:48:03 -0500 Received: from mail.kernel.org ([198.145.29.99]:38916 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730623AbgKCUr6 (ORCPT ); Tue, 3 Nov 2020 15:47:58 -0500 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 45B70223FD; Tue, 3 Nov 2020 20:47:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604436477; bh=rpe7itsELLeXF2AC2kygj+B+2ADMNIN1orbgN3x/xhY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=u3ji8YRpMNq0+Fj2Cutd45xVCSK45LQ2b+ZDf/V7A0QEYll0mMDmuUSnNVKR6Gu0Z xpG1d720++aTiFm4l52Cp7TUurQzuDKcYSUlftRriGKzFDL7qJZNFh2B1K25BeuVRj p6naEmLXZTFHCG4ZXyorjNFp9LYfgCF0C3IhoaKw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Himanshu Madhani , Quinn Tran , Nilesh Javali , "Martin K. Petersen" Subject: [PATCH 5.9 219/391] scsi: qla2xxx: Fix crash on session cleanup with unload Date: Tue, 3 Nov 2020 21:34:30 +0100 Message-Id: <20201103203401.711886269@linuxfoundation.org> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201103203348.153465465@linuxfoundation.org> References: <20201103203348.153465465@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Quinn Tran commit 50457dab670f396557e60c07f086358460876353 upstream. On unload, session cleanup prematurely gave the signal for driver unload path to advance. Link: https://lore.kernel.org/r/20200929102152.32278-6-njavali@marvell.com Fixes: 726b85487067 ("qla2xxx: Add framework for async fabric discovery") Cc: stable@vger.kernel.org Reviewed-by: Himanshu Madhani Signed-off-by: Quinn Tran Signed-off-by: Nilesh Javali Signed-off-by: Martin K. Petersen Signed-off-by: Greg Kroah-Hartman --- drivers/scsi/qla2xxx/qla_target.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) --- a/drivers/scsi/qla2xxx/qla_target.c +++ b/drivers/scsi/qla2xxx/qla_target.c @@ -1229,14 +1229,15 @@ void qlt_schedule_sess_for_deletion(stru case DSC_DELETE_PEND: return; case DSC_DELETED: - if (tgt && tgt->tgt_stop && (tgt->sess_count == 0)) - wake_up_all(&tgt->waitQ); - if (sess->vha->fcport_count == 0) - wake_up_all(&sess->vha->fcport_waitQ); - if (!sess->plogi_link[QLT_PLOGI_LINK_SAME_WWN] && - !sess->plogi_link[QLT_PLOGI_LINK_CONFLICT]) + !sess->plogi_link[QLT_PLOGI_LINK_CONFLICT]) { + if (tgt && tgt->tgt_stop && tgt->sess_count == 0) + wake_up_all(&tgt->waitQ); + + if (sess->vha->fcport_count == 0) + wake_up_all(&sess->vha->fcport_waitQ); return; + } break; case DSC_UPD_FCPORT: /*