Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp799737pxb; Tue, 3 Nov 2020 12:53:20 -0800 (PST) X-Google-Smtp-Source: ABdhPJwJVAFgTgTMq8dpPPFED7yoyYSm2LXgbG0ye7DRlrDc56K1sVkTEba4t6QIA64Sudb7t0Ds X-Received: by 2002:a05:6402:142a:: with SMTP id c10mr24090390edx.261.1604436799899; Tue, 03 Nov 2020 12:53:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604436799; cv=none; d=google.com; s=arc-20160816; b=TSQct+5ecF5GW5y/cfglfD18A2meLpQyjtQnT6eEAZPjBA3OsbF8LwM0pwdOESSUBS TicWvEns4jh/lMtAGk8d3zsWLaopi1lOSYJB/Smxtwrlvz/9Cv3r2rleALX6Bo72NTiz T8MerTFmEr7yPrTkCHbLsJZopRBVotTddD90BN9CNVro3oI3xANk9Dw93tqfYroMNEmZ efRQfnDHVnMufOYvcfOZajxWVj7mYtgQyZXALtK6qTp06lJiGMznu1ktXC57462h4+au uLYbyucrtIExVw844PoJe+BnDjp8OacEOVJqZJj2CtDT0zyG37uCn0hcyaOQ5XpILsX2 oXhg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=jQ+0TYRTW508Vlia22YxzWQDqnr1SAJI544yczAoACg=; b=GzQ3HgzFm94yjNssRMbPIZl+ptDkxo1qFw6wlISTljqDSWPbztf4UPO7LzsGnUMZwA sW44Y/6iRVh2kDuaBIwbogIqdK6BKaM0J86iQ9C1af78cjHDRXAbne/oVLXHpjBoq4gB 6wAh/e58Nyyu8wXgChFOnaFD3huW0+HZgGv6wm0V5L4zOJMYyJ+kzVsFZV9mMTtfpyNp rCABNvx9MRJA2hoBdfY6zP6UlJdjSgv5tJbhStiJHz2uiIKlbPPRYxVNdDQDp8myzttK cfJByAHFmKOKIcePSFAPtFdWNxAbtq3KQSOHyHYE0/rl0n38gUU9MgoW9AZhglo/I3tT IbTQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Lg9bZdC9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a13si1592595edr.154.2020.11.03.12.52.56; Tue, 03 Nov 2020 12:53:19 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Lg9bZdC9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731747AbgKCUuD (ORCPT + 99 others); Tue, 3 Nov 2020 15:50:03 -0500 Received: from mail.kernel.org ([198.145.29.99]:43734 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731731AbgKCUuB (ORCPT ); Tue, 3 Nov 2020 15:50:01 -0500 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 84D91223FD; Tue, 3 Nov 2020 20:50:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604436601; bh=Sucy8dbXgJwgZTIjyulq7Mxs+SihhI22QUtLc6wogHU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Lg9bZdC9a243h/ZrlG7olwCaOwbzkUVxnXXbK33GZn5P0p55pbwBI/lkQshVgSaya IB4ePdpxql4cjfCDJtpjUfYsMovqw8n/yMWIARsUXbyLu97EKEDr18Igm/mV7gTffn uwY23z0kw0SBroe5etZJ2G64MjS/3Ih0CKny3bcg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Evan Quan , Alex Deucher , Jane Jian Subject: [PATCH 5.9 321/391] drm/amdgpu: correct the gpu reset handling for job != NULL case Date: Tue, 3 Nov 2020 21:36:12 +0100 Message-Id: <20201103203408.771114455@linuxfoundation.org> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201103203348.153465465@linuxfoundation.org> References: <20201103203348.153465465@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Evan Quan commit 207ac684792560acdb9e06f9d707ebf63c84b0e0 upstream. Current code wrongly treat all cases as job == NULL. Signed-off-by: Evan Quan Reviewed-and-tested-by: Jane Jian Signed-off-by: Alex Deucher Cc: stable@vger.kernel.org Signed-off-by: Greg Kroah-Hartman --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c @@ -4374,7 +4374,7 @@ int amdgpu_device_gpu_recover(struct amd retry: /* Rest of adevs pre asic reset from XGMI hive. */ list_for_each_entry(tmp_adev, device_list_handle, gmc.xgmi.head) { r = amdgpu_device_pre_asic_reset(tmp_adev, - NULL, + (tmp_adev == adev) ? job : NULL, &need_full_reset); /*TODO Should we stop ?*/ if (r) {