Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp800972pxb; Tue, 3 Nov 2020 12:55:40 -0800 (PST) X-Google-Smtp-Source: ABdhPJxfDjAwbPSem/LoSMgKjIHTdtbxVs5jqXOYqGuTRX80FofP0Xjg9RIxBrLr0zuerZc8jb3s X-Received: by 2002:a05:6402:a53:: with SMTP id bt19mr13193546edb.26.1604436940017; Tue, 03 Nov 2020 12:55:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604436940; cv=none; d=google.com; s=arc-20160816; b=da+7hQeZopyzmwdi2nSdHmYSZ+SSkEZrvFFoP8vQRLVNR9z/hW3zinn0hNFojE5FE2 UeMUjEKJE09ptTbFPFWveotUHx4PDVCOYRo/nBPbShSqAmb8eT98AqQV5j+GehVa84eG zFR9UMq4roZcH9WyCtWOPV/wn4/72/ka3cLUsRWchfJblLPG2b136JqcVD6sV3RcFDI5 /3Av7Yb/PZ5E0QMwfplXMPUxNBfkLtGWZDYLdx2x43pfxxjGyzWVHtW0ICSt/vfhS7/V oDegU2FVTAzGtkZzL0bas8i/kU2Sq4Ek8lkrStopt2lQWq6kMNncFzNWhrHrgfkO67Bo W1Sw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=+s5A2bKsmpCbkGAH2bVTjZrH6rNi9jQdIW8Epo70ce8=; b=I6ztBvZin5acRdZ7x4HLpjoxErFeRmyqia1AWtplTzBR7iqudZKPFxA0Vub5CEHghB OqlX4v0AHtigvkCfvJUiazqZZFyF+RL7OmfBMK6sKeSFzzZ+B9lf26Pwuip9YgVuKwAl X2JF/7wFXIHuhKcQLK0Wxd6kjad7ixJlKYt3Ur+itj0g25jS2domlV4yJxfHirmbD52s m3twgRWI3626CWjwLRmqIeg/H5syw9GxIc0g7p/f0Ip6O+Lp00+sT1xGydAdJCKUIpSq AXQaO4QHz4KolinKceljYgxYR0c4f9EXsoHvKVyvAxD3hmMc21TpgLEJf4uILcYl3fxI rcjA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=V4qx9uoQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 32si6061164edr.232.2020.11.03.12.55.16; Tue, 03 Nov 2020 12:55:40 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=V4qx9uoQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732102AbgKCUwf (ORCPT + 99 others); Tue, 3 Nov 2020 15:52:35 -0500 Received: from mail.kernel.org ([198.145.29.99]:49234 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732109AbgKCUwd (ORCPT ); Tue, 3 Nov 2020 15:52:33 -0500 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D3E7E2053B; Tue, 3 Nov 2020 20:52:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604436752; bh=kbL2i6ClqnBNgUCZXfy2B8qSZM3vFB5Ne8HZ2QbPPNU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=V4qx9uoQd+hMtdA6gm7FfBcLTTPwK8P3M7OEJCWMp/bQXfaapUol4R0CeUOFIPi9T TyO2QwRumYj4hPnEEBqTot0fvwmfiNiZ+NbCIA1hX3YLQCWENeyByKXbzExDK1Pe9a 2kNLaWfjRF7ggJkPQ1BRHSab4M0pQE378QP6/Qjs= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dave Airlie , =?UTF-8?q?Christian=20K=C3=B6nig?= Subject: [PATCH 5.9 349/391] drm/ttm: fix eviction valuable range check. Date: Tue, 3 Nov 2020 21:36:40 +0100 Message-Id: <20201103203410.688165824@linuxfoundation.org> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201103203348.153465465@linuxfoundation.org> References: <20201103203348.153465465@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dave Airlie commit fea456d82c19d201c21313864105876deabe148b upstream. This was adding size to start, but pfn and start are in pages, so it should be using num_pages. Not sure this fixes anything in the real world, just noticed it during refactoring. Signed-off-by: Dave Airlie Reviewed-by: Christian König Cc: stable@vger.kernel.org Link: https://patchwork.freedesktop.org/patch/msgid/20201019222257.1684769-2-airlied@gmail.com Signed-off-by: Greg Kroah-Hartman --- drivers/gpu/drm/ttm/ttm_bo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/gpu/drm/ttm/ttm_bo.c +++ b/drivers/gpu/drm/ttm/ttm_bo.c @@ -694,7 +694,7 @@ bool ttm_bo_eviction_valuable(struct ttm /* Don't evict this BO if it's outside of the * requested placement range */ - if (place->fpfn >= (bo->mem.start + bo->mem.size) || + if (place->fpfn >= (bo->mem.start + bo->mem.num_pages) || (place->lpfn && place->lpfn <= bo->mem.start)) return false;