Received: by 2002:a05:6622:f08:0:0:0:0 with SMTP id l8csp4478528ivc; Tue, 3 Nov 2020 13:05:16 -0800 (PST) X-Google-Smtp-Source: ABdhPJzysAawlKo2YB0NoPvQ0MqTqo7c1e13hq/DE3UVA0F1AqRjrsY9S2BqaTjBrVJcLWEbzW9U X-Received: by 2002:a05:6402:744:: with SMTP id p4mr23132035edy.190.1604437516505; Tue, 03 Nov 2020 13:05:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604437516; cv=none; d=google.com; s=arc-20160816; b=fr9OabpIOBXI3qsHWLOSRmeyGpXdMiBofnxHVC7gqcD+8FZI8isYpvo2f6vkq7k4mj ecdeMEIq/WesvRmv4V3YlKdZ0vRSDC3iI6mCMeFHBcqRlF3l8nzCB5IqlodugXGlL2G0 tKeuoGf8b2LM9Ab5a6C/kIWx3670fbsSqRNnlcALQCKpf/GSaAzLiqC9DvRyCJQwE22e cCvFJTuxsTULgTlp9sBbT2vrborHq5tN4heygkCZwAxFTSImdET0XiHPdnMwrkMlAKEB chG7vD5JpVIGpDVXcnO9Ke1HsYkoSn9lIY6jXs7WBVxSqlYoLcMAB3NRz1TXkSozOzgA 0Q5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=mcc9iaGBfwmto01BXgkLPfBBPTF1D1XwUmNYUSDxACg=; b=Zrm7lSD9y7mdsDUKqdl4W2CLy0b/IHQZjdneJBMA4tnfG3BToj0XPeehE+pp9J1QMV jCqVL5xEovdhBPGYuF8NkYLpH3iUk2zu19zJIh4mScax2H0jlar5i5Gol26GHK8+BQ81 vOJR2O3AcGuvlXVP7RAaDLTELxOszjhpPtWhiReey18tcdqmO/3pLZ7Rv2zGTtXB3clv CB+jSWh+L/AKzbk0thxnf1x4sYpbODxdAJFVkcAO5eJx4GHV15K5E6xv2TQo9DAtkqT9 3XkVYqS6mvbGccogoHzHqimtYT2U204Ipg1ngRXsjgaOIxgL8jZIR/JgNuIfPmAhHNKH AAGg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=p8StUJ54; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z2si11881871edi.245.2020.11.03.13.04.53; Tue, 03 Nov 2020 13:05:16 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=p8StUJ54; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387888AbgKCVDj (ORCPT + 99 others); Tue, 3 Nov 2020 16:03:39 -0500 Received: from mail.kernel.org ([198.145.29.99]:41206 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387854AbgKCVDe (ORCPT ); Tue, 3 Nov 2020 16:03:34 -0500 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B31C420658; Tue, 3 Nov 2020 21:03:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604437414; bh=veZukfQr4mkkffovXObXdUc+T3bju9S9b/w1Uuf7NPQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=p8StUJ54AUC4sloYDJAs9WsxsKGuA5TzMaDpQ8BK89Nf+768ubXm4UxUqPcqClHqi WIIqK0BRV6IVdrX3vQF91W14PdtChXaPNHPi548VSuKlZ1vY22S+KnLzKhqsCxs05W UDyX7NW3JorGsAltiZoDHomIQMtGruF2L826Lb+w= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Wen Gong , Kalle Valo , Sasha Levin Subject: [PATCH 4.19 066/191] ath10k: start recovery process when payload length exceeds max htc length for sdio Date: Tue, 3 Nov 2020 21:35:58 +0100 Message-Id: <20201103203240.722349290@linuxfoundation.org> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201103203232.656475008@linuxfoundation.org> References: <20201103203232.656475008@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Wen Gong [ Upstream commit 2fd3c8f34d08af0a6236085f9961866ad92ef9ec ] When simulate random transfer fail for sdio write and read, it happened "payload length exceeds max htc length" and recovery later sometimes. Test steps: 1. Add config and update kernel: CONFIG_FAIL_MMC_REQUEST=y CONFIG_FAULT_INJECTION=y CONFIG_FAULT_INJECTION_DEBUG_FS=y 2. Run simulate fail: cd /sys/kernel/debug/mmc1/fail_mmc_request echo 10 > probability echo 10 > times # repeat until hitting issues 3. It happened payload length exceeds max htc length. [ 199.935506] ath10k_sdio mmc1:0001:1: payload length 57005 exceeds max htc length: 4088 .... [ 264.990191] ath10k_sdio mmc1:0001:1: payload length 57005 exceeds max htc length: 4088 4. after some time, such as 60 seconds, it start recovery which triggered by wmi command timeout for periodic scan. [ 269.229232] ieee80211 phy0: Hardware restart was requested [ 269.734693] ath10k_sdio mmc1:0001:1: device successfully recovered The simulate fail of sdio is not a real sdio transter fail, it only set an error status in mmc_should_fail_request after the transfer end, actually the transfer is success, then sdio_io_rw_ext_helper will return error status and stop transfer the left data. For example, the really RX len is 286 bytes, then it will split to 2 blocks in sdio_io_rw_ext_helper, one is 256 bytes, left is 30 bytes, if the first 256 bytes get an error status by mmc_should_fail_request,then the left 30 bytes will not read in this RX operation. Then when the next RX arrive, the left 30 bytes will be considered as the header of the read, the top 4 bytes of the 30 bytes will be considered as lookaheads, but actually the 4 bytes is not the lookaheads, so the len from this lookaheads is not correct, it exceeds max htc length 4088 sometimes. When happened exceeds, the buffer chain is not matched between firmware and ath10k, then it need to start recovery ASAP. Recently then recovery will be started by wmi command timeout, but it will be long time later, for example, it is 60+ seconds later from the periodic scan, if it does not have periodic scan, it will be longer. Start recovery when it happened "payload length exceeds max htc length" will be reasonable. This patch only effect sdio chips. Tested with QCA6174 SDIO with firmware WLAN.RMH.4.4.1-00029. Signed-off-by: Wen Gong Signed-off-by: Kalle Valo Link: https://lore.kernel.org/r/20200108031957.22308-3-wgong@codeaurora.org Signed-off-by: Sasha Levin --- drivers/net/wireless/ath/ath10k/sdio.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/wireless/ath/ath10k/sdio.c b/drivers/net/wireless/ath/ath10k/sdio.c index 0cdaecb0e28a9..28d86da65c051 100644 --- a/drivers/net/wireless/ath/ath10k/sdio.c +++ b/drivers/net/wireless/ath/ath10k/sdio.c @@ -561,6 +561,10 @@ static int ath10k_sdio_mbox_rx_alloc(struct ath10k *ar, le16_to_cpu(htc_hdr->len), ATH10K_HTC_MBOX_MAX_PAYLOAD_LENGTH); ret = -ENOMEM; + + queue_work(ar->workqueue, &ar->restart_work); + ath10k_warn(ar, "exceeds length, start recovery\n"); + goto err; } -- 2.27.0