Received: by 2002:a05:6622:f08:0:0:0:0 with SMTP id l8csp4487898ivc; Tue, 3 Nov 2020 13:21:06 -0800 (PST) X-Google-Smtp-Source: ABdhPJyDgRhR8NNg6XCpFaU+t24TQ0M09Stxi71ibY9Rnn2WFDF0PCNkh/OVDjv1FCvBHQnqp6X2 X-Received: by 2002:aa7:c44d:: with SMTP id n13mr7940814edr.138.1604438466807; Tue, 03 Nov 2020 13:21:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604438466; cv=none; d=google.com; s=arc-20160816; b=mzWIH/TU5DwtM+Kw1eSq8z7zmvn/2192/QJ1Kp4IV6srEHzqrQH/ZV69nOdzi3EDkF rAiys9FvwRpLfElUHN33RXsnU9mfdfpfPXGdhmlaIF3IAYFzpnWyCVvYkDoYn4o/hsnk b4CK/2jJa2AsfTpxig+CDDNt2YdxfLIugyfLB5hx/cIpZC5vM+mNkDz2Zjkn3Ri3ceLO OXlFOAxxdcww7MkpUFkCDY1Z5WiHfBvBvqTAoA5+OHwP3oBj1e8t3k3jKL2T/mpTrkaq FTpPlIwDJ0LGSn2gLRQzYs5vBQKfHWLuacbjvEEk8RLjSOlOirpoBJ9eU/qGLQhIwcu0 3pYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:user-agent :mime-version:message-id:date:subject:cc:to:from:dkim-signature; bh=Uc4M+P0eh1Hw244EpkT2jlz03JuKD+h1D01Gf03afeQ=; b=ZBwNhlNAttoC6dV96ZnxnJL+cDvgO49fFvRSqJOl7LgJDBy7AULx2eZz09u4vGthqq X3mL9XFABqev/wd4xHLOKjy4M5o99eXyneqnPOdQt53fJSieqhgnLBSYelgzxRnFfje+ dpqXKl1nS8Meor+Z6TImPuR5W6itASbsGUgEWFkOYtbOV2JXemzZ4mzSXja+Y1asxTiH vD/0iobFlV3f6F6xvV0+zyHon7BOk4a6xcqs3kDZZ8eem5G/jYmzZNNWBgmKN1IUcek/ PuC2P8lYTWIjtvLyvY16Lbe9cGMpw0ut9tPkZ1Ls1+npBOGdnwvJxT3xkIdQX146cFrN KKHA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="Gxubjp/A"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p10si14528ejy.70.2020.11.03.13.20.43; Tue, 03 Nov 2020 13:21:06 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="Gxubjp/A"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388527AbgKCVJg (ORCPT + 99 others); Tue, 3 Nov 2020 16:09:36 -0500 Received: from mail.kernel.org ([198.145.29.99]:49638 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388537AbgKCVJf (ORCPT ); Tue, 3 Nov 2020 16:09:35 -0500 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8428B205ED; Tue, 3 Nov 2020 21:09:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604437773; bh=X9M5Vn/b3vsXzpmZVS0kb34ivALhliBmG47nSQRE1lc=; h=From:To:Cc:Subject:Date:From; b=Gxubjp/A0sNApco4r3BJD5qFaEaFjUDAuuXuJ1HAmdgGiYKEAibq0ELfr6C+AhR6s dD3wIHJqiN2gp9W33F2fXUGrvhIkT2PGlnNOT5naTlgMPOqQVNY5JmjnidJ39iIiea PFnoSysPFt5TnkMF2E9gWT32pwCSuAmsw0xsWSS4= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , torvalds@linux-foundation.org, akpm@linux-foundation.org, linux@roeck-us.net, shuah@kernel.org, patches@kernelci.org, lkft-triage@lists.linaro.org, pavel@denx.de, stable@vger.kernel.org Subject: [PATCH 4.14 000/125] 4.14.204-rc1 review Date: Tue, 3 Nov 2020 21:36:17 +0100 Message-Id: <20201103203156.372184213@linuxfoundation.org> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 User-Agent: quilt/0.66 X-stable: review X-Patchwork-Hint: ignore X-KernelTest-Patch: http://kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.14.204-rc1.gz X-KernelTest-Tree: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git X-KernelTest-Branch: linux-4.14.y X-KernelTest-Patches: git://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git X-KernelTest-Version: 4.14.204-rc1 X-KernelTest-Deadline: 2020-11-05T20:32+00:00 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is the start of the stable review cycle for the 4.14.204 release. There are 125 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Thu, 05 Nov 2020 20:29:58 +0000. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.14.204-rc1.gz or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.14.y and the diffstat can be found below. thanks, greg k-h ------------- Pseudo-Shortlog of commits: Greg Kroah-Hartman Linux 4.14.204-rc1 Alexander Sverdlin staging: octeon: Drop on uncorrectable alignment or FCS error Alexander Sverdlin staging: octeon: repair "fixed-link" support Ian Abbott staging: comedi: cb_pcidas: Allow 2-channel commands for AO subdevice Marc Zyngier KVM: arm64: Fix AArch32 handling of DBGD{CCINT,SCRext} and DBGVCR Andy Shevchenko device property: Don't clear secondary pointer for shared primary firmware node Andy Shevchenko device property: Keep secondary firmware node secondary by type Krzysztof Kozlowski ARM: s3c24xx: fix missing system reset Krzysztof Kozlowski ARM: samsung: fix PM debug build with DEBUG_LL but !MMU Frank Wunderlich arm: dts: mt7623: add missing pause for switchport Helge Deller hil/parisc: Disable HIL driver when it gets stuck Matthew Wilcox (Oracle) cachefiles: Handle readpage error correctly Jisheng Zhang arm64: berlin: Select DW_APB_TIMER_OF Linus Torvalds tty: make FONTX ioctl use the tty pointer they were actually passed Bartosz Golaszewski rtc: rx8010: don't modify the global rtc ops Dave Airlie drm/ttm: fix eviction valuable range check. Constantine Sapuntzakis ext4: fix superblock checksum calculation race Luo Meng ext4: fix invalid inode checksum Dinghao Liu ext4: fix error handling code in add_new_gdb Eric Biggers ext4: fix leaking sysfs kobject after failed mount Stefano Garzarella vringh: fix __vringh_iov() when riov and wiov are different Qiujun Huang ring-buffer: Return 0 on success from ring_buffer_resize() Matthew Wilcox (Oracle) 9P: Cast to loff_t before multiplying Ilya Dryomov libceph: clear con->out_msg on Policy::stateful_server faults Matthew Wilcox (Oracle) ceph: promote to unsigned long long before shifting Madhav Chauhan drm/amdgpu: don't map BO in reserved region Krzysztof Kozlowski ia64: fix build error with !COREDUMP Zhihao Cheng ubi: check kthread_should_stop() after the setting of task state Jiri Olsa perf python scripting: Fix printable strings in python3 scripts Zhihao Cheng ubifs: dent: Fix some potential memory leaks while iterating entries Chuck Lever NFSD: Add missing NFSv2 .pc_func methods Olga Kornievskaia NFSv4.2: support EXCHGID4_FLAG_SUPP_FENCE_OPS 4.2 EXCHANGE_ID flag Mahesh Salgaonkar powerpc/powernv/elog: Fix race while processing OPAL error log event. Joel Stanley powerpc: Warn about use of smt_snooze_delay Andrew Donnellan powerpc/rtas: Restrict RTAS requests from userspace Sven Schnelle s390/stp: add locking to sysfs functions Jonathan Cameron iio:gyro:itg3200: Fix timestamp alignment and prevent data leak. Jonathan Cameron iio:adc:ti-adc12138 Fix alignment issue with timestamp Jonathan Cameron iio:adc:ti-adc0832 Fix alignment issue with timestamp Jonathan Cameron iio:light:si1145: Fix timestamp alignment and prevent data leak. Paul Cercueil dmaengine: dma-jz4780: Fix race in jz4780_dma_tx_status Jiri Slaby vt: keyboard, extend func_buf_lock to readers Jiri Slaby vt: keyboard, simplify vt_kdgkbsent Chris Wilson drm/i915: Force VT'd workarounds when running as a guest OS Ran Wang usb: host: fsl-mph-dr-of: check return of dma_set_mask() Jerome Brunet usb: cdc-acm: fix cooldown mechanism Li Jun usb: dwc3: core: don't trigger runtime pm when remove driver Li Jun usb: dwc3: core: add phy cleanup for probe error handling Thinh Nguyen usb: dwc3: ep0: Fix ZLP for OUT ep0 requests Filipe Manana btrfs: fix use-after-free on readahead extent after failure to create it Josef Bacik btrfs: cleanup cow block on error Denis Efremov btrfs: use kvzalloc() to allocate clone_roots in btrfs_ioctl_send() Filipe Manana btrfs: send, recompute reference path after orphanization of a directory Filipe Manana btrfs: reschedule if necessary when logging directory items Helge Deller scsi: mptfusion: Fix null pointer dereferences in mptscsih_remove() Martin Fuzzey w1: mxc_w1: Fix timeout resolution problem leading to bus error Wei Huang acpi-cpufreq: Honor _PSD table setting on new AMD CPUs Jamie Iles ACPI: debug: don't allow debugging when ACPI is disabled Alex Hung ACPI: video: use ACPI backlight for HP 635 Notebook Ben Hutchings ACPI / extlog: Check for RDMSR failure Ashish Sangwan NFS: fix nfs_path in case of a rename retry Jan Kara fs: Don't invalidate page buffers in block_write_full_page() Marek Behún leds: bcm6328, bcm6358: use devres LED registering function Kim Phillips perf/x86/amd/ibs: Fix raw sample data accumulation Kim Phillips perf/x86/amd/ibs: Don't include randomized bits in get_ibs_op_count() Song Liu md/raid5: fix oops during stripe resizing Chao Leng nvme-rdma: fix crash when connect rejected Douglas Gilbert sgl_alloc_order: fix memory leak Xiubo Li nbd: make the config put is called before the notifying the waiter Krzysztof Kozlowski ARM: dts: s5pv210: remove dedicated 'audio-subsystem' node Krzysztof Kozlowski ARM: dts: s5pv210: move PMU node out of clock controller Krzysztof Kozlowski ARM: dts: s5pv210: remove DMA controller bus node name to fix dtschema warnings Dan Carpenter memory: emif: Remove bogus debugfs error handling Yoshihiro Shimoda arm64: dts: renesas: ulcb: add full-pwr-cycle-in-suspend into eMMC nodes Anant Thazhemadam gfs2: add validation checks for size of superblock Jan Kara ext4: Detect already used quota file early Madhuparna Bhowmik drivers: watchdog: rdc321x_wdt: Fix race condition bugs Anant Thazhemadam net: 9p: initialize sun_server.sun_path to have addr's value only when addr is valid Lorenzo Pieralisi asm-generic/io.h: Fix !CONFIG_GENERIC_IOMAP pci_iounmap() implementation Tero Kristo clk: ti: clockdomain: fix static checker warning Michael Chan bnxt_en: Log unknown link speed appropriately. Zhao Heming md/bitmap: md_bitmap_get_counter returns wrong blocks Xiongfeng Wang power: supply: test_power: add missing newlines when printing parameters by sysfs Diana Craciun bus/fsl_mc: Do not rely on caller to provide non NULL mc_io Xie He drivers/net/wan/hdlc_fr: Correctly handle special skb->protocol values Jonathan Cameron ACPI: Add out of bounds and numa_off protections to pxm_to_node() Zhengyuan Liu arm64/mm: return cpu_all_mask when node is NUMA_NO_NODE Lang Dai uio: free uio id after uio file node is freed Oliver Neukum USB: adutux: fix debugging Alain Volmat cpufreq: sti-cpufreq: add stih418 support Douglas Anderson kgdb: Make "kgdbcon" work properly with "kgdb_earlycon" John Ogness printk: reduce LOG_BUF_SHIFT range for H8300 Antonio Borneo drm/bridge/synopsys: dsi: add support for non-continuous HS clock Madhuparna Bhowmik mmc: via-sdmmc: Fix data race bug Tom Rix media: tw5864: check status of tw5864_frameinterval_get Badhri Jagan Sridharan usb: typec: tcpm: During PR_SWAP, source caps should be sent only after tSwapSourceStart Xia Jiang media: platform: Improve queue set up flow for bug fixing Hans Verkuil media: videodev2.h: RGB BT2020 and HSV are always full range Nadezda Lutovinova drm/brige/megachips: Add checking if ge_b850v3_lvds_init() is working correctly Sathishkumar Muruganandam ath10k: fix VHT NSS calculation when STBC is enabled Wen Gong ath10k: start recovery process when payload length exceeds max htc length for sdio Tom Rix video: fbdev: pvr2fb: initialize variables Darrick J. Wong xfs: fix realtime bitmap/summary file truncation when growing rt volume Douglas Anderson ARM: 8997/2: hw_breakpoint: Handle inexact watchpoint addresses Johannes Berg um: change sigio_spinlock to a mutex Chao Yu f2fs: fix to check segment boundary during SIT page readahead Zhang Qilong f2fs: add trace exit in exception path Nicholas Piggin sparc64: remove mm_cpumask clearing to fix kthread_use_mm race Nicholas Piggin powerpc: select ARCH_WANT_IRQS_OFF_ACTIVATE_MM Oliver O'Halloran powerpc/powernv/smp: Fix spurious DBG() warning Mateusz Nosek futex: Fix incorrect should_fail_futex() handling Amit Cohen mlxsw: core: Fix use-after-free in mlxsw_emad_trans_finish() Jiri Slaby x86/unwind/orc: Fix inactive tasks with stack pointer in %sp on GCC 10 compiled kernels Eric Biggers fscrypt: return -EXDEV for incompatible rename or link into encrypted dir Geert Uytterhoeven ata: sata_rcar: Fix DMA boundary mask Gustavo A. R. Silva mtd: lpddr: Fix bad logic in print_drs_error Jia-Ju Bai p54: avoid accessing the data mapped to streaming DMA Miklos Szeredi fuse: fix page dereference after free Juergen Gross x86/xen: disable Firmware First mode for correctable memory errors Kim Phillips arch/x86/amd/ibs: Fix re-arming IBS Fetch Tung Nguyen tipc: fix memory leak caused by tipc_buf_append() Andrew Gabbasov ravb: Fix bit fields checking in ravb_hwtstamp_get() Masahiro Fujiwara gtp: fix an use-before-init in gtp_newlink() Michael Schaller efivarfs: Replace invalid slashes with exclamation marks in dentries. Nick Desaulniers arm64: link with -z norelro regardless of CONFIG_RELOCATABLE Rasmus Villemoes scripts/setlocalversion: make git describe output more reliable ------------- Diffstat: Documentation/media/uapi/v4l/colorspaces-defs.rst | 9 +- .../media/uapi/v4l/colorspaces-details.rst | 5 +- Makefile | 4 +- arch/arm/Kconfig | 2 + arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts | 1 + arch/arm/boot/dts/s5pv210.dtsi | 127 ++++++++--------- arch/arm/kernel/hw_breakpoint.c | 100 ++++++++++---- arch/arm/plat-samsung/Kconfig | 1 + arch/arm64/Kconfig.platforms | 1 + arch/arm64/Makefile | 4 +- arch/arm64/boot/dts/renesas/ulcb.dtsi | 1 + arch/arm64/include/asm/kvm_host.h | 1 + arch/arm64/include/asm/numa.h | 3 + arch/arm64/kvm/sys_regs.c | 6 +- arch/arm64/mm/numa.c | 6 +- arch/ia64/kernel/Makefile | 2 +- arch/powerpc/Kconfig | 14 ++ arch/powerpc/include/asm/mmu_context.h | 2 +- arch/powerpc/kernel/rtas.c | 153 +++++++++++++++++++++ arch/powerpc/kernel/sysfs.c | 42 +++--- arch/powerpc/platforms/powernv/opal-elog.c | 33 ++++- arch/powerpc/platforms/powernv/smp.c | 2 +- arch/s390/kernel/time.c | 118 +++++++++++----- arch/sparc/kernel/smp_64.c | 65 ++------- arch/um/kernel/sigio.c | 6 +- arch/x86/events/amd/ibs.c | 53 +++++-- arch/x86/include/asm/msr-index.h | 1 + arch/x86/kernel/unwind_orc.c | 9 +- arch/x86/xen/enlighten_pv.c | 9 ++ drivers/acpi/acpi_dbg.c | 3 + drivers/acpi/acpi_extlog.c | 6 +- drivers/acpi/numa.c | 2 +- drivers/acpi/video_detect.c | 9 ++ drivers/ata/sata_rcar.c | 2 +- drivers/base/core.c | 4 +- drivers/block/nbd.c | 2 +- drivers/clk/ti/clockdomain.c | 2 + drivers/cpufreq/acpi-cpufreq.c | 3 +- drivers/cpufreq/sti-cpufreq.c | 6 +- drivers/dma/dma-jz4780.c | 7 +- drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c | 10 ++ .../drm/bridge/megachips-stdpxxxx-ge-b850v3-fw.c | 12 +- drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 9 +- drivers/gpu/drm/i915/i915_drv.h | 6 +- drivers/gpu/drm/ttm/ttm_bo.c | 2 +- drivers/iio/adc/ti-adc0832.c | 11 +- drivers/iio/adc/ti-adc12138.c | 13 +- drivers/iio/gyro/itg3200_buffer.c | 15 +- drivers/iio/light/si1145.c | 19 +-- drivers/input/serio/hil_mlc.c | 21 ++- drivers/input/serio/hp_sdc_mlc.c | 8 +- drivers/leds/leds-bcm6328.c | 2 +- drivers/leds/leds-bcm6358.c | 2 +- drivers/md/bitmap.c | 2 +- drivers/md/raid5.c | 4 +- drivers/media/pci/tw5864/tw5864-video.c | 6 + drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c | 7 + drivers/memory/emif.c | 33 +---- drivers/message/fusion/mptscsih.c | 13 +- drivers/mmc/host/via-sdmmc.c | 3 + drivers/mtd/ubi/wl.c | 13 ++ drivers/net/ethernet/broadcom/bnxt/bnxt.c | 6 +- drivers/net/ethernet/mellanox/mlxsw/core.c | 3 + drivers/net/ethernet/renesas/ravb_main.c | 10 +- drivers/net/gtp.c | 16 +-- drivers/net/wan/hdlc_fr.c | 98 ++++++------- drivers/net/wireless/ath/ath10k/htt_rx.c | 8 +- drivers/net/wireless/ath/ath10k/sdio.c | 4 + drivers/net/wireless/intersil/p54/p54pci.c | 4 +- drivers/nvme/host/rdma.c | 1 - drivers/power/supply/test_power.c | 6 + drivers/rtc/rtc-rx8010.c | 24 +++- drivers/staging/comedi/drivers/cb_pcidas.c | 1 + drivers/staging/fsl-mc/bus/mc-io.c | 7 +- drivers/staging/octeon/ethernet-mdio.c | 6 - drivers/staging/octeon/ethernet-rx.c | 34 +++-- drivers/staging/octeon/ethernet.c | 9 ++ drivers/staging/typec/pd.h | 1 + drivers/staging/typec/tcpm.c | 2 +- drivers/tty/vt/keyboard.c | 39 +++--- drivers/tty/vt/vt_ioctl.c | 32 +++-- drivers/uio/uio.c | 4 +- drivers/usb/class/cdc-acm.c | 12 +- drivers/usb/class/cdc-acm.h | 3 +- drivers/usb/dwc3/core.c | 15 +- drivers/usb/dwc3/ep0.c | 11 +- drivers/usb/host/fsl-mph-dr-of.c | 9 +- drivers/usb/misc/adutux.c | 1 + drivers/vhost/vringh.c | 9 +- drivers/video/fbdev/pvr2fb.c | 2 + drivers/w1/masters/mxc_w1.c | 14 +- drivers/watchdog/rdc321x_wdt.c | 5 +- fs/9p/vfs_file.c | 4 +- fs/btrfs/ctree.c | 6 + fs/btrfs/reada.c | 2 + fs/btrfs/send.c | 74 +++++++++- fs/btrfs/tree-log.c | 8 ++ fs/buffer.c | 16 --- fs/cachefiles/rdwr.c | 3 +- fs/ceph/addr.c | 2 +- fs/crypto/policy.c | 3 +- fs/efivarfs/super.c | 3 + fs/ext4/inode.c | 11 +- fs/ext4/namei.c | 6 +- fs/ext4/resize.c | 4 +- fs/ext4/super.c | 17 +++ fs/f2fs/checkpoint.c | 8 +- fs/f2fs/namei.c | 6 +- fs/fuse/dev.c | 28 ++-- fs/gfs2/ops_fstype.c | 18 ++- fs/nfs/namespace.c | 12 +- fs/nfs/nfs4proc.c | 9 +- fs/nfsd/nfsproc.c | 16 +++ fs/ubifs/debug.c | 1 + fs/ubifs/dir.c | 6 +- fs/xfs/xfs_rtalloc.c | 10 +- include/asm-generic/io.h | 39 ++++-- include/linux/hil_mlc.h | 2 +- include/linux/mtd/pfow.h | 2 +- include/uapi/linux/nfs4.h | 3 + include/uapi/linux/videodev2.h | 17 ++- init/Kconfig | 3 +- kernel/debug/debug_core.c | 22 +-- kernel/futex.c | 4 +- kernel/trace/ring_buffer.c | 8 +- lib/scatterlist.c | 2 +- net/9p/trans_fd.c | 2 +- net/ceph/messenger.c | 5 + net/tipc/msg.c | 5 +- scripts/setlocalversion | 21 ++- tools/perf/util/print_binary.c | 2 +- 131 files changed, 1227 insertions(+), 616 deletions(-)