Received: by 2002:a05:6622:f08:0:0:0:0 with SMTP id l8csp4488812ivc; Tue, 3 Nov 2020 13:22:51 -0800 (PST) X-Google-Smtp-Source: ABdhPJyN2fQiYojtPXHianDKt6WRLPoMBlBHAt2P2Nw1ccE1+eBsNAhtFqbPrUou59MXHWxOboCz X-Received: by 2002:a17:906:398b:: with SMTP id h11mr22711634eje.277.1604438571451; Tue, 03 Nov 2020 13:22:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604438571; cv=none; d=google.com; s=arc-20160816; b=atUoRpVCSwhUQlXHAR3L76gDfbP61LK0DkwhVqKn+xI6iIJCAdFp+0e2h5lq4sQ7vg lzYe/lPaa10Ub9E4gYhgTfWL7J9y2uQx74a2PgiMWKCdiGK+NRrcThGuMU6Mm9+vDyDm pYTDTrEvTtDril9kZzybc/k3P9lBUrwKaaYxDQhjDke0+mFeIaObsnGB7bumCEHSsF6W zLfRZXYPf/8lyXUJfqe1u8kA6N8ScFba/BKMrNEOmGqixcwZD8mRtwZ+tCvIqATDoF1k 7euxiZ/QG91KWl/mqE5TbFIo9d1K0WuVtotlA6kFNtfmDVISlbwP3k2MvQ9rMGRQmglD avQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Nh88J3Mr5NODYdqoPNqe5WYd4dDdDy1NEVpHVAilqDs=; b=KKOGlOwhjXgtEW+xuDqPEjRAbTvHN4wU4+7A/G+rTmnDBd2qYszBdJlmK6HLHE7Nqi BiJDSBZeGfhQdecqqcg/FLQmHSOz951Z2k/e3okHoIxjxae8ZLCpy5Ld7RMO0IqHeBHj A4dWQV94F1pttvkA7SiLVZfib0JnESRPmu82tnE+Z+wnSlEGg05/G2xekIbbWzLEhFHB E0vRJweE4M6DVHYB1lteiie2RBj1pk5TYfDyqvK8CSfGmGlO6ZkemNClvKOKAG1bd7y0 2nOKB+BGx31/VQQvAhC2mYzsXgpQ0Aby/fuF7SOEe3X31lUiqiQJHGV2ddVIAuR89rso wg3w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=RLYRfiVY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id du18si14586ejc.665.2020.11.03.13.22.28; Tue, 03 Nov 2020 13:22:51 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=RLYRfiVY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730019AbgKCVTv (ORCPT + 99 others); Tue, 3 Nov 2020 16:19:51 -0500 Received: from mail.kernel.org ([198.145.29.99]:47218 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388355AbgKCVHw (ORCPT ); Tue, 3 Nov 2020 16:07:52 -0500 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AEF82205ED; Tue, 3 Nov 2020 21:07:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604437672; bh=d6BMHzK4XpMulQAyPTS2drc2oo+njpraHmLdyy4Jkz0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=RLYRfiVYJqubH/4QveLCa0E2JC0AVHg549IitzB/b0TZ7flQi1sXCjRakY7V5n3FQ aCBeYXxAZ4HFZl2PRlpVfs0oCyWxF1BrtuLsYuWIKyt3Ly96JNnwn5jSI1uQgK/CYN LIualF+zJGrtG/IW2MzjsRFML4NpNb1vOTiAwgBc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dave Airlie , =?UTF-8?q?Christian=20K=C3=B6nig?= Subject: [PATCH 4.19 177/191] drm/ttm: fix eviction valuable range check. Date: Tue, 3 Nov 2020 21:37:49 +0100 Message-Id: <20201103203249.196811678@linuxfoundation.org> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201103203232.656475008@linuxfoundation.org> References: <20201103203232.656475008@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dave Airlie commit fea456d82c19d201c21313864105876deabe148b upstream. This was adding size to start, but pfn and start are in pages, so it should be using num_pages. Not sure this fixes anything in the real world, just noticed it during refactoring. Signed-off-by: Dave Airlie Reviewed-by: Christian König Cc: stable@vger.kernel.org Link: https://patchwork.freedesktop.org/patch/msgid/20201019222257.1684769-2-airlied@gmail.com Signed-off-by: Greg Kroah-Hartman --- drivers/gpu/drm/ttm/ttm_bo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/gpu/drm/ttm/ttm_bo.c +++ b/drivers/gpu/drm/ttm/ttm_bo.c @@ -671,7 +671,7 @@ bool ttm_bo_eviction_valuable(struct ttm /* Don't evict this BO if it's outside of the * requested placement range */ - if (place->fpfn >= (bo->mem.start + bo->mem.size) || + if (place->fpfn >= (bo->mem.start + bo->mem.num_pages) || (place->lpfn && place->lpfn <= bo->mem.start)) return false;