Received: by 2002:a05:6622:f08:0:0:0:0 with SMTP id l8csp4490033ivc; Tue, 3 Nov 2020 13:25:14 -0800 (PST) X-Google-Smtp-Source: ABdhPJxbvTDb+A9BXlXqHPBMJCZQCuBzOv/lJHmoEEB+k5s+99YcUKoyB2MrMiZcYoQVuRPksilS X-Received: by 2002:a17:906:3a55:: with SMTP id a21mr21453594ejf.357.1604438713892; Tue, 03 Nov 2020 13:25:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604438713; cv=none; d=google.com; s=arc-20160816; b=raMe0ID/7QU+29g9K9aA0RNx3q+4UTaEfwtauv29NINewH0QxgtBEjUzNcFgOaVQZp PoKr+tHsZ9vGot0bVHE9MMIzZfbNgpfH5MOC+kHPlUY080M6kRFIhNnxv78mo6SDXak/ F6Sk9kGdFQwHaULaFqYblY5BmPjuC4IKOR3ztqqjOIkOPmWRCAUqqVdEbRvI4cuAXSsh GS/Mhd3LD+T5D5ZSqJwMh1FK9YEbP1go43QwHBN8VnZ9B+/8mduFHy1OJb2GmzP6hi29 7s0YDLOM36vYmrKHyAh5Eofa7umNw+XO5nt6TVsZmAzOJBZcEXb2Nk2b5U8bxWgPgFIU tDkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=wPbvOs1pcmWpjpCoNJOui2l4WTHUMEiu3n3YtZT46cE=; b=X+d+KldanHEbvRN7pnO/fe1tdt6npqxb6ZLWnDgzwr4JiM7F4F9PoV4G/uH+xvabk0 dyowpvWgxcf8n+4P5ZbT57PV90XFIGxde1kebosFMWBLRV+O+15FCSP2hjuk1uWDcghN kO4C48urOAK6MShOMMeXDQdnoe9k2r6X9LAZm2Xc12CyJlqcvkS31MocDK1kJYg/a4ff UqDfc3obwUVWsjYSg4oeNXiR41jmC1PN9i5jpjfRNWoP3cFEGlS40VZ/cSAR8YikAYQR 0voXStLVTplthS2Fytu/biC6vI+34bVWcWYC51FE9OHXCGCpN7ic0MNU4F8nKmx7gNRe 4I1w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=jahEy6rI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r7si68865ejb.27.2020.11.03.13.24.51; Tue, 03 Nov 2020 13:25:13 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=jahEy6rI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388256AbgKCVWK (ORCPT + 99 others); Tue, 3 Nov 2020 16:22:10 -0500 Received: from mail.kernel.org ([198.145.29.99]:44114 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387804AbgKCVFd (ORCPT ); Tue, 3 Nov 2020 16:05:33 -0500 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9F6D222226; Tue, 3 Nov 2020 21:05:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604437533; bh=iGi1A/HIjlPZYD+2SeqNGeJAXliQ5RfNBdSLrnNyclk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=jahEy6rIl84167K+ARLhHGPnQrBloLj98/N7WePnDoVzB43zLCKZ/85ZMs0TtBUTq HkC7UDPqrpA4YFzmmosM5E0TAyDg4T4J4JV0b6aYRw84vFZ3eCPYkWW/irxl9sUnfa YhRatRS9gHtLIMwhF1FpmXKQTlIcidd+OdTQgpfc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, =?UTF-8?q?Marek=20Beh=C3=BAn?= , =?UTF-8?q?=C3=81lvaro=20Fern=C3=A1ndez=20Rojas?= , Kevin Cernekee , Jaedon Shin , Pavel Machek , stable@kernel.org Subject: [PATCH 4.19 116/191] leds: bcm6328, bcm6358: use devres LED registering function Date: Tue, 3 Nov 2020 21:36:48 +0100 Message-Id: <20201103203244.236927317@linuxfoundation.org> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201103203232.656475008@linuxfoundation.org> References: <20201103203232.656475008@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Marek Behún commit ff5c89d44453e7ad99502b04bf798a3fc32c758b upstream. These two drivers do not provide remove method and use devres for allocation of other resources, yet they use led_classdev_register instead of the devres variant, devm_led_classdev_register. Fix this. Signed-off-by: Marek Behún Cc: Álvaro Fernández Rojas Cc: Kevin Cernekee Cc: Jaedon Shin Signed-off-by: Pavel Machek Cc: stable@kernel.org Signed-off-by: Greg Kroah-Hartman --- drivers/leds/leds-bcm6328.c | 2 +- drivers/leds/leds-bcm6358.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) --- a/drivers/leds/leds-bcm6328.c +++ b/drivers/leds/leds-bcm6328.c @@ -336,7 +336,7 @@ static int bcm6328_led(struct device *de led->cdev.brightness_set = bcm6328_led_set; led->cdev.blink_set = bcm6328_blink_set; - rc = led_classdev_register(dev, &led->cdev); + rc = devm_led_classdev_register(dev, &led->cdev); if (rc < 0) return rc; --- a/drivers/leds/leds-bcm6358.c +++ b/drivers/leds/leds-bcm6358.c @@ -141,7 +141,7 @@ static int bcm6358_led(struct device *de led->cdev.brightness_set = bcm6358_led_set; - rc = led_classdev_register(dev, &led->cdev); + rc = devm_led_classdev_register(dev, &led->cdev); if (rc < 0) return rc;