Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp820474pxb; Tue, 3 Nov 2020 13:28:58 -0800 (PST) X-Google-Smtp-Source: ABdhPJwaIImPm8HRi9oXIDMDtlMg2WHe070q61xs86gGn2VOvYS5yXELy4iOGd+V6rkLtU/g4UVW X-Received: by 2002:a17:906:158e:: with SMTP id k14mr21328701ejd.496.1604438938131; Tue, 03 Nov 2020 13:28:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604438938; cv=none; d=google.com; s=arc-20160816; b=YbxC6fGO4WDF5/lpEr7yEnZMncjKEfxSSdYTcMaZ0VOCRqFNT0RMiKGSslQE1+48Uh QMrNKcrcHCmnri68nPMdWlO+BNyxd84CdB+VfD6qg8nfoFxiukIKR9hz+HO6vko1Tcyr LlAKQ5azH1u9e3wE5d2hsIFoUHiWKdEETdPLgBWeWe7sxHbN/pqwMXXLVHAJBFbSFTNm fzEImz1ec5ttevvGyMZVLMXuPdheSz6+DUUTl6CtFb8UEk/JstZ8Of3a8/GgA9/ELIE+ M6dPkFKivZ4oORLTU+r8ZyVyVL4Gr6bbYR6jNcNKOqvgaBctOPsfUGIkJ0l4afwctVbh lDgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=WksCj4Wt99wAFB8eR02JW/7nUk6bXrF4Uhb1OoL4OYc=; b=lP3zsRU0scYzzmwJ9F/oCrxCOg7XW7GzsdMHmE077Mj+Oug8xA7/GG0z1dx9M6B5ze qagybTaBPYOb3vFE2EEzt3pnDK8/AdCaqRSNIhU2tj85FlC3zmWsqMIttZyWeFbBI+ek UWTg4mWjjl3CNHicnPLifj97Rv7hg+3sGGV/sYgcJ6qgjd3n7f4twQTeE/OweCzUKiI8 l93CMddu3w0YumZ9XjH/70E8Z1rXxNCEY9GmGYlCuVGzXGKfhMmCJuwuxyF6F0FzgSj3 6ZlUJVy5jbypqs+Y4jXwf+Buz64rMVxk8crTWpJigfhz2Y//ERM8AfbMzHIiXdkGkMcR TEMA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=1CVMswq9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id du18si14586ejc.665.2020.11.03.13.28.35; Tue, 03 Nov 2020 13:28:58 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=1CVMswq9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387566AbgKCVCG (ORCPT + 99 others); Tue, 3 Nov 2020 16:02:06 -0500 Received: from mail.kernel.org ([198.145.29.99]:38914 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387553AbgKCVCC (ORCPT ); Tue, 3 Nov 2020 16:02:02 -0500 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1F12F20757; Tue, 3 Nov 2020 21:02:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604437321; bh=ImkCi6wVJfwB6SBF9cHHXCHQVVWly6Y7DHUD+gkteAc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=1CVMswq9UIVQzKng7RyMgOR9CObkELbMqls7fsG4GKj4CcvJXiRhwT098Is5jpKhl Pinxa/HPQcNkxX5d87NnNyhDjLp19VrTRu9Uj4ZGR7pJIXuDn55az4vIbs/O/7L0Ym 9XvV5jY9tye4Y4EKKz5It6Iv4/r8cOk1uAlgNM9s= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Joe Perches , "Gustavo A. R. Silva" , Miquel Raynal Subject: [PATCH 4.19 026/191] mtd: lpddr: Fix bad logic in print_drs_error Date: Tue, 3 Nov 2020 21:35:18 +0100 Message-Id: <20201103203236.101496917@linuxfoundation.org> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201103203232.656475008@linuxfoundation.org> References: <20201103203232.656475008@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Gustavo A. R. Silva commit 1c9c02bb22684f6949d2e7ddc0a3ff364fd5a6fc upstream. Update logic for broken test. Use a more common logging style. It appears the logic in this function is broken for the consecutive tests of if (prog_status & 0x3) ... else if (prog_status & 0x2) ... else (prog_status & 0x1) ... Likely the first test should be if ((prog_status & 0x3) == 0x3) Found by inspection of include files using printk. Fixes: eb3db27507f7 ("[MTD] LPDDR PFOW definition") Cc: stable@vger.kernel.org Reported-by: Joe Perches Signed-off-by: Gustavo A. R. Silva Acked-by: Miquel Raynal Signed-off-by: Miquel Raynal Link: https://lore.kernel.org/linux-mtd/3fb0e29f5b601db8be2938a01d974b00c8788501.1588016644.git.gustavo@embeddedor.com Signed-off-by: Greg Kroah-Hartman --- include/linux/mtd/pfow.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/include/linux/mtd/pfow.h +++ b/include/linux/mtd/pfow.h @@ -128,7 +128,7 @@ static inline void print_drs_error(unsig if (!(dsr & DSR_AVAILABLE)) printk(KERN_NOTICE"DSR.15: (0) Device not Available\n"); - if (prog_status & 0x03) + if ((prog_status & 0x03) == 0x03) printk(KERN_NOTICE"DSR.9,8: (11) Attempt to program invalid " "half with 41h command\n"); else if (prog_status & 0x02)