Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp820628pxb; Tue, 3 Nov 2020 13:29:15 -0800 (PST) X-Google-Smtp-Source: ABdhPJzg/IZtxBZ6CKg0VeHSFjdWPEfJhDNEckzWc7E7rgjLM3lt/8zlcAv2LFsKZLqC1eOy6ns3 X-Received: by 2002:aa7:d5d7:: with SMTP id d23mr23042912eds.207.1604438954787; Tue, 03 Nov 2020 13:29:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604438954; cv=none; d=google.com; s=arc-20160816; b=xgQfwDmxaUtGDqyTa/E9N3MNEbXuDtmp15Higcwpgph7lzEAxH/CTWCHQ6nz4+8xtW AgUcAK3zMtssn99u1tZmr9/+3SUbXjHKtJW3aeF/fdseY4TZgb1KOVhd1BWfN+h6JMfU hfwNBP5XaCr72zR31R8PtNHeivDEmSZ+VIjvW/9l5TyGVoFvjkC2FPId6fomKisrMVNq Wow1ghZb5HwA7PJWbhFkMrxrq8K1bCja4yLguGHMzZyOlPFpqZu8pcdPzB8n1omEjCj+ ijbtTV8L2JSBd0s5NHPiIf0FXPh4L5QVu1fUxGLvlRo42u78TYVYVk4dWhlMzOlA6xjx vC1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=K3GFquwhS9nJJ9BwauAT/cSPMOHo+lkj3aHA5QC6bNA=; b=Mg3+Pf6FLxkWvqXp6NmYAN1Ck/+Q5AhaFbeGqDU4yT3jPQmsk4nmj1Fw3bZjqyL8Ln KpsHzj20PJD9R7G1dRV1SpTDYhPygTbRJoD/mM8H1cyccIBq9wFy+LVLAhcgAARoZ5qP 4Lzmh/oxvcDNgG7mArQlc9JQL7xf5sBSZw8ZpAvZg7Hk1r6/vxii70yG3I7A8VlA86YZ 5dzediS54BOEbAJ5gMWQkIw5rRBcfn7RYnvVO1GN0PkG9w9S/DPRVy5RMpczRPpazb0k 1UQjKxt34Gi2Eh37M4l97pfPE+J9NJbXJgIrdzVi3tn831QZJ/ChH2+SU/rTiPcwEnuU idjw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="Dubj/fG8"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r7si68865ejb.27.2020.11.03.13.28.50; Tue, 03 Nov 2020 13:29:14 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="Dubj/fG8"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388341AbgKCVYS (ORCPT + 99 others); Tue, 3 Nov 2020 16:24:18 -0500 Received: from mail.kernel.org ([198.145.29.99]:41560 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1733149AbgKCVDs (ORCPT ); Tue, 3 Nov 2020 16:03:48 -0500 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AE7C8205ED; Tue, 3 Nov 2020 21:03:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604437428; bh=oJtTplmNJNvs7Mo10FiWtel76dE5oqri6ckqzcr7eNI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Dubj/fG8kw8/NSsLdFIHE3/Xu2kxK2DnLVPcclB+ZwCqWiVtyDjoF1qpbGbQVsWx/ RADeY0OIN/cX0VatwKMKLbgtRu66NGRJBPTJZvCIeItH5gc4c7DMubiXmmPrkqGzqL VLBv6dY1CKo6saGuL+r+tK6bKqomUqzhMb279Yzw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Tom Rix , Hans Verkuil , Mauro Carvalho Chehab , Sasha Levin Subject: [PATCH 4.19 072/191] media: tw5864: check status of tw5864_frameinterval_get Date: Tue, 3 Nov 2020 21:36:04 +0100 Message-Id: <20201103203241.150051817@linuxfoundation.org> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201103203232.656475008@linuxfoundation.org> References: <20201103203232.656475008@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Tom Rix [ Upstream commit 780d815dcc9b34d93ae69385a8465c38d423ff0f ] clang static analysis reports this problem tw5864-video.c:773:32: warning: The left expression of the compound assignment is an uninitialized value. The computed value will also be garbage fintv->stepwise.max.numerator *= std_max_fps; ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ stepwise.max is set with frameinterval, which comes from ret = tw5864_frameinterval_get(input, &frameinterval); fintv->stepwise.step = frameinterval; fintv->stepwise.min = frameinterval; fintv->stepwise.max = frameinterval; fintv->stepwise.max.numerator *= std_max_fps; When tw5864_frameinterval_get() fails, frameinterval is not set. So check the status and fix another similar problem. Signed-off-by: Tom Rix Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/pci/tw5864/tw5864-video.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/media/pci/tw5864/tw5864-video.c b/drivers/media/pci/tw5864/tw5864-video.c index 6c40e60ac9939..b0f8d1532b700 100644 --- a/drivers/media/pci/tw5864/tw5864-video.c +++ b/drivers/media/pci/tw5864/tw5864-video.c @@ -776,6 +776,9 @@ static int tw5864_enum_frameintervals(struct file *file, void *priv, fintv->type = V4L2_FRMIVAL_TYPE_STEPWISE; ret = tw5864_frameinterval_get(input, &frameinterval); + if (ret) + return ret; + fintv->stepwise.step = frameinterval; fintv->stepwise.min = frameinterval; fintv->stepwise.max = frameinterval; @@ -794,6 +797,9 @@ static int tw5864_g_parm(struct file *file, void *priv, cp->capability = V4L2_CAP_TIMEPERFRAME; ret = tw5864_frameinterval_get(input, &cp->timeperframe); + if (ret) + return ret; + cp->timeperframe.numerator *= input->frame_interval; cp->capturemode = 0; cp->readbuffers = 2; -- 2.27.0