Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp829692pxb; Tue, 3 Nov 2020 13:45:55 -0800 (PST) X-Google-Smtp-Source: ABdhPJw61BTptyQwH2teWAIPIvpnN52l+ChnVFyTnYUHFCHjnpLL8Ha/kfUWKmc6rc1GIowgmNf9 X-Received: by 2002:aa7:c597:: with SMTP id g23mr14842833edq.184.1604439955181; Tue, 03 Nov 2020 13:45:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604439955; cv=none; d=google.com; s=arc-20160816; b=0nRKlXFR/pvm21qFb4ADdzSKdZ7ipT9a2vLqOU/Bwv/Yw54MonebJGtpHF4RdazyXb FPYlE5bZgwt2w2sYkyDv8uJu7YheY7aIZCqGcMYpOAq647xPPM/uRWHe6oXkAssWVFg8 PxXYS3uOLj4Wu4WXSThzttK9UmrGTtPRPply9PJyTPeK9nsYD/mNyCD2dS7I4kKRIbF3 rfFdRGeI+qE2c7tuH2UadNh0VE1MBWTVMzLg62qyMnIRM6B89KoXfmY2Mzz0T0SSKBpA Ruhnxi2OKAAxXvltqxliE1zkjhnWAvZ3iBH27JVyaHPZ+dDerI3HlfA+PUYgesACHTV5 noDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:autocrypt:from :references:cc:to:subject:ironport-sdr:ironport-sdr; bh=C4vyhTDKKoKWzM7QW1KWhOxTAvfkOdgvlbpmCSDFv1A=; b=xi/0jg55RcZycYp06RWYTM+069nIomra8PDYo7m4qObQIUFg/hYRUAYDXVulg3XD80 TueTRvVfwx/aRGyLel99i0+Wh81UKzVRAyFF58uN3/Tw+WaKjnx3F3IX3k94rU7jil/0 cEuVVFvkZzTg7rom/r3ND1pfeAXE4RWr2eBycOnxPjv9vk8c24/yQLqSLliNXywuap5k 9i4ffk8mrDLUd8AapBa5w22fKFuNib+/oqadqALvNQkHNf0f+Nz0V76EslM/801M78Oi rC4y1Ixwqg4SXrkG9Kru4YWNKsYoHQPqAe3BHIMtNjH730SZ23BvCzg5U3pzKjuVEDXv C7Rg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i7si7880974edj.303.2020.11.03.13.45.32; Tue, 03 Nov 2020 13:45:55 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732450AbgKCVle (ORCPT + 99 others); Tue, 3 Nov 2020 16:41:34 -0500 Received: from mga05.intel.com ([192.55.52.43]:2776 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732013AbgKCVld (ORCPT ); Tue, 3 Nov 2020 16:41:33 -0500 IronPort-SDR: o2rhVnaB2dlY710dwH8PrK0mNM/hTs98fnKV1bKDYqHfVZQJkRHDu988Z1hgz/NHOYz8HrzhP1 LFB0xPGNqhlg== X-IronPort-AV: E=McAfee;i="6000,8403,9794"; a="253841426" X-IronPort-AV: E=Sophos;i="5.77,449,1596524400"; d="scan'208";a="253841426" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Nov 2020 13:41:31 -0800 IronPort-SDR: xrCVnZmmRhAIg41xcfqlriHqiX0oynCn+bNaXurSgm82kao+7FPjOikNGUtDXLw2hkZTgfF/CE W+92wKh4Y64A== X-IronPort-AV: E=Sophos;i="5.77,449,1596524400"; d="scan'208";a="538643883" Received: from gasolorz-mobl.amr.corp.intel.com (HELO [10.209.185.200]) ([10.209.185.200]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Nov 2020 13:41:30 -0800 Subject: Re: [RFC PATCH 13/22] x86/fpu/xstate: Expand dynamic user state area on first use To: "Bae, Chang Seok" , "Lutomirski, Andy" Cc: "mingo@kernel.org" , "linux-kernel@vger.kernel.org" , "bp@suse.de" , "tglx@linutronix.de" , "Liu, Jing2" , "x86@kernel.org" , "luto@kernel.org" , "Shankar, Ravi V" , "Brown, Len" References: <78F221DB-CB61-40DB-9C6F-6C86D0F1BCDF@amacapital.net> <226772b9-7109-c632-2e9a-372df38b81a0@intel.com> <69721125-4e1c-ca9c-ff59-8e1331933e6c@intel.com> From: Dave Hansen Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzShEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gPGRhdmVAc3I3MS5uZXQ+wsF7BBMBAgAlAhsDBgsJCAcDAgYVCAIJ CgsEFgIDAQIeAQIXgAUCTo3k0QIZAQAKCRBoNZUwcMmSsMO2D/421Xg8pimb9mPzM5N7khT0 2MCnaGssU1T59YPE25kYdx2HntwdO0JA27Wn9xx5zYijOe6B21ufrvsyv42auCO85+oFJWfE K2R/IpLle09GDx5tcEmMAHX6KSxpHmGuJmUPibHVbfep2aCh9lKaDqQR07gXXWK5/yU1Dx0r VVFRaHTasp9fZ9AmY4K9/BSA3VkQ8v3OrxNty3OdsrmTTzO91YszpdbjjEFZK53zXy6tUD2d e1i0kBBS6NLAAsqEtneplz88T/v7MpLmpY30N9gQU3QyRC50jJ7LU9RazMjUQY1WohVsR56d ORqFxS8ChhyJs7BI34vQusYHDTp6PnZHUppb9WIzjeWlC7Jc8lSBDlEWodmqQQgp5+6AfhTD kDv1a+W5+ncq+Uo63WHRiCPuyt4di4/0zo28RVcjtzlGBZtmz2EIC3vUfmoZbO/Gn6EKbYAn rzz3iU/JWV8DwQ+sZSGu0HmvYMt6t5SmqWQo/hyHtA7uF5Wxtu1lCgolSQw4t49ZuOyOnQi5 f8R3nE7lpVCSF1TT+h8kMvFPv3VG7KunyjHr3sEptYxQs4VRxqeirSuyBv1TyxT+LdTm6j4a mulOWf+YtFRAgIYyyN5YOepDEBv4LUM8Tz98lZiNMlFyRMNrsLV6Pv6SxhrMxbT6TNVS5D+6 UorTLotDZKp5+M7BTQRUY85qARAAsgMW71BIXRgxjYNCYQ3Xs8k3TfAvQRbHccky50h99TUY sqdULbsb3KhmY29raw1bgmyM0a4DGS1YKN7qazCDsdQlxIJp9t2YYdBKXVRzPCCsfWe1dK/q 66UVhRPP8EGZ4CmFYuPTxqGY+dGRInxCeap/xzbKdvmPm01Iw3YFjAE4PQ4hTMr/H76KoDbD cq62U50oKC83ca/PRRh2QqEqACvIH4BR7jueAZSPEDnzwxvVgzyeuhwqHY05QRK/wsKuhq7s UuYtmN92Fasbxbw2tbVLZfoidklikvZAmotg0dwcFTjSRGEg0Gr3p/xBzJWNavFZZ95Rj7Et db0lCt0HDSY5q4GMR+SrFbH+jzUY/ZqfGdZCBqo0cdPPp58krVgtIGR+ja2Mkva6ah94/oQN lnCOw3udS+Eb/aRcM6detZr7XOngvxsWolBrhwTQFT9D2NH6ryAuvKd6yyAFt3/e7r+HHtkU kOy27D7IpjngqP+b4EumELI/NxPgIqT69PQmo9IZaI/oRaKorYnDaZrMXViqDrFdD37XELwQ gmLoSm2VfbOYY7fap/AhPOgOYOSqg3/Nxcapv71yoBzRRxOc4FxmZ65mn+q3rEM27yRztBW9 AnCKIc66T2i92HqXCw6AgoBJRjBkI3QnEkPgohQkZdAb8o9WGVKpfmZKbYBo4pEAEQEAAcLB XwQYAQIACQUCVGPOagIbDAAKCRBoNZUwcMmSsJeCEACCh7P/aaOLKWQxcnw47p4phIVR6pVL e4IEdR7Jf7ZL00s3vKSNT+nRqdl1ugJx9Ymsp8kXKMk9GSfmZpuMQB9c6io1qZc6nW/3TtvK pNGz7KPPtaDzvKA4S5tfrWPnDr7n15AU5vsIZvgMjU42gkbemkjJwP0B1RkifIK60yQqAAlT YZ14P0dIPdIPIlfEPiAWcg5BtLQU4Wg3cNQdpWrCJ1E3m/RIlXy/2Y3YOVVohfSy+4kvvYU3 lXUdPb04UPw4VWwjcVZPg7cgR7Izion61bGHqVqURgSALt2yvHl7cr68NYoFkzbNsGsye9ft M9ozM23JSgMkRylPSXTeh5JIK9pz2+etco3AfLCKtaRVysjvpysukmWMTrx8QnI5Nn5MOlJj 1Ov4/50JY9pXzgIDVSrgy6LYSMc4vKZ3QfCY7ipLRORyalFDF3j5AGCMRENJjHPD6O7bl3Xo 4DzMID+8eucbXxKiNEbs21IqBZbbKdY1GkcEGTE7AnkA3Y6YB7I/j9mQ3hCgm5muJuhM/2Fr OPsw5tV/LmQ5GXH0JQ/TZXWygyRFyyI2FqNTx4WHqUn3yFj8rwTAU1tluRUYyeLy0ayUlKBH ybj0N71vWO936MqP6haFERzuPAIpxj2ezwu0xb1GjTk4ynna6h5GjnKgdfOWoRtoWndMZxbA z5cecg== Message-ID: Date: Tue, 3 Nov 2020 13:41:29 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/3/20 1:32 PM, Bae, Chang Seok wrote: > On Wed, 2020-10-14 at 09:29 -0700, Dave Hansen wrote: >> On 10/14/20 9:10 AM, Andy Lutomirski wrote: >>> I was suggesting something a little bit different. We'd keep XMM, >>> YMM, ZMM, etc state stored exactly the way we do now and, for >>> AMX-using tasks, we would save the AMX state in an entirely separate >>> buffer. This way the pain of having a variable xstate layout is >>> confined just to AMX tasks. >> OK, got it. >> >> So, we'd either need a second set of XSAVE/XRSTORs, or "manual" copying >> of the registers out to memory. We can preserve the modified >> optimization if we're careful about ordering, but only for *ONE* of the >> XSAVE buffers (if we use two). > For what is worth, > > If using two buffers, the buffer for saving the tile data also needs space > for the legacy states. Just to be clear, you're talking about the 512-byte 'struct fxregs_state' which is the first member of 'struct xregs_state', right? Basically, any two-buffer model wastes 576 bytes of space (legacy fxsave plus xsave header) for each task that uses two buffers. This provides an overall space savings unless there are something like 16x more TMUL-using tasks than non-TMUL-using tasks. We could eliminate the 576 bytes of waste, but at the *performance* cost of having a permanently (non-task_struct-embedded) out-of-line XSAVE buffer for all tasks. > The AMX state is stored at the end of the XSAVE buffer (at least for now). > So, the layout (in terms of offsets of non-AMX states) won't be changed at > run-time. I don't know what point you are trying to make here.