Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp833054pxb; Tue, 3 Nov 2020 13:52:09 -0800 (PST) X-Google-Smtp-Source: ABdhPJy/tNOdqbdjy8BjUHR2OJjO6FGJ3SDBxxaIHqH+xYWr0aFJZy+1iNMkavYnIm1LMqVoZRIp X-Received: by 2002:a50:baea:: with SMTP id x97mr24036968ede.81.1604440329386; Tue, 03 Nov 2020 13:52:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604440329; cv=none; d=google.com; s=arc-20160816; b=LVfFyk3bf0M0cCrPzJ8/GyF2KF1apj9DYL2DscOZtKLKm6gLLX/Xq6RCSPZIaQ8Ev/ yyVOUaAXWmTYZb3yER2YntH/ze8/K0XxhIywM9BXkgnh27cJluJJYIicbQAXSPgaSDd4 Z3hoJtxEZrTYLHvj8eM1sN9Qhk7RHfUcfyPJXM9JGObDLIjiG+hJCMszzU2OxGFjiy9+ mJjnalGLeTSowTINsHPB1kVnXyNzR4Ac66Ga9cyWIq9Gwys4vqYZMSCXNJyI19Mh2zw2 PEQudsRimqdwL7iAR9P90+KwwpTupIrIMOANNGGYXpO1B3bcXuz9WrAVV82xjVoPxA6b c+2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=K/VsROkFNhyZHCcH1xhVdzD8oBlQC+gBRpEicxVdH64=; b=ut/spZDWFqW4hu5fMIqNrEf5q+5pZDQNQrsihS6iXtvd/Ij2jsiGabAFKTk3yNymYL DJ0zTtpY4udO1fC60uqtbhnaX+VQeHaDAPPtdclvIUj4i0sg7JO+bzNj0JMYRcLMwM+Y chyr+gHy69agtxWvOlc8L5mOG/C84m3uL7pwijhIUQoAaHsO6BTEf8eNoDBXAfpXhVdH JScz06xPKkzuI5gGMolfyBTPycTPzFLAyjXb4PsW5HRmQOxnGrxB0lQgZ4OMY7nZUw0s bHwSlQZYsDGp6AZXdQ/BxWxrLBpePGlaV5c4carL8HAOxZ5vYy8YpUf0c9wPYy0m5pv9 hReg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Gfjk14fr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r26si115671ejb.114.2020.11.03.13.51.46; Tue, 03 Nov 2020 13:52:09 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Gfjk14fr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731780AbgKCUuZ (ORCPT + 99 others); Tue, 3 Nov 2020 15:50:25 -0500 Received: from mail.kernel.org ([198.145.29.99]:44142 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731785AbgKCUuR (ORCPT ); Tue, 3 Nov 2020 15:50:17 -0500 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 72CB6223FD; Tue, 3 Nov 2020 20:50:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604436616; bh=DKj9l45qsUuR9nK//2BCsJXqTiHtXv+3qPOgpfQT+bk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Gfjk14frnUROHBS2TTBOdzh8ImOogNmJkjUcDFA64CDXdfWj3s/mI1hSPKIeUwH9K xxmz5CjPK3T94mp/eWkT29Qk7i8HEra0YdlTytaArYHCHXNyA2EjgZDyTycldQqEjh vh7fknkaD/hiGc2kyMpg1C/oZYbmEauPCgIFEk+g= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, "Matthew Wilcox (Oracle)" , Jeff Layton , Ilya Dryomov Subject: [PATCH 5.9 328/391] ceph: promote to unsigned long long before shifting Date: Tue, 3 Nov 2020 21:36:19 +0100 Message-Id: <20201103203409.256928657@linuxfoundation.org> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201103203348.153465465@linuxfoundation.org> References: <20201103203348.153465465@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Matthew Wilcox (Oracle) commit c403c3a2fbe24d4ed33e10cabad048583ebd4edf upstream. On 32-bit systems, this shift will overflow for files larger than 4GB. Cc: stable@vger.kernel.org Fixes: 61f68816211e ("ceph: check caps in filemap_fault and page_mkwrite") Signed-off-by: Matthew Wilcox (Oracle) Reviewed-by: Jeff Layton Signed-off-by: Ilya Dryomov Signed-off-by: Greg Kroah-Hartman --- fs/ceph/addr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/fs/ceph/addr.c +++ b/fs/ceph/addr.c @@ -1522,7 +1522,7 @@ static vm_fault_t ceph_filemap_fault(str struct ceph_inode_info *ci = ceph_inode(inode); struct ceph_file_info *fi = vma->vm_file->private_data; struct page *pinned_page = NULL; - loff_t off = vmf->pgoff << PAGE_SHIFT; + loff_t off = (loff_t)vmf->pgoff << PAGE_SHIFT; int want, got, err; sigset_t oldset; vm_fault_t ret = VM_FAULT_SIGBUS;