Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp833512pxb; Tue, 3 Nov 2020 13:53:06 -0800 (PST) X-Google-Smtp-Source: ABdhPJw9AuljJUEMYSzb3poRL0X20Y9f/4FsgA94DmT+iYwwVzvKxBfPct4JFZRhbuLOqiCDXXzM X-Received: by 2002:a05:6402:143a:: with SMTP id c26mr24508302edx.150.1604440386326; Tue, 03 Nov 2020 13:53:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604440386; cv=none; d=google.com; s=arc-20160816; b=XZlWdCNKDug34p8UxMJY5UDiAdzOMGOzTEWRQh9Bzia3CW1oUCm6oKwRkQH275u3yB Al7Fh3wJraBiuxNx3GzTvP2usMj3is/riOm2Osa1DN079Gtm0eZTlp1LmaU4wt3IBK+N 8Gxlv1NAZ1Li/WFgHyD4h/lGkXMCcP0hKjSr30oavG4TVGvcgbSv3T+gibIpknZdcAJE pcvCQ98ic9PzxAliKLAaOhxKTaNN4pOnl4SGkQ1mwTPPewI6qUrxber4h6lkfP+laDs6 /5zEOBfEXic5ykMc/g73VcMW99reqtmeNKyEhp+5m6C934MpUAjv6VpVvKaRQFmUB78e nxcQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=VL0igHFJS/IEGABvp1+F6oOpwpFH0peILn/LiK42lnA=; b=b85vg96SWQAessC0cF5bwAoH3s6Av2FlnY/qzjPFqddw0r5XVal8AiJI/tE6Q4I91J z/Mo2Usq6+yKn+lcAJbWxZ+42jzKTVxZWZ0JrNSPUgyjwo369IlvPC3m8L9zvUWuKkgq ncDoLprWQsaT0uvObqnnaH4e/DW/sfNyECXFhNiSPYkbuWIkrVhrd624/KtMSpjPulRa 27uuzR+ZzxGNumEZ+i/1S8VFeGWf4dLp0uJQAE2bhTWgcT026T5xPFXoNJ7w/Eolh3sx 7jpU0hSC9+tZUoZlQoxTq3NTwotDg9AbXwRA8pUh6lRzJxEZEGsCyYaRESl+bJz+p19b 8t4A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="b5Pm4/wd"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a18si8596748edb.306.2020.11.03.13.52.43; Tue, 03 Nov 2020 13:53:06 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="b5Pm4/wd"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731445AbgKCUtH (ORCPT + 99 others); Tue, 3 Nov 2020 15:49:07 -0500 Received: from mail.kernel.org ([198.145.29.99]:39196 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731479AbgKCUsF (ORCPT ); Tue, 3 Nov 2020 15:48:05 -0500 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5C38822404; Tue, 3 Nov 2020 20:48:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604436484; bh=Rl7KlvGNjgpipQ9OxJ/zByIUtYu+3qLpWUB+MrcImnw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=b5Pm4/wdA7YAyy29NdKAEfXJgtwIYp0UHqbH/oHSGGCnWQbaqV1feXnIVzfjisCXh NbSuQpN8w2dnQeOqj7rd7rhVEotKFSnQYQQpsGQ+d+AzjnXJlPtA+A4VMzGQ7qXFFB ndhi/vPcqvIlNt+1S3+B4WjanjHeGTuLq+UrsRd4= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Stable@vger.kernel.org, Andy Shevchenko , Jonathan Cameron Subject: [PATCH 5.9 271/391] iio:imu:st_lsm6dsx: check st_lsm6dsx_shub_read_output return Date: Tue, 3 Nov 2020 21:35:22 +0100 Message-Id: <20201103203405.316967620@linuxfoundation.org> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201103203348.153465465@linuxfoundation.org> References: <20201103203348.153465465@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Tom Rix commit f71e41e23e129640f620b65fc362a6da02580310 upstream. Potential error return is not checked. This can lead to use of undefined data. Detected by clang static analysis. st_lsm6dsx_shub.c:540:8: warning: Assigned value is garbage or undefined *val = (s16)le16_to_cpu(*((__le16 *)data)); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Fixes: c91c1c844ebd ("iio: imu: st_lsm6dsx: add i2c embedded controller support") Signed-off-by: Tom Rix Reviewed-by: Andy Shevchenko Link: https://lore.kernel.org/r/20200809175551.6794-1-trix@redhat.com Signed-off-by: Jonathan Cameron Signed-off-by: Greg Kroah-Hartman --- drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_shub.c | 2 ++ 1 file changed, 2 insertions(+) --- a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_shub.c +++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_shub.c @@ -313,6 +313,8 @@ st_lsm6dsx_shub_read(struct st_lsm6dsx_s err = st_lsm6dsx_shub_read_output(hw, data, len & ST_LS6DSX_READ_OP_MASK); + if (err < 0) + return err; st_lsm6dsx_shub_master_enable(sensor, false);