Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp833597pxb; Tue, 3 Nov 2020 13:53:15 -0800 (PST) X-Google-Smtp-Source: ABdhPJyF69mRWH3AKQdavqnc67H+8efBhFxof10hsvyF79wqEZn2Sd3Ppjuj/AArs9yJk5Is8fvG X-Received: by 2002:a17:906:7247:: with SMTP id n7mr21906987ejk.174.1604440395309; Tue, 03 Nov 2020 13:53:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604440395; cv=none; d=google.com; s=arc-20160816; b=C/zWS4xAIcHeRvgV2Sg7wjleNsbHW5aZLM8NBo6jEARaAyO4lzbjChGNuG2opePsEV 7BNxHl9iwaaF1HKxUMPaKT9R/mUAuUo22ExbREeEfy7tESEWpXB7mNEHHEBuY5got0Gj knA2GZSPwOMKfoY1LwOUbymS7oroHZNCSHDrq3vt/kxEpV05uxkq4hpQagQoRx/Yt0Ku VQV6Vgbn6/4UAVDkvCgz/4aITCT3gczb42GwESqtaoEBNYtE40Z+KGCcYy5OscqYxsId kmVgB0Tg8q9gkhyPV6IGgSZuBNhd45EPDZZlLLAgvvdRu1L01K/JWKCBRlrqNLLh49RK 54rQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=QZaQvVchPezWAQZjBb9k2ZihBZJ3yahTzDUyphLyOew=; b=Sf03LVJTyOgDpY/5eTYH7mheC6SReVyqtgFfeixSZbM61yR3PHic15xxdz7c0SooFF mVe8RU7nAA6V1rDy8EJa8XsJJqpzfWwRXRFw5dglbsNwsDdRcutm6TYB/yfIeYcsMrUU 48BiDmc3KbTCjbnSbJtOFTUCYFotudQP2pSEth6iu+MtM/tolimWWF4qJl5xOFw/jgVV trv8vCgzUyVXjPcdexHotldVAE1Ztlwl0Dzlbdma/w8FK40HiayqKZ5pbktXIcg9bMmh rZH+j9SgStH3htiMNYZFscjBm/KpjusZl0j05HOJDHhFpPORsj+oTAlub6FO/1W3f8P2 f4KQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=POrNWb9e; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bm7si83031ejb.166.2020.11.03.13.52.52; Tue, 03 Nov 2020 13:53:15 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=POrNWb9e; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732254AbgKCVsX (ORCPT + 99 others); Tue, 3 Nov 2020 16:48:23 -0500 Received: from mail.kernel.org ([198.145.29.99]:44284 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731287AbgKCUuV (ORCPT ); Tue, 3 Nov 2020 15:50:21 -0500 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EFEFE20719; Tue, 3 Nov 2020 20:50:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604436621; bh=OMTqSajG1lCHhZJ0KW8Cav0eH77NUzurjbVwVAwb5rk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=POrNWb9eOXbe/K8BhyGGp61dP/wtba2XhVbMN2dPV8w5DnB/GVfJL5ffwik3C/pnl dgpzAU+EUFoGBO3NXCZuvLNHmv9xb6h8di+UpK/8LkDg2CAKURwbh8pEtydGRABqRo Sy7livNEqryqScUkaU+AZR1FBLlEyk+oTbuI+5xE= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, "Matthew Wilcox (Oracle)" , Dominique Martinet Subject: [PATCH 5.9 330/391] 9P: Cast to loff_t before multiplying Date: Tue, 3 Nov 2020 21:36:21 +0100 Message-Id: <20201103203409.390559336@linuxfoundation.org> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201103203348.153465465@linuxfoundation.org> References: <20201103203348.153465465@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Matthew Wilcox (Oracle) commit f5f7ab168b9a60e12a4b8f2bb6fcc91321dc23c1 upstream. On 32-bit systems, this multiplication will overflow for files larger than 4GB. Link: http://lkml.kernel.org/r/20201004180428.14494-2-willy@infradead.org Cc: stable@vger.kernel.org Fixes: fb89b45cdfdc ("9P: introduction of a new cache=mmap model.") Signed-off-by: Matthew Wilcox (Oracle) Signed-off-by: Dominique Martinet Signed-off-by: Greg Kroah-Hartman --- fs/9p/vfs_file.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/fs/9p/vfs_file.c +++ b/fs/9p/vfs_file.c @@ -612,9 +612,9 @@ static void v9fs_mmap_vm_close(struct vm struct writeback_control wbc = { .nr_to_write = LONG_MAX, .sync_mode = WB_SYNC_ALL, - .range_start = vma->vm_pgoff * PAGE_SIZE, + .range_start = (loff_t)vma->vm_pgoff * PAGE_SIZE, /* absolute end, byte at end included */ - .range_end = vma->vm_pgoff * PAGE_SIZE + + .range_end = (loff_t)vma->vm_pgoff * PAGE_SIZE + (vma->vm_end - vma->vm_start - 1), };