Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp833763pxb; Tue, 3 Nov 2020 13:53:33 -0800 (PST) X-Google-Smtp-Source: ABdhPJyYuYxgUQTeHFMreKFfdPikelmG8Kbq6LQ63tKwEh639eslQY7Ux+nX8ER9+meFUXOOUFYN X-Received: by 2002:a17:906:11d6:: with SMTP id o22mr22916718eja.171.1604440413317; Tue, 03 Nov 2020 13:53:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604440413; cv=none; d=google.com; s=arc-20160816; b=bImR+bRsieyaE8oOEKYVbhthA9qyAu+w5KrZO5AW5A5/Akg8r62LWMZCJAj9Rnxucp qE/RdStnVAf4cB+/48f8Xlmyp1OQ43vmcGgEr8mHa1UgVHKrhhoAhMEDBYAFtgEJlILU SUHed0zQHaY8cDd5u1Mi9WoLVpZuASMcp8daABmVxdpF/b6Lp5q8cehQ3Fp84fTbb3a8 x6Do0B3kLGaS/JRfqm/QSGNE8lJ1tqp6rVs99kx05ibBS/yaHeDSv9Zt4LBQcOIEFFzz xxhjai9/l9Lzy2RZKoUGc8dNgUtRAp769KIoPXzF7xddesb2R+cwYon38LRViiX9VMeC cWPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=PCaAY+ZJKAubI/dTp9dVmvP9qz03RO0BsTIwB/Qn96s=; b=W0Nb+wvWzspgl3HKqIn7WLjXB6qjwOEJBulJEPMua54adHsDRCsQRY6ihlnzA/gu2o SWBHw16xeXRe9Gs5JXaXoo9U10nAVXgkv/dRLcYptMo5sQWTZr6s1mdva2DpAV5q7gIg ptB6kN23PYNjlU9km+X72XRvgx7QesQhjXX5WfMDMZ16WSmXtbRQygdR0lNI/f2x7P+t pW/xAvNFzjFIAuo8aalHChH8+mPjNAyzA1nLyXtGA5/F/qRwWwKvNxu4kxXU2hgS1MI6 Hs9i+tv5i5ja6J13Gsl/vemWQOfHZvHz60VI6qhc0Zc/EuPa3AaX2uXf/XozMeluQ4tj OBKA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=LgOnKe33; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w17si58990eji.277.2020.11.03.13.53.10; Tue, 03 Nov 2020 13:53:33 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=LgOnKe33; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731755AbgKCVsn (ORCPT + 99 others); Tue, 3 Nov 2020 16:48:43 -0500 Received: from mail.kernel.org ([198.145.29.99]:43690 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731732AbgKCUt7 (ORCPT ); Tue, 3 Nov 2020 15:49:59 -0500 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 46A2F22404; Tue, 3 Nov 2020 20:49:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604436598; bh=10E+evXaSoanrGML/WlMAmxK4soRQKnBX3Wuv12W+X8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LgOnKe33AIVTv7mdjjtBr3dL5PLGzgGGni+rCKs7m/w9ksTXU+IayhkWoqdLjX8cC rJ8fzhi0NSvlLpxgISqgClZmSmZB25bK1eGr8VeQS/QDdqY9zy2lBZrfszXTyzlOaZ wslDYjVXSkwtSc/IkliX1aofqo+KFvu7s8gmc7Cw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Zhihao Cheng , Richard Weinberger Subject: [PATCH 5.9 303/391] ubifs: dent: Fix some potential memory leaks while iterating entries Date: Tue, 3 Nov 2020 21:35:54 +0100 Message-Id: <20201103203407.549317349@linuxfoundation.org> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201103203348.153465465@linuxfoundation.org> References: <20201103203348.153465465@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Zhihao Cheng commit 58f6e78a65f1fcbf732f60a7478ccc99873ff3ba upstream. Fix some potential memory leaks in error handling branches while iterating dent entries. For example, function dbg_check_dir() forgets to free pdent if it exists. Signed-off-by: Zhihao Cheng Cc: Fixes: 1e51764a3c2ac05a2 ("UBIFS: add new flash file system") Signed-off-by: Richard Weinberger Signed-off-by: Greg Kroah-Hartman --- fs/ubifs/debug.c | 1 + 1 file changed, 1 insertion(+) --- a/fs/ubifs/debug.c +++ b/fs/ubifs/debug.c @@ -1123,6 +1123,7 @@ int dbg_check_dir(struct ubifs_info *c, err = PTR_ERR(dent); if (err == -ENOENT) break; + kfree(pdent); return err; }