Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp843285pxb; Tue, 3 Nov 2020 14:10:04 -0800 (PST) X-Google-Smtp-Source: ABdhPJxRqmOnt6ac8uqMjk69uIDfdQ582V0kNs2MmNxhZekNc1Gv+0qcdnA9MOYya7/aE936yR0+ X-Received: by 2002:aa7:dc12:: with SMTP id b18mr23929015edu.295.1604441403766; Tue, 03 Nov 2020 14:10:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604441403; cv=none; d=google.com; s=arc-20160816; b=QDmVK6SNt1bYM3jqNRzd8uw+WuF4S3uRjvHCGJyjqLDAaQLx5VKz+MM8dSRwosQD0K 4xh3jN6C4Mu8EXIOFU95AeqSAvFhdM8twE5tlC23gqsWVb4mCAdY9JZs2eobX4jtW1zm pYDnMKpTxHHb7OfUK/NZvJSeQafzwpYUq634b6bfkf82LTDK4FZGf1S9gmjc1uxT3Xwk tFdz+ql18rMVzhwGyvb1wSHgyz2cjYzno3E48XkiWWa3AX8TAMKflObhcYR0XWq6/uHX kPvA0pgC7EjcRSzKu3eR6fRJSPuullZ9fUd/mdS1Nv15EzTbGjJzIt4lCRE1yK0SnbDT 4o/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dmarc-filter:sender:dkim-signature; bh=4BBm67fUFoo0KkqTgZeFbV6Hq2N7kpn5Ax07w3zlOJs=; b=Ty5rSKTKceWM0suju1JgGo6P3XpPK0FbahqQUvVNBgPJyK0XcC1VoS+x4RryZjM9Ge O7rp3ZEE+VdOSq293XZnLVEb5Tm6L4VK8fngj4xMMDj3JJ0Ok62hliz+xQwk68vzN1km 1p3mR07wJOtyQz4Jq7gKNDPJDZxi1lYM8gG7T4NrSU2JlKHsgNLVC5UBS5oC6HGocx+/ EAJae44kcxein3AT/4FlGm9DzqedIPrksk3EnkxG1g78vklXPnlyBPz0MVCMRz0bzJBB PhSrxAVQRmXwx8hOC0cO85asX1tRC+ufwi0vR4oc/VWY7l+Mkt0AKr/DADvURECYGLIV nubg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=eC4VOCkb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c8si6744503edr.540.2020.11.03.14.09.40; Tue, 03 Nov 2020 14:10:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=eC4VOCkb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730960AbgKCWFb (ORCPT + 99 others); Tue, 3 Nov 2020 17:05:31 -0500 Received: from z5.mailgun.us ([104.130.96.5]:13018 "EHLO z5.mailgun.us" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730549AbgKCWF2 (ORCPT ); Tue, 3 Nov 2020 17:05:28 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1604441127; h=Content-Transfer-Encoding: Content-Type: In-Reply-To: MIME-Version: Date: Message-ID: From: References: Cc: To: Subject: Sender; bh=4BBm67fUFoo0KkqTgZeFbV6Hq2N7kpn5Ax07w3zlOJs=; b=eC4VOCkbG4zJE3VPgL64A1iqjCasQ2Z/5Q4hrfmJlW9VBVTC4NhdOj3ANWx1j56pyt94uOk/ /b+UmDfqYMWyT7KVgfsAhW0ESp+m1xHJTdxXCEPBpkW+M7nR+JRkESCGbfeKeOSM+28bGONN jbyV7baRM/uwIrZvnm3Rj17DFm8= X-Mailgun-Sending-Ip: 104.130.96.5 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n02.prod.us-west-2.postgun.com with SMTP id 5fa1d4250ce128468bf6dc23 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Tue, 03 Nov 2020 22:05:25 GMT Sender: hemantk=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 173F7C4339C; Tue, 3 Nov 2020 22:05:25 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=ALL_TRUSTED,BAYES_00, NICE_REPLY_A,SPF_FAIL,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from [10.46.162.249] (i-global254.qualcomm.com [199.106.103.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: hemantk) by smtp.codeaurora.org (Postfix) with ESMTPSA id BDF12C433C6; Tue, 3 Nov 2020 22:05:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org BDF12C433C6 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=hemantk@codeaurora.org Subject: Re: [PATCH v2] bus: mhi: core: Fix null pointer access when parsing MHI configuration To: carl.yin@quectel.com, manivannan.sadhasivam@linaro.org, sfr@canb.auug.org.au Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, naveen.kumar@quectel.com References: <20201102122710.23406-1-carl.yin@quectel.com> From: Hemant Kumar Message-ID: Date: Tue, 3 Nov 2020 14:05:22 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201102122710.23406-1-carl.yin@quectel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/2/20 4:27 AM, carl.yin@quectel.com wrote: > From: "carl.yin" > > Functions parse_ev_cfg() and parse_ch_cfg() access mhi_cntrl->mhi_dev > before it is set in function mhi_register_controller(), > use cntrl_dev instead of mhi_dev. > > Fixes: 0cbf260820fa ("bus: mhi: core: Add support for registering MHI controllers") > Signed-off-by: carl.yin > Reviewed-by: Bhaumik Bhatt Reviewed-by: Hemant Kumar -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project