Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp875228pxb; Tue, 3 Nov 2020 15:11:40 -0800 (PST) X-Google-Smtp-Source: ABdhPJxpENh8YI4mvtHo/RJC2txsGcAWxJVxXBcvGU3Hi1Sw4/pnTSISX0mHvCN4IE2RwZyE7Vfr X-Received: by 2002:a17:906:77cc:: with SMTP id m12mr3310988ejn.139.1604445099999; Tue, 03 Nov 2020 15:11:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604445099; cv=none; d=google.com; s=arc-20160816; b=t+XDhIj14qc6vFA/5f0p2jeWM5k9FHUNIgX+ugQI7ejePMiq9Rycuc0FV+8luSC3Qg tgRVGL8ugi1pUSe+Z2aNry9kS4EA2Cq425Xv5dJexxc6PkPLEw8Te7lFtIZJgVyTSMJX DIeyDRbrUDMY+hl/FkIZdzx/2KJClJIOe4FZ20/tVJtuARV7684EpusnXFHhq289ko3Y IRN8Rc0W90FexFfASzJ/DVyvE2yJ2NhzQy1jCdIuHMm1GHn714VJG9fDdMXaYCacG6gk LhejsTLkfPYUeF3Nhvn6Lq4+UZvSyqSnK+clzc71APZQNh+/Q1Z01/wiaG7/1LLCLO1s ryBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=rpAavG97nfZ3DMc8zlbaKSDRIzvncgO3IQEQwcT8ut4=; b=akXqWIzjxpGX7VFOwhZqWRauZ4TGsMzN4kBEQ4+I6Wq2mAMndumakRF9ChIpSw1g7n 0zfhl8pHa0mqhCtYMyeZ+dOUL6zCTCNN5DCk0gt1PpJaRup4ikwD1mIZnMDBitiWSgw5 O6xuIT9y6TlxhK3FKJ9lTWDvUGrmxGF7vwDeudEECYiewWM6XIWz0IVQ6V16KxIpEEaA m3IcXC2quqkCtFofV+ujkuoEOVVumxxH2UCBFqiDc2tIikGEOHsvTQU7Z5MtqTOaa31P lbEhuPtnoGeZMD8p7UZFglRSZfgWEyTaZmj0k6DuIwywyaFq/pRnfDne4cRwlxFy+BSj 1uFQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=fbDY0Obg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w19si77277edi.177.2020.11.03.15.11.16; Tue, 03 Nov 2020 15:11:39 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=fbDY0Obg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729933AbgKCUlU (ORCPT + 99 others); Tue, 3 Nov 2020 15:41:20 -0500 Received: from mail.kernel.org ([198.145.29.99]:52880 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730323AbgKCUlL (ORCPT ); Tue, 3 Nov 2020 15:41:11 -0500 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 807052236F; Tue, 3 Nov 2020 20:41:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604436071; bh=Jxdjxaiw5yyUpd4PQEW9YWR9yqBD1g8R1TWTG+rUFSI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fbDY0ObgRsOScw2DzjQZzb7psuDs9xWuL/hq6Ns4Tk4gq/EjRNFsZKe3YK5IRsZ+T PJN/uYbbUXa076kaQeH8l9H8GAf9nWeGInxNi82+0Ko7eq7dcpkhY8KPy3GFH+Yc// EdgNPLr5ZAKTNN8wqcrQvOOYoO0tiR9w2kW9HZL8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Tom Rix , Hans Verkuil , Mauro Carvalho Chehab , Sasha Levin Subject: [PATCH 5.9 089/391] media: tw5864: check status of tw5864_frameinterval_get Date: Tue, 3 Nov 2020 21:32:20 +0100 Message-Id: <20201103203352.985795758@linuxfoundation.org> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201103203348.153465465@linuxfoundation.org> References: <20201103203348.153465465@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Tom Rix [ Upstream commit 780d815dcc9b34d93ae69385a8465c38d423ff0f ] clang static analysis reports this problem tw5864-video.c:773:32: warning: The left expression of the compound assignment is an uninitialized value. The computed value will also be garbage fintv->stepwise.max.numerator *= std_max_fps; ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ stepwise.max is set with frameinterval, which comes from ret = tw5864_frameinterval_get(input, &frameinterval); fintv->stepwise.step = frameinterval; fintv->stepwise.min = frameinterval; fintv->stepwise.max = frameinterval; fintv->stepwise.max.numerator *= std_max_fps; When tw5864_frameinterval_get() fails, frameinterval is not set. So check the status and fix another similar problem. Signed-off-by: Tom Rix Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/pci/tw5864/tw5864-video.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/media/pci/tw5864/tw5864-video.c b/drivers/media/pci/tw5864/tw5864-video.c index ec1e06da7e4fb..a65114e7ca346 100644 --- a/drivers/media/pci/tw5864/tw5864-video.c +++ b/drivers/media/pci/tw5864/tw5864-video.c @@ -767,6 +767,9 @@ static int tw5864_enum_frameintervals(struct file *file, void *priv, fintv->type = V4L2_FRMIVAL_TYPE_STEPWISE; ret = tw5864_frameinterval_get(input, &frameinterval); + if (ret) + return ret; + fintv->stepwise.step = frameinterval; fintv->stepwise.min = frameinterval; fintv->stepwise.max = frameinterval; @@ -785,6 +788,9 @@ static int tw5864_g_parm(struct file *file, void *priv, cp->capability = V4L2_CAP_TIMEPERFRAME; ret = tw5864_frameinterval_get(input, &cp->timeperframe); + if (ret) + return ret; + cp->timeperframe.numerator *= input->frame_interval; cp->capturemode = 0; cp->readbuffers = 2; -- 2.27.0