Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp881907pxb; Tue, 3 Nov 2020 15:25:17 -0800 (PST) X-Google-Smtp-Source: ABdhPJzhUU68VjAiSEcmJAJ+FzfqUwdBEAeELpqoya5HVsIf+swLzYXQs4IYSYkHC+NfnW5qPwJg X-Received: by 2002:a50:a441:: with SMTP id v1mr23860933edb.30.1604445917252; Tue, 03 Nov 2020 15:25:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604445917; cv=none; d=google.com; s=arc-20160816; b=Q20jl1uZ1bDgffnImTIbAKPSM7u4cPz9tEQ9Y3tEhefcQ2cZTSwLYIGY14DwSSykwY XPzvAKfT58whQ//0bb0ehbCwBiC43AIa4c1iDTjzcoPz3bWa8lVPAA/RdG1StXEewJ5W aPE/rxEALyLlrRPKVtnMze5Y9zB4evzz/xk6Te2DEbSeMOwGR0THPifJ9Jfp0L7txeV4 6FkOQ2d1cfJbQMWonwrQ6mIOWuwKVf5g6LF53viy07gKdQpEh1/2b1Hio4CejJYUIo3H ad+8SX2+uLbEYgCK48OhC3xuFG1iv1EIma8rHL4brbU+KIeQ1azE8cqGe4DmQpv5H+6o oMBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=8xP3tPWvFXc7ncqEyjwyGLTU3KTNajdc1VEnuKQL3pE=; b=Bn67hY1Z7jobEHpsjef2npdoPl9lNNtRUuEimVEuZp/UEfAfV5QX3lIeRjc907rnsG MDMp/JzpoPubq2w2LOjZ/Q1DUQ/ZZ7qlnRaM9WUdCeh1qu4IFrvv0mprM7/hi2yl0Fds QI6XUFX46ev7QwXUAlqKkN2SEh6wArkxti+K91UTz5LcCjCkuEh5EmHOzCwnxdbr76/y c0LPve4rb+mO6t1LB2+TYcDdeqIfitfs8601v59fP/f7NUy8NZUiQPE8iOB8aeLs0H7H 67PeewD01OHIeydLtcCSHzUhDgKulNjazDh0mjoWURy7xvrfPsfptzOHJGS4gPh7Z080 SOxg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=ECfbxvEa; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d20si93729edr.435.2020.11.03.15.24.54; Tue, 03 Nov 2020 15:25:17 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=ECfbxvEa; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388022AbgKCVEq (ORCPT + 99 others); Tue, 3 Nov 2020 16:04:46 -0500 Received: from mail.kernel.org ([198.145.29.99]:42914 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387666AbgKCVEo (ORCPT ); Tue, 3 Nov 2020 16:04:44 -0500 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7578120658; Tue, 3 Nov 2020 21:04:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604437483; bh=8Ps6fibaEDvruRC1CSgKQZmovHRxfu5kwG0uq6P269M=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ECfbxvEaDDUqKBHnSAFOLpgb9VKmM8pViNMb44NOqnw4+NIWKAlBk3nRDB0ztdOtL iVgnS2Mp2K9rCA5YPK+Vn1so0/jn5me1ko8N1f1x1jL0yeoD10CFrhGEq5LGQnSeZL OBADihK02zoMrFn4rQy2ItJ2N7T059xhUEeV6nQA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dan Murphy , Tero Kristo , Stephen Boyd , Sasha Levin Subject: [PATCH 4.19 097/191] clk: ti: clockdomain: fix static checker warning Date: Tue, 3 Nov 2020 21:36:29 +0100 Message-Id: <20201103203242.893314467@linuxfoundation.org> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201103203232.656475008@linuxfoundation.org> References: <20201103203232.656475008@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Tero Kristo [ Upstream commit b7a7943fe291b983b104bcbd2f16e8e896f56590 ] Fix a memory leak induced by not calling clk_put after doing of_clk_get. Reported-by: Dan Murphy Signed-off-by: Tero Kristo Link: https://lore.kernel.org/r/20200907082600.454-3-t-kristo@ti.com Signed-off-by: Stephen Boyd Signed-off-by: Sasha Levin --- drivers/clk/ti/clockdomain.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/clk/ti/clockdomain.c b/drivers/clk/ti/clockdomain.c index 07a805125e98c..11d92311e162f 100644 --- a/drivers/clk/ti/clockdomain.c +++ b/drivers/clk/ti/clockdomain.c @@ -146,10 +146,12 @@ static void __init of_ti_clockdomain_setup(struct device_node *node) if (clk_hw_get_flags(clk_hw) & CLK_IS_BASIC) { pr_warn("can't setup clkdm for basic clk %s\n", __clk_get_name(clk)); + clk_put(clk); continue; } to_clk_hw_omap(clk_hw)->clkdm_name = clkdm_name; omap2_init_clk_clkdm(clk_hw); + clk_put(clk); } } -- 2.27.0