Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp920619pxb; Tue, 3 Nov 2020 16:44:17 -0800 (PST) X-Google-Smtp-Source: ABdhPJxvIPRo/Myjd1Ddi2h3SjlzpqQPl/h442R9d/yfewsYjqldq1LmBizDViUerYgtH/ykdhE2 X-Received: by 2002:aa7:d591:: with SMTP id r17mr3857717edq.274.1604450656930; Tue, 03 Nov 2020 16:44:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604450656; cv=none; d=google.com; s=arc-20160816; b=FAwWBBz0MHlO4emcr8JHvIQiw/QuN6fa2cz65V0cgFC2dfQYJq76jXkXgWZqCuaFt1 FOdaTCWPY1J/dM3MO62uA/FSJjckv2H1A4gTWh1rGhxV5Bmz0/B3dwxpMvQ1rrM6bcPb RYwJnt7jeGGQOec7lMnwjTjvSnoCCraRKEpe22saXWbfBe26fY2hus7QExI9wHrxSVxW vmbDzDzLS6vPzj//wnOkwqia9jYc4qtd7kYZUuOjxdrYRq5nok5VyTA5U5z4eXRXFdAY +BaL+VZy3xmjEfHCTrov1HYElFcB9yRk63F5o1rSHp44R/2MERpFx1jup74ieL3jz0qt l6fQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=fHY3vdUl02HFmgjopDfIPsTDOudo77Qk3qlLxz6Bz8c=; b=V3+wiV/944H6u8zza2+iUeXmJ8dClR9yCNIuqBfyOCJIA10KS9wFw4XAYplEmQIZym DgNsfNUetZphqX3Moogjtp0XgQKEdElONdzmlrxpWf39fkhlW1ZpoDTr5EziQll/fwhu ThY3kH6DBNTfUGIVXAiyOvw69Rq+uHVhqamspnzjdG5vFxGJd5p69QIzCSQESvv254qW cWqn5iFIg055QXYG9MieGcRQ9gxRBDid5NsT6/awI2gtRtSCVxB7QXZ2+oEe3PNzStJo Xajq0SDyDd6h6vZA+Q1FY97FdH1SZqiwXbQ2UKeSpOT8N0/6LNqKOMPM97fa+KfvCXTp KNAw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=adOBIz9T; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d17si200811edz.488.2020.11.03.16.43.53; Tue, 03 Nov 2020 16:44:16 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=adOBIz9T; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730016AbgKDAkT (ORCPT + 99 others); Tue, 3 Nov 2020 19:40:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58078 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725811AbgKDAkT (ORCPT ); Tue, 3 Nov 2020 19:40:19 -0500 Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [IPv6:2a00:1450:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 80285C061A4B; Tue, 3 Nov 2020 16:40:18 -0800 (PST) Received: by mail-ej1-x629.google.com with SMTP id w13so13668454eju.13; Tue, 03 Nov 2020 16:40:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=fHY3vdUl02HFmgjopDfIPsTDOudo77Qk3qlLxz6Bz8c=; b=adOBIz9TTQqWZdrrtyI1SwaaykgICxV5FQoeQVZdDbsYNuvV7vwQuQH0GnFHT7VKCu vQcmutbiuNROmncLnWSrVUJMYCj0NPpbsBAn3b3ZmkD+4AFRxiOVBDy3XSFA7rlo4sGo nklMZZN3pZHfp4bL9sMJ1BQ8ER6ie7DGKrahRZvKE9EtIvWvgM7BuivFOFnPIwwqYol5 J6AEtejIVUqMJGJ6q482pnJ/zwuPwFxHxgVqkGaZHfgZ5TA5JFqeQ3QMfgiz/rC8nEqe +IPNjaqhM7oODcNxVuvq133as8+8Y+5qYfBuDUSwI/U/vQeQJD9VqPMCdvcDU1/FmH6k IDTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=fHY3vdUl02HFmgjopDfIPsTDOudo77Qk3qlLxz6Bz8c=; b=c2gnOA0Ulj4Lh4TFXioQ8eRO8fY6AGUhWcxaxv4M+kOeiIKBqFx5+a7lZy4wFWgMuW aNbwwNCTVr4C/+Xt9Ht6s00zaCmHFpvjK1tqEa4LpiA9P2zyDB67AX+yxHHjL1ZowYQV TAI2zyIvoQIqFW4tlM2kKr5sx/vTCJ2Wsri0XE4yo79F7EFs0KNKPyxFiD+rNTUbtIac /ZgjrM5Skchcad86puzJGC54uQQab3XU4PtBIFtIst6qnjzAQAi04yEL2XGQSci8y7yh qLG1KqJf0y/P82wI3QQ2RS8IXujbJ59Oo6ocgMBcGonUw2O4IEcmjjYkF2sAHlz/qgQY FvNg== X-Gm-Message-State: AOAM531/YBtc07E1zL2t+gNP33N5Su9owVBAYd2ZZTFopaRzrXEu4W1T LYS3yitzZqm0RKCRGmPf6LA= X-Received: by 2002:a17:906:16ca:: with SMTP id t10mr23774729ejd.24.1604450417272; Tue, 03 Nov 2020 16:40:17 -0800 (PST) Received: from skbuf ([188.25.2.177]) by smtp.gmail.com with ESMTPSA id mj17sm122652ejb.59.2020.11.03.16.40.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Nov 2020 16:40:16 -0800 (PST) Date: Wed, 4 Nov 2020 02:40:15 +0200 From: Vladimir Oltean To: Qiang Zhao Cc: broonie@kernel.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [Patch v2] spi: fsl-dspi: fix wrong pointer in suspend/resume Message-ID: <20201104004015.k7mggfzm4rhfamkz@skbuf> References: <20201103020546.1822-1-qiang.zhao@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201103020546.1822-1-qiang.zhao@nxp.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 03, 2020 at 10:05:46AM +0800, Qiang Zhao wrote: > From: Zhao Qiang > > Since commit 530b5affc675 ("spi: fsl-dspi: fix use-after-free in > remove path"), this driver causes a "NULL pointer dereference" > in dspi_suspend/resume. > This is because since this commit, the drivers private data point to > "dspi" instead of "ctlr", the codes in suspend and resume func were > not modified correspondly. > > Fixes: 530b5affc675 ("spi: fsl-dspi: fix use-after-free in remove path") > Signed-off-by: Zhao Qiang > --- Reviewed-by: Vladimir Oltean