Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp950269pxb; Tue, 3 Nov 2020 17:42:28 -0800 (PST) X-Google-Smtp-Source: ABdhPJz6dJPbcs2AYj8Nto42jcalp3kxDjHaZqhliAKDuDKC52DaQCsf7KCcfyLUJ1JPsyuRCN02 X-Received: by 2002:a05:6402:17ac:: with SMTP id j12mr24235511edy.31.1604454147938; Tue, 03 Nov 2020 17:42:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604454147; cv=none; d=google.com; s=arc-20160816; b=ZmSLr5QNJ/+FrsLHR+OwEk+7L8cOV32yz00fm/HrdJgCz3SJVUJnG9E7cQvTsIrBHA S9ix+gd4OHLUjWHFuWOKgPxPOVjdYtx3kluU/Dssbf1TeRD7dq77ouZ471rK0bxQ1wAO JMr2u8LrB7NdOZ6CeGE+2GNkpAbMIs/3IwBbv57uRA333VWpM9W+nRekoeHD5NpseuU4 H1a3kLWsjZlgBHuwyRtf1NkqqWUHsFe+VLOj585qq3tA5CExQUMBdceUJjnfQoObtWVb w2BFv0bE/5lqZK1Oh4GVT1lNgePsbPGJZW0Fo18aEVwZv9RtHeLyPUqcHkHa2uCbBZzz fG2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :content-language:accept-language:in-reply-to:references:message-id :date:thread-index:thread-topic:subject:cc:to:from:authenticated-by; bh=pnmi3f7NI2rmcxSqSkYbaxJFAniGwMw18lHFiJDC7LM=; b=uZZykqp/wVzzaUw7dxbPsFdA8m1di9xq5QHq14NXvf74aPhs9eLzA4d8rvbC1uUQ+Q CdVHZB7xYyxcRwFhuTMkToTUnQ8i7YUrPs8Y/Q2KzXI+bNYWEap61jDVGjom7i++Xj7X 9KXWVjD9fVrvlGoxnG43HesoIetm+MtS5fT76ecHileNc6t1qr4xHgE9jUh/EY37vdcb DKbmPIgmVnNS3b3uV82n6X9zbgn9kQhIC9qWC1/ZvKVRoV/szkW8NqPM17jDE/xOAksu tR8KuEwjskEZytiTmBLfUdYep77lHS+bvz1hDEdCKnz1+FCMZWRTJA8zOtege/yLK1dQ SLQw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z12si318429edk.11.2020.11.03.17.42.05; Tue, 03 Nov 2020 17:42:27 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730482AbgKDBkJ convert rfc822-to-8bit (ORCPT + 99 others); Tue, 3 Nov 2020 20:40:09 -0500 Received: from rtits2.realtek.com ([211.75.126.72]:53261 "EHLO rtits2.realtek.com.tw" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728567AbgKDBkJ (ORCPT ); Tue, 3 Nov 2020 20:40:09 -0500 Authenticated-By: X-SpamFilter-By: ArmorX SpamTrap 5.73 with qID 0A41dqJW3023388, This message is accepted by code: ctloc85258 Received: from mail.realtek.com (rtexmb03.realtek.com.tw[172.21.6.96]) by rtits2.realtek.com.tw (8.15.2/2.70/5.88) with ESMTPS id 0A41dqJW3023388 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT); Wed, 4 Nov 2020 09:39:52 +0800 Received: from RTEXMBS03.realtek.com.tw (172.21.6.34) by RTEXMB03.realtek.com.tw (172.21.6.96) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2044.4; Wed, 4 Nov 2020 09:39:52 +0800 Received: from RTEXMB04.realtek.com.tw (172.21.6.97) by RTEXMBS03.realtek.com.tw (172.21.6.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Wed, 4 Nov 2020 09:39:52 +0800 Received: from RTEXMB04.realtek.com.tw ([fe80::89f7:e6c3:b043:15fa]) by RTEXMB04.realtek.com.tw ([fe80::89f7:e6c3:b043:15fa%3]) with mapi id 15.01.2044.006; Wed, 4 Nov 2020 09:39:52 +0800 From: Hayes Wang To: Jakub Kicinski , Greg Kroah-Hartman CC: "netdev@vger.kernel.org" , nic_swsd , "linux-kernel@vger.kernel.org" , "linux-usb@vger.kernel.org" , Oliver Neukum Subject: RE: [PATCH net-next v2] net/usb/r8153_ecm: support ECM mode for RTL8153 Thread-Topic: [PATCH net-next v2] net/usb/r8153_ecm: support ECM mode for RTL8153 Thread-Index: AQHWrmwDnKDexsPDxUiMgOTBbfR/C6mx0pMAgAJFC4CAAKdeAIAA5pyAgABwkoCAASNjcA== Date: Wed, 4 Nov 2020 01:39:52 +0000 Message-ID: References: <1394712342-15778-387-Taiwan-albertk@realtek.com> <1394712342-15778-388-Taiwan-albertk@realtek.com> <20201031160838.39586608@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> <20201102114718.0118cc12@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> <20201103093241.GA79239@kroah.com> <20201103081535.7e92a495@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> In-Reply-To: <20201103081535.7e92a495@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> Accept-Language: zh-TW, en-US Content-Language: zh-TW X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.21.177.146] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jakub Kicinski > Sent: Wednesday, November 4, 2020 12:16 AM [...] > > So no, please do not create such a common file, it is not needed or a > > good idea. > > I wouldn't go that far, PCI subsystem just doesn't want everyone to add > IDs to the shared file unless there is a reason. > > * Do not add new entries to this file unless the definitions > * are shared between multiple drivers. > > Which seems quite reasonable. But it is most certainly your call :) Do I have to resend this patch? Best Regards, Hayes