Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030376AbWHQXen (ORCPT ); Thu, 17 Aug 2006 19:34:43 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1030380AbWHQXen (ORCPT ); Thu, 17 Aug 2006 19:34:43 -0400 Received: from e33.co.us.ibm.com ([32.97.110.151]:45704 "EHLO e33.co.us.ibm.com") by vger.kernel.org with ESMTP id S1030376AbWHQXem (ORCPT ); Thu, 17 Aug 2006 19:34:42 -0400 From: Arnd Bergmann Organization: IBM Deutschland Entwicklung GmbH To: linuxppc-dev@ozlabs.org Subject: Re: [PATCH 13/13] IB/ehca: makefiles/kconfig Date: Fri, 18 Aug 2006 01:34:37 +0200 User-Agent: KMail/1.9.1 Cc: Roland Dreier , openib-general@openib.org, linux-kernel@vger.kernel.org, RAISCH@de.ibm.com, HNGUYEN@de.ibm.com, MEDER@de.ibm.com References: <20068171311.WDFBWw0F6z9B3Qes@cisco.com> In-Reply-To: <20068171311.WDFBWw0F6z9B3Qes@cisco.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200608180134.39050.arnd.bergmann@de.ibm.com> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 539 Lines: 16 On Thursday 17 August 2006 22:11, Roland Dreier wrote: > + > +CFLAGS += -DEHCA_USE_HCALL -DEHCA_USE_HCALL_KERNEL This seems really pointless, since you're always defining these macros to the same value. Just drop the CFLAGS and remove the code that depends on them being different. Arnd <>< - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/