Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp1175166pxb; Wed, 4 Nov 2020 01:52:24 -0800 (PST) X-Google-Smtp-Source: ABdhPJzgJg2wCsHOf4LgZcYLhIheq63GQWoefA01GFtSsb3+ogDGAj8h18rXvvrHPUHMoKwvhQQP X-Received: by 2002:a05:6402:4cb:: with SMTP id n11mr25881537edw.296.1604483543840; Wed, 04 Nov 2020 01:52:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604483543; cv=none; d=google.com; s=arc-20160816; b=jXqaY1YF4sMoD8ExURH2ZxKG+/HdfpoUxkKX4jf14DTDT9rplgZvgENwcIgnKf9GM5 vFqoMa90rCxlycDcj3GJ/d8DElcrTrWmYQzO17WKza6sEbOv3py8IKbxh9iXM80QXQHe d3yr0A8eBAIcpeSdtK0SDHIDhFAdj9Y/VhOrJgnLrOqHuk2+ZNN+zm0pNfimOA4uhD0L j6SbHMD32DT+mKvNxSOLJY1ScwLXwqH735bzdMNEcXvtNFU+d4ReQ9Sh40Rp80uyAsXW BmI+aVNng+hf+VwSNlpeKaTtfaxiim4yBzlHI2gb/m7Pkt6OTF937yyrpTBp9EPw+rBF HHzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=tU+pvobIyvAWP3Y9++9NAIsFIAl1kMATXKdw2YbgWp8=; b=kK2bp34Jv0BrGmLS8PoxvxzNfaD60DVeBr8wojXJsPVKfeHDTFGs1SaSE95nw+a5GW irXTypo3nwHeaWCOYRWf3k+taDbFKeFRcrQo0OSHuPO4TE34Sq2Fp7MTsntsieV3zxT+ hllCokzNy4bswF19pRk02dy+WHWBN4SIG/AwEECCJ5hzBpp/FzcRitgsa4oGMF5iWkGZ Lmm77HJ7VziyeJeFrKEN6we0tNOAKRnCGvaGzv/+wRUnQEOr8fwK7eeMs+m3u/AyJTrM p7ZSEm1jY2hoJ+IdyI3XNH7zqM89/p3qvnjxKOmoEazmOpH/R4JkPNIrTgs07NQ3QTEF SNXQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b14si999173ejp.67.2020.11.04.01.52.00; Wed, 04 Nov 2020 01:52:23 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728645AbgKDJuL (ORCPT + 99 others); Wed, 4 Nov 2020 04:50:11 -0500 Received: from mx2.suse.de ([195.135.220.15]:41358 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728229AbgKDJuL (ORCPT ); Wed, 4 Nov 2020 04:50:11 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id DFA2EAFD0; Wed, 4 Nov 2020 09:50:09 +0000 (UTC) Date: Wed, 4 Nov 2020 10:50:07 +0100 From: osalvador To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Rashmica Gupta , Andrew Morton , Mike Rapoport , Michal Hocko , Wei Yang Subject: Re: [PATCH v1 3/4] powerpc/mm: remove linear mapping if __add_pages() fails in arch_add_memory() Message-ID: <20201104095007.GB4981@localhost.localdomain> References: <20201029162718.29910-1-david@redhat.com> <20201029162718.29910-4-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201029162718.29910-4-david@redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 29, 2020 at 05:27:17PM +0100, David Hildenbrand wrote: > Let's revert what we did in case seomthing goes wrong and we return an > error. Dumb question, but should not we do this for other arches as well? -- Oscar Salvador SUSE L3