Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Lukasz Stelmach <l.stelmach@samsung.com>
To:     Andrew Lunn <andrew@lunn.ch>
Cc:     jim.cromie@gmail.com, Heiner Kallweit <hkallweit1@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Kukjin Kim <kgene@kernel.org>,
        Krzysztof Kozlowski <krzk@kernel.org>,
        Russell King <linux@armlinux.org.uk>, netdev@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        linux-samsung-soc@vger.kernel.org,
        Marek Szyprowski <m.szyprowski@samsung.com>,
        =?utf-8?Q?Bart=C5=82omiej_=C5=BBolnierkiewic?= =?utf-8?Q?z?= 
        <b.zolnierkie@samsung.com>
Subject: Re: [PATCH v5 3/5] net: ax88796c: ASIX AX88796C SPI Ethernet
 Adapter Driver
Date:   Wed, 04 Nov 2020 11:20:37 +0100
In-Reply-To: <20201104024211.GS933237@lunn.ch> (Andrew Lunn's message of
        "Wed, 4 Nov 2020 03:42:11 +0100")
Message-ID: <dleftj361ps9sa.fsf%l.stelmach@samsung.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-="; micalg="pgp-sha256";
        protocol="application/pgp-signature"
CMS-TYPE: 201P
References: <20201104024211.GS933237@lunn.ch>
        <CGME20201104102048eucas1p1e3b29b66c497ee38656acf9ba5df10eb@eucas1p1.samsung.com>
Precedence: bulk

--=-=-=
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

It was <2020-11-04 =C5=9Bro 03:42>, when Andrew Lunn wrote:
>> +config SPI_AX88796C_COMPRESSION
>> +	bool "SPI transfer compression"
>> +	default n
>> +	depends on SPI_AX88796C
>> +	help
>> +	  Say Y here to enable SPI transfer compression. It saves up
>> +	  to 24 dummy cycles during each transfer which may noticably
>> +	  speed up short transfers. This sets the default value that is
>> +	  inherited by network interfecase during probe. It can be
>
> interface
>

Done.

>> +	  changed in run time via spi-compression ethtool tunable.
>
> changed _at_ run time...
>

Done.

>> +static int
>> +ax88796c_set_tunable(struct net_device *ndev, const struct ethtool_tuna=
ble *tuna,
>> +		     const void *data)
>> +{
>> +	struct ax88796c_device *ax_local =3D to_ax88796c_device(ndev);
>> +
>> +	switch (tuna->id) {
>> +	case ETHTOOL_SPI_COMPRESSION:
>> +		if (netif_running(ndev))
>> +			return -EBUSY;
>> +		ax_local->capabilities &=3D ~AX_CAP_COMP;
>> +		ax_local->capabilities |=3D *(u32 *)data ? AX_CAP_COMP : 0;
>
> You should probably validate here that data is 0 or 1. That is what
> ax88796c_get_tunable() will return.
>
> It seems like this controls two hardware bits:
>
> SPICR_RCEN | SPICR_QCEN
>
> Maybe at some point it would make sense to allow these bits to be set
> individually? If you never validate the tunable, you cannot make use
> of other values to control the bits individually.

Good point. What is your recommendation for the userland facing
interface, so that future changes will be least disruptive?

ax_local->capabilities |=3D ((*(u32 *)data) & SPICR_RCEN) ? AX_CAP_COMP : 0;

or rather

ax_local->capabilities |=3D ((*(u32 *)data) & (SPICR_RCEN | SPICR_QCEN)) ? =
AX_CAP_COMP : 0;

and possibly in the future (or now) split it into=20

ax_local->capabilities |=3D ((*(u32 *)data) & SPICR_RCEN) ? AX_CAP_COMP_R :=
 0;
ax_local->capabilities |=3D ((*(u32 *)data) & SPICR_QCEN) ? AX_CAP_COMP_Q :=
 0;

(and appropriate masking abve and proper handling in
ax88796c_soft_reset()).

Kind regards
=2D-=20
=C5=81ukasz Stelmach
Samsung R&D Institute Poland
Samsung Electronics

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEXpuyqjq9kGEVr9UQsK4enJilgBAFAl+igHUACgkQsK4enJil
gBDpnQf/cbn9zvVOSpwY+Yl0IedAqG6YyKtEcI+wgKi8WGod8AlkCjEiaWFllLGw
pLRiQz56g3mF0yTitLwdY9mA6Q2joEFPaJguJeVI6GhV9W3uoeWXl68DT5OtiHvp
21BtS2RqBzGahVGMRwqt7jDMsLBV2PiqymA0UeFCspWHqjpqRw5s7vy5ySBS+qkp
23g8vTpxXhKjLdogK0S2bL8kZT3kcpdVSIw39LxuTHscA3jxuFDX1sVoYpn30nRM
9sNj5SQC6i0ja+Uoaeju4kLbeIU8IxrwfpiHKU8G7zZqmSb2F0RUIpRBNxJoK897
dlH3+R8pzTOpDSFM29eRFfVPDQIZog==
=2VnL
-----END PGP SIGNATURE-----
--=-=-=--