Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp1201121pxb; Wed, 4 Nov 2020 02:43:08 -0800 (PST) X-Google-Smtp-Source: ABdhPJw4Ojv0Gyhlxpb2dxv+DfXQRgxNjFFY+CyTc68dl4BELrwH0kSn0Awl+8r6XzyChy/1Ux1H X-Received: by 2002:aa7:dc52:: with SMTP id g18mr26699968edu.369.1604486588647; Wed, 04 Nov 2020 02:43:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604486588; cv=none; d=google.com; s=arc-20160816; b=Od9p/alGUp4PLyCBJ2lSpL/+U8Y85FjP5ms/yB72ctUp20AAVOAjfBd65Qgs/0koGR p2/fyIddcec7gNd54OUfAI5gkC/x4MvVMU5lZoBloCEPLVggJf53Yiw7k9qRieuDw/ZM PN4JWs1VIQ4F9RD2yd9In/aCRhhd+h6C/KKAgnyiE4F1pfw3KabWwuutYrbBYfywGCRq BfE45V7sW6nAIaIn+70EUCPEK47aYbji1cZ4KlRDFiUS4Qzadg85nT9NSVZmGMOV4P8/ iSHC/dL/s6DaMnKatRxIhNfbCzM3H3cj7DX5duvSrj32frpo1aaHA3hsahWFc2SA2r56 peuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=mvauyEFD+Jh7MeRM/VTUdr28kCEejrqU5Xie/vSM3S0=; b=THVqAxHH0CXrvHvecapndhA/6xBcd5t3ASneQ7RXWlxI89JhYBuAx/wMec3gAlhQ20 bwedN+WV+e4rs0E8jwZjowqzN2dubvyhR45Vic+4XV551ITtWPD/6o+g1Dpz3ETVbsNP dPuziSZev7MppBarWWl+SyqvDur7ZuzBIRzupKQnHqrfp4lFga45E7tcMRBHIkekjTjF V1aCp1/mIPmELL5pxbtVuAjlZQegjDv9PzgrbmO99EUOTGHYEviUY+1gcREqsURNndf9 TiB/kloJVexVaipNxC/iP6h4OLhcuuqGgI5W8Lwnd+2ytfkdRAKgVZn68AcLHel3jh/a tDmA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y26si1123008ejq.617.2020.11.04.02.42.46; Wed, 04 Nov 2020 02:43:08 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729795AbgKDKkA (ORCPT + 99 others); Wed, 4 Nov 2020 05:40:00 -0500 Received: from mx2.suse.de ([195.135.220.15]:58556 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729427AbgKDKjy (ORCPT ); Wed, 4 Nov 2020 05:39:54 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 606A6ACE5; Wed, 4 Nov 2020 10:39:51 +0000 (UTC) From: Nicolas Saenz Julienne To: u.kleine-koenig@pengutronix.de, linux-kernel@vger.kernel.org, Linus Walleij , Bartosz Golaszewski Cc: f.fainelli@gmail.com, linux-pwm@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, wahrenst@gmx.net, linux-input@vger.kernel.org, dmitry.torokhov@gmail.com, gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, p.zabel@pengutronix.de, linux-gpio@vger.kernel.org, linux-clk@vger.kernel.org, sboyd@kernel.org, linux-rpi-kernel@lists.infradead.org, andy.shevchenko@gmail.com, Nicolas Saenz Julienne Subject: [PATCH v3 03/11] gpio: raspberrypi-exp: Release firmware handle on unbind Date: Wed, 4 Nov 2020 11:39:29 +0100 Message-Id: <20201104103938.1286-4-nsaenzjulienne@suse.de> X-Mailer: git-send-email 2.29.1 In-Reply-To: <20201104103938.1286-1-nsaenzjulienne@suse.de> References: <20201104103938.1286-1-nsaenzjulienne@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use devm_rpi_firmware_get() so as to make sure we release RPi's firmware interface when unbinding the device. Signed-off-by: Nicolas Saenz Julienne --- Changes since v2: - Use devm_rpi_firmware_get(), instead of remove function drivers/gpio/gpio-raspberrypi-exp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpio/gpio-raspberrypi-exp.c b/drivers/gpio/gpio-raspberrypi-exp.c index bb100e0124e6..64a552ecc2ad 100644 --- a/drivers/gpio/gpio-raspberrypi-exp.c +++ b/drivers/gpio/gpio-raspberrypi-exp.c @@ -208,7 +208,7 @@ static int rpi_exp_gpio_probe(struct platform_device *pdev) return -ENOENT; } - fw = rpi_firmware_get(fw_node); + fw = devm_rpi_firmware_get(&pdev->dev, fw_node); of_node_put(fw_node); if (!fw) return -EPROBE_DEFER; -- 2.29.1