Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp1201504pxb; Wed, 4 Nov 2020 02:43:55 -0800 (PST) X-Google-Smtp-Source: ABdhPJxolrtGJ9sGcgF8US5pfR2MXVY/BIsJhsRe57/mEPL7tOYFe9yqsBGuRQrkUaL7UYRvCrq+ X-Received: by 2002:a17:906:c352:: with SMTP id ci18mr25065743ejb.182.1604486635765; Wed, 04 Nov 2020 02:43:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604486635; cv=none; d=google.com; s=arc-20160816; b=G3OTIuO2gGeIRNwuFTvSbz65K3VGJ2sCPfYzQnGoHRoKiuwy4MLokgpSF4ASLtzgei +9f22WnQpNaAVozeuOxtYmsfr99dkV8cmF4Fk489IGiEm512jWMKUtDH+HNVct0Jgs8p /XdwdmSscxoalXbtWZ1i361bz8txFaNJeyOeP+vL6fvyrMjcOFAnrDE8Mso+cyU0Wm7Y ZMRzqeydgMjC/llwEl0ADI/jT/XCuckN493SGHyqIRE6sCl/tpmadWbDvvBGoBxqDB2/ sK4kbBfuwyg3kv2aHfbskgwxqKuabnuosGuOssh7wnUPDjUmvI1GDOdBLfk6CGizq0m1 SXGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=m6Vb9Yv74gyjervl7IxNzuUfE8mygc8ir6Aw30LRJok=; b=xQcAV/6tOkhWwHfZteWyH+LzS+N22G0IPgki+LPH0MIy5EnWi/lDEV8UMC9fgqMvMX Nees0rtth4r8RZHNiZ1Jo5tn7PB2hbfONj0wNewIVeDYFCQ3s4DVZREkVVJTgNByC9J9 DuX8O91NhdQ/8mtj4RzvzOZLpKbwl3v12S++1TAu1I4OTQHhofC1EsRzk69D3kxjHakh 08FfOpCMsnPj6wjj1x+qzWhsJAAYMwK++MDrG01PtpARyzYEqRlCj4rOxPm/MRbkuIlq oLew7B/cCmouAD+dcw0aE6lJZY+2YbE19fCOjm76GUrbGCvSf8b/+3aK/CCWdH9TW616 6l4Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g24si1027666edr.145.2020.11.04.02.43.33; Wed, 04 Nov 2020 02:43:55 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729841AbgKDKkF (ORCPT + 99 others); Wed, 4 Nov 2020 05:40:05 -0500 Received: from mx2.suse.de ([195.135.220.15]:58646 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729440AbgKDKjz (ORCPT ); Wed, 4 Nov 2020 05:39:55 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id B0E6AAD77; Wed, 4 Nov 2020 10:39:53 +0000 (UTC) From: Nicolas Saenz Julienne To: u.kleine-koenig@pengutronix.de, linux-kernel@vger.kernel.org Cc: f.fainelli@gmail.com, linux-pwm@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, wahrenst@gmx.net, linux-input@vger.kernel.org, dmitry.torokhov@gmail.com, gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, p.zabel@pengutronix.de, linux-gpio@vger.kernel.org, linus.walleij@linaro.org, linux-clk@vger.kernel.org, sboyd@kernel.org, linux-rpi-kernel@lists.infradead.org, bgolaszewski@baylibre.com, andy.shevchenko@gmail.com, Nicolas Saenz Julienne Subject: [PATCH v3 05/11] soc: bcm: raspberrypi-power: Release firmware handle on unbind Date: Wed, 4 Nov 2020 11:39:31 +0100 Message-Id: <20201104103938.1286-6-nsaenzjulienne@suse.de> X-Mailer: git-send-email 2.29.1 In-Reply-To: <20201104103938.1286-1-nsaenzjulienne@suse.de> References: <20201104103938.1286-1-nsaenzjulienne@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use devm_rpi_firmware_get() so as to make sure we release RPi's firmware interface when unbinding the device. Signed-off-by: Nicolas Saenz Julienne --- Changes since v2: - Use devm_rpi_firmware_get(), instead of remove function drivers/soc/bcm/raspberrypi-power.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/soc/bcm/raspberrypi-power.c b/drivers/soc/bcm/raspberrypi-power.c index 5d1aacdd84ef..068715d6e66d 100644 --- a/drivers/soc/bcm/raspberrypi-power.c +++ b/drivers/soc/bcm/raspberrypi-power.c @@ -177,7 +177,7 @@ static int rpi_power_probe(struct platform_device *pdev) return -ENODEV; } - rpi_domains->fw = rpi_firmware_get(fw_np); + rpi_domains->fw = devm_rpi_firmware_get(&pdev->dev, fw_np); of_node_put(fw_np); if (!rpi_domains->fw) return -EPROBE_DEFER; -- 2.29.1