Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp1212381pxb; Wed, 4 Nov 2020 03:04:14 -0800 (PST) X-Google-Smtp-Source: ABdhPJw4WvHlkJG/csCUHxiy0YdOZa8zbzwy8hl1cLgDYY0oyATw2mFzReiCFu7K5RGnlBmCWktn X-Received: by 2002:a17:906:a0cb:: with SMTP id bh11mr25391599ejb.314.1604487854574; Wed, 04 Nov 2020 03:04:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604487854; cv=none; d=google.com; s=arc-20160816; b=xpX1/vzVtEDvbPdOOzunAmdwpLj2LPXYoGc3b5Y8BPtFzRo/mhkaJh1GgjSiJcqVL9 wLhsur+iZpIEgNrd/BfSuX6Bg+HG1XJrSIIY7AsXYH690aSKzXrg35tOz1IDlcvyWTM/ E1zCUYnDXaRsKpkGj9pMjzf4qvJ0+iUOYNCK4c3EP0gQrkC+ys7kynWHng5u1BR1Ns2b T5I9g1Ihhal3HhA8Zl/c6BsboKBnYgH3pQeDr/PuoeP0XRZoixZDxmj75XpWEdMHdJfB QG9+MYgKHK+RmM5zn/rmhWQOJdMnwA2rL+HA97PbxGLv8jwKQEVVO0X/UIRYWn6ZAw1y CZgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=uwk5CW/0PPnnSyZuF/dFAgbn46Qc3AvJLHGno/R2B0U=; b=K3OZd+hpX5jl38s9DgPOje4r1q54Mt+mYK2VIbWWFuby29LJZLCUD4l4p/DwdyA8YJ TutGa5pdVI0fak6S4ow9kuxZRgTS4PooUMDqH3scHCE9TsS0X1PJ/sTIQZExcVem2ZS3 f9bRk5HbQ+UYGw7lAk0H26arQLX3LpRxwPofag+bY5gKlAd3xKl/59ulKEDKqwYzKJVx dGtsccEzglxVCNBBjU5bEuqx5//lCb2ILMIZNO2rDz3FCXwKAGOBdrEVTtfLV8aUpNQh CLJvYACdvAYb1hMpaMnkShtc4RlMl6oyyoDRAWaDdeAPrD9jyYe2G307mYg16Tn2emjS s+TA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=nurarh21; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a14si1205804ejs.111.2020.11.04.03.03.51; Wed, 04 Nov 2020 03:04:14 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=nurarh21; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729134AbgKDLCE (ORCPT + 99 others); Wed, 4 Nov 2020 06:02:04 -0500 Received: from mail.kernel.org ([198.145.29.99]:52330 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726344AbgKDLCE (ORCPT ); Wed, 4 Nov 2020 06:02:04 -0500 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E6AE720867; Wed, 4 Nov 2020 11:02:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604487723; bh=W+3QSsbuXdJVSCV51q6c6auVI0NKTOuW/rHh0EGgt0k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nurarh21VMIMoEwhAIZMBHGPYSK7vnzTUaEbu4qlm6ac0+hwaMe2szcQdyW7SLwtz 7gXOC7gb3HAsGHN6RmrbRvoMtUDT0DfiOgRl2iYTBSUHqwxowv7t7dt7MO63/Nzt6x CwKsFzkmJdQM04F4KthCnNwobMzSVyjaZ5Yf50t0= Date: Wed, 4 Nov 2020 12:02:53 +0100 From: Greg Kroah-Hartman To: Bernard Zhao Cc: Jiri Slaby , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, linux-arm-kernel@lists.infradead.org, opensource.kernel@vivo.com Subject: Re: [PATCH 0/2] drivers/tty: delete break after return or goto Message-ID: <20201104110253.GB1688848@kroah.com> References: <20201104105331.16654-1-bernard@vivo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201104105331.16654-1-bernard@vivo.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 04, 2020 at 02:53:29AM -0800, Bernard Zhao wrote: > This patch sereies optimise code like: > { > case XXX: > return XXX; > break; //The break is meanless, so just delete it. > case YYY: > goto YYY; > break; //The break is meanless, so just delete it. > ...... > } > > Signed-off-by: Bernard Zhao > > --- > Bernard Zhao (2): > drivers/tty/nozomi.c: delete no use break after goto > drivers/tty/serial/imx.c: delete no use break after return That is not the subject of the patches you sent out, what broke?