Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp1233310pxb; Wed, 4 Nov 2020 03:39:26 -0800 (PST) X-Google-Smtp-Source: ABdhPJy1YvXrmsqJDfbrPOi4TJcLmACSMEwDU9nyLIv19uSH1/yOF1MPu3O+tQVdr5Hfcxf9O5eV X-Received: by 2002:a17:906:e2c3:: with SMTP id gr3mr23933557ejb.471.1604489966135; Wed, 04 Nov 2020 03:39:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604489966; cv=none; d=google.com; s=arc-20160816; b=dWSVYRYfHGLYQfq+N+1wnT2eK1oi9YLSI0wvz3WeClAV575bO5DXC/JGg4nFo8Wqe9 vMeo90c8u9FxFI2v3RpdLrt1COpRVsN8mFnqHHaN9lHZlQowC3fddlkJYrAhYUv3qDqT xc7ttl2MUahBH+0/xB3rTCDmXqXfSKtNJTcfQn7DPwQciZBA7z1RGFzmR0C8Q9s/jkeK gUo+WOBe8aRBCbXjr/ukfR/sRptFhMGLEq0MmAnU6luF5VTdwEH2nxq3r49inDBCLCEC zhcjXM38YEETKsEr6BXkkEuQsEN2e2iWME+QCmjEqHG0t0zUjqoCmG24Hb70t+orqTKc /Bbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=AwkvLhaXrghbbWxPBS9gIMMUxlhuwRQE4R6mRTlyB9o=; b=f+6JTNIEc1+CSIu1nj1zJmgfvFxpCfLTylTL+E1/apvq7sARLi0LZJi7WSEFvawGYC 7vS94142tGztd/A+jWq+aw1eBR4w34kdpdvG5z1vEzn5ILZdCauXOZ2+dLA071Xc9GIA iWRYzylP3+51tltbAtLSxJjyXLyp6Y0Od2aRpdsptjUBAiiwyA2YpNTuaxLhQC9X/EtZ JSyH2TsTLVkeJs8FjpJnHhwdcn76qlnNhRZQ6T2ntGc+qON0JNK8WpkoAnUssVxDzgre lxDXTWxwlva5Iy2XEHCW9U9lFfEIOkhCPp+an03/s8g7PKSWC9wi9O2fgTxxAW6xpetz VjgQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=QTFiYGer; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n6si1119537edi.165.2020.11.04.03.39.03; Wed, 04 Nov 2020 03:39:26 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=QTFiYGer; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729438AbgKDLh3 (ORCPT + 99 others); Wed, 4 Nov 2020 06:37:29 -0500 Received: from fllv0015.ext.ti.com ([198.47.19.141]:59316 "EHLO fllv0015.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728999AbgKDLh3 (ORCPT ); Wed, 4 Nov 2020 06:37:29 -0500 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 0A4Bb078112623; Wed, 4 Nov 2020 05:37:00 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1604489820; bh=AwkvLhaXrghbbWxPBS9gIMMUxlhuwRQE4R6mRTlyB9o=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=QTFiYGerDk7a4WxT3V88okZt7XVcgbDyg0GbDnVdxLdCZqBa6MEsbAT4AiPv6apPV 7qJk7FJ0phcnU6QUAh1PmhpDNu8fM0zQmW+IYnNzKO/MeTjHhF4ScHS67mOqtE2MjD 4cBFEasPU4S27u9gV//CX5B7yNFmLsiXCYdFwUlA= Received: from DFLE112.ent.ti.com (dfle112.ent.ti.com [10.64.6.33]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 0A4Bb02r013556 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 4 Nov 2020 05:37:00 -0600 Received: from DFLE102.ent.ti.com (10.64.6.23) by DFLE112.ent.ti.com (10.64.6.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Wed, 4 Nov 2020 05:37:00 -0600 Received: from fllv0040.itg.ti.com (10.64.41.20) by DFLE102.ent.ti.com (10.64.6.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Wed, 4 Nov 2020 05:37:00 -0600 Received: from [10.250.100.73] (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id 0A4Baw08092005; Wed, 4 Nov 2020 05:36:58 -0600 Subject: Re: [PATCH 07/12] net: ethernet: ti: am65-cpts: Document am65_cpts_rx_enable()'s 'en' parameter To: Lee Jones , , CC: , , Kurt Kanzenbach , References: <20201104090610.1446616-1-lee.jones@linaro.org> <20201104090610.1446616-8-lee.jones@linaro.org> From: Grygorii Strashko Message-ID: Date: Wed, 4 Nov 2020 13:37:08 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201104090610.1446616-8-lee.jones@linaro.org> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/11/2020 11:06, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/net/ethernet/ti/am65-cpts.c:736: warning: Function parameter or member 'en' not described in 'am65_cpts_rx_enable' > drivers/net/ethernet/ti/am65-cpts.c:736: warning: Excess function parameter 'skb' description in 'am65_cpts_rx_enable' > > Cc: "David S. Miller" > Cc: Jakub Kicinski > Cc: Grygorii Strashko > Cc: Kurt Kanzenbach > Cc: netdev@vger.kernel.org > Signed-off-by: Lee Jones > --- > drivers/net/ethernet/ti/am65-cpts.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/ti/am65-cpts.c b/drivers/net/ethernet/ti/am65-cpts.c > index 75056c14b161b..bb2b8e4919feb 100644 > --- a/drivers/net/ethernet/ti/am65-cpts.c > +++ b/drivers/net/ethernet/ti/am65-cpts.c > @@ -727,7 +727,7 @@ static long am65_cpts_ts_work(struct ptp_clock_info *ptp) > /** > * am65_cpts_rx_enable - enable rx timestamping > * @cpts: cpts handle > - * @skb: packet > + * @en: enable > * > * This functions enables rx packets timestamping. The CPTS can timestamp all > * rx packets. > Thank you. Reviewed-by: Grygorii Strashko -- Best regards, grygorii