Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp1234121pxb; Wed, 4 Nov 2020 03:41:02 -0800 (PST) X-Google-Smtp-Source: ABdhPJwrvdW9beCLAAdoSbNUxilfPTvI0E5Ys+tge1f+BNSaOirCSrJVkk56/lE6OWDIIKfoJeMb X-Received: by 2002:a17:906:d931:: with SMTP id rn17mr16290119ejb.308.1604490061957; Wed, 04 Nov 2020 03:41:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604490061; cv=none; d=google.com; s=arc-20160816; b=qLZ8tZuwXNDqwajiJsfhqfOTpfLu7vatTdcIJjQPxb2GLBBtP5ae2HFVaoJ8rzTpW3 rh4QU3YXuNfrLQ1IoG8xZM6wCRQctnhz4R0ljnzPjJBmHDK4yMMqH4kclxedpzdeGEZW qRAjjWYzS45NdRWDC6lD6G/ahMSiqWoKbtA2CUMQhFQTdtBxzSnpx3AjEsXhwZuqRSDy yGLO73Iw7RLVN0nRWhM0Lt9iDS/vZOmFwjjZr/S+2c7fHZnKgm0MQ0+9KwsXZJCx1jvF WQ87Koi+Or8zoSufMnc8vHrV/xMXkpmlkVKlhQP9kCkMkzJTFeziIMeaKjANiOv6KcqM q6aA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:subject:references:in-reply-to :cc:to:from; bh=6ul0X3Bb25OPkD2V+2UJB3X2Ks2LFbJ9gDH+aRhJlbQ=; b=oEGrny91R6YAjein9+R1e3fv2RpGCIdQzedYTADwsb7pZWv1yhlh+yE2VxNQT1dLc8 RjJKrW9Mp/ouUNgF3l21NgJ9jgmWC/igpVFdXIguJwXdl/c2kSdGYMigJKowiAvnRnDb gYsndWgvfu6EoKiFDSqDnIGvf28GxwpFysXhMmqam7eNV/W1+fMytUXE3AhsireTco0Y L+g8Aa60V8pF+GeaCv5HeOwTkc98I0VEYZU1DZhEBzdqX7BVtivWIdTz3cUcTGEvXcRV UK/izfO4/ksEK68KfY1J3yx3MVNm3jxl18witrxsli42TvTvboKgRc0PYPTsRE1X51RK UzVg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p21si1248281ejx.516.2020.11.04.03.40.39; Wed, 04 Nov 2020 03:41:01 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728645AbgKDLig (ORCPT + 99 others); Wed, 4 Nov 2020 06:38:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46410 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728287AbgKDLif (ORCPT ); Wed, 4 Nov 2020 06:38:35 -0500 Received: from ozlabs.org (bilbo.ozlabs.org [IPv6:2401:3900:2:1::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 73259C0613D3 for ; Wed, 4 Nov 2020 03:38:35 -0800 (PST) Received: by ozlabs.org (Postfix, from userid 1034) id 4CR4RC23yVz9sVK; Wed, 4 Nov 2020 22:38:30 +1100 (AEDT) From: Michael Ellerman To: Michael Ellerman , Qian Cai Cc: Oliver O'Halloran , linuxppc-dev@lists.ozlabs.org, Paul Mackerras , linux-kernel@vger.kernel.org In-Reply-To: <20201028152717.8967-1-cai@redhat.com> References: <20201028152717.8967-1-cai@redhat.com> Subject: Re: [PATCH] powerpc/eeh_cache: Fix a possible debugfs deadlock Message-Id: <160448988321.674824.1925161464513848358.b4-ty@ellerman.id.au> Date: Wed, 4 Nov 2020 22:38:30 +1100 (AEDT) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 28 Oct 2020 11:27:17 -0400, Qian Cai wrote: > Lockdep complains that a possible deadlock below in > eeh_addr_cache_show() because it is acquiring a lock with IRQ enabled, > but eeh_addr_cache_insert_dev() needs to acquire the same lock with IRQ > disabled. Let's just make eeh_addr_cache_show() acquire the lock with > IRQ disabled as well. > > CPU0 CPU1 > ---- ---- > lock(&pci_io_addr_cache_root.piar_lock); > local_irq_disable(); > lock(&tp->lock); > lock(&pci_io_addr_cache_root.piar_lock); > > lock(&tp->lock); > > [...] Applied to powerpc/fixes. [1/1] powerpc/eeh_cache: Fix a possible debugfs deadlock https://git.kernel.org/powerpc/c/fd552e0542b4532483289cce48fdbd27b692984b cheers