Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp1244155pxb; Wed, 4 Nov 2020 04:01:09 -0800 (PST) X-Google-Smtp-Source: ABdhPJzKsp0iVUc4rn1Wyvz9mqN65STjp+us95GVrUVzTxDtkHSTtKfJ7G3B1V4fav+Pvd4FlG8b X-Received: by 2002:a17:906:d8ce:: with SMTP id re14mr24203989ejb.275.1604491269267; Wed, 04 Nov 2020 04:01:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604491269; cv=none; d=google.com; s=arc-20160816; b=gkbYShEZjvX3VE+SWLSlsF/4MXLH6M5lboxjcqZk59nOgcivCukQTpebEF7u/7GvmF RfFKRX43K9fsChyj3liu0zVSyCUuLTt+SzoA0fAOdpe3Uu8WElb6AvGdN0vRGMHKoASJ wzUkQTb7vrXnJbPobe9G1BU2DF4bPsZSNCi2c7RdNT0et3b+fK9AMLndrfIvSM45P2QN D+saM0Ajlz1pKWUkSCbH4dfudXHSIyg7D9SlDgNZXDzAjlc6yVbnSVFtzuGdlYUdLG/w wBIfW6APNTCz3+5qyn4vR9/wvqJzbM8O6LDnuNKG7HimU3je2k14ySWzaggKJAXNPJDy pGAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=SYrCti4dpvDkC2P6TQA199s+nDnlPihjPbSyVlbXlSg=; b=XyfBYArxU+zKlBfvcT1JyXNsjML8DjswP7dV8b3bGy7gktjFCDgzjUnz8Fnfi33PZy BHscxsFsdFyXS2XUiJ4zCcx4Cl0LhbUpNxNOCg8sR3/SRLLEbAUf5DxwvnSRr9zIpYQd qI59p6Ad/2fdgnE+4fD4fQDAMEbwLC/dHwx5ZwUnPkwzVLKWYeG14gp8er/gYDNylYw2 /jv++gY3LlNk7r9mjyZFTw0BTfdweYex4quDv/YlOdV5zyluyqYEooK+ezmB3u9fTDev /DIyGXjwUe6LszayIkXb60m6kU/yr8EzPUEjNUt/yVDLPq6LGzSUrWc2MZRoyCPCI5qq d/4Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=oWRQQ8Ky; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k20si1124475ejj.93.2020.11.04.04.00.43; Wed, 04 Nov 2020 04:01:09 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=oWRQQ8Ky; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729677AbgKDL7R (ORCPT + 99 others); Wed, 4 Nov 2020 06:59:17 -0500 Received: from mail.kernel.org ([198.145.29.99]:35244 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729436AbgKDL6O (ORCPT ); Wed, 4 Nov 2020 06:58:14 -0500 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 793A520759; Wed, 4 Nov 2020 11:58:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604491093; bh=VYBsXiXrYl7rJ+8UiwwTogyHicS+8WxebwYlJQWgCkw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=oWRQQ8KyznKGN8gvdFOT6PHGpzL5Sns1/zWQFF1+HcjdpRb2d7Ci6FUjZsSWntWe0 CrkGWOCihpIWLk3tTTC846bUhCffQhzB/qV4ZqG3yHhMissmPpqZRFdeaPAFytRSh+ XedLtgGFQBd9e2ShLjVqt/fCaYOA+RD/IxAjh5OE= Date: Wed, 4 Nov 2020 12:59:03 +0100 From: Greg Kroah-Hartman To: Bernard Cc: Jiri Slaby , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, linux-arm-kernel@lists.infradead.org, opensource.kernel@vivo.com Subject: Re: Re: [PATCH 0/2] drivers/tty: delete break after return or goto Message-ID: <20201104115903.GA1694605@kroah.com> References: <20201104110253.GB1688848@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 04, 2020 at 07:17:56PM +0800, Bernard wrote: > > > From: Greg Kroah-Hartman > Date: 2020-11-04 19:02:53 > To: Bernard Zhao > Cc: Jiri Slaby ,Shawn Guo ,Sascha Hauer ,Pengutronix Kernel Team ,Fabio Estevam ,NXP Linux Team ,linux-kernel@vger.kernel.org,linux-serial@vger.kernel.org,linux-arm-kernel@lists.infradead.org,opensource.kernel@vivo.com > Subject: Re: [PATCH 0/2] drivers/tty: delete break after return or goto>On Wed, Nov 04, 2020 at 02:53:29AM -0800, Bernard Zhao wrote: > >> This patch sereies optimise code like: > >> { > >> case XXX: > >> return XXX; > >> break; //The break is meanless, so just delete it. > >> case YYY: > >> goto YYY; > >> break; //The break is meanless, so just delete it. > >> ...... > >> } > >> > >> Signed-off-by: Bernard Zhao > >> > >> --- > >> Bernard Zhao (2): > >> drivers/tty/nozomi.c: delete no use break after goto > >> drivers/tty/serial/imx.c: delete no use break after return > > > >That is not the subject of the patches you sent out, what broke? > > Hi: > > I am sorry that I am a little confused: > The patch series`s subject is "drivers/tty: delete break after return or goto" > and the blurb is: > This patch sereies optimise code like: > { > case XXX: > return XXX; > break; //The break is meanless, so just delete it. > case YYY: > goto YYY; > break; //The break is meanless, so just delete it. > ...... > } > last, the modified files are: > Bernard Zhao (2): > drivers/tty/nozomi.c: delete no use break after goto > drivers/tty/serial/imx.c: delete no use break after return > > Is there something wrong that I didn`t catch? The above lines do not match up with the subject lines of the patches you sent out, so something went wrong. thanks, greg k-h