Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.17\))
Subject: Re: [PATCH] selftests/cgroup: Fix build on older distros
From:   Sachin Sant <sachinp@linux.vnet.ibm.com>
In-Reply-To: <20201104100545.657898-1-mpe@ellerman.id.au>
Date:   Wed, 4 Nov 2020 17:50:40 +0530
Cc:     linux-kselftest@vger.kernel.org, skhan@linuxfoundation.org,
        linux-kernel@vger.kernel.org, keescook@chromium.org,
        christian@brauner.io
Content-Transfer-Encoding: quoted-printable
Message-Id: <EC8A9B1A-B080-499D-B81C-31055E1C8BD8@linux.vnet.ibm.com>
References: <20201104100545.657898-1-mpe@ellerman.id.au>
To:     Michael Ellerman <mpe@ellerman.id.au>
Precedence: bulk


> On 04-Nov-2020, at 3:35 PM, Michael Ellerman <mpe@ellerman.id.au> =
wrote:
>=20
> On older distros struct clone_args does not have a cgroup member,
> leading to build errors:
>=20
>  cgroup_util.c: In function 'clone_into_cgroup':
>  cgroup_util.c:343:4: error: 'struct clone_args' has no member named =
'cgroup'
>=20
> But the selftests already have a locally defined version of the
> structure which is up to date, called __clone_args.
>=20
> So use __clone_args which fixes the error.
>=20

Argument passed to sys_clone3() will also require a similar change.

-	pid =3D sys_clone3(&args, sizeof(struct clone_args));
+	pid =3D sys_clone3(&args, sizeof(struct __clone_args));

Without this compilation still fails(at least for me) due to following =
error

cgroup_util.c: In function 'clone_into_cgroup':
cgroup_util.c:346:33: error: invalid application of 'sizeof' to =
incomplete type 'struct clone_args'
  pid =3D sys_clone3(&args, sizeof(struct clone_args));

> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
> ---
> tools/testing/selftests/cgroup/cgroup_util.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/tools/testing/selftests/cgroup/cgroup_util.c =
b/tools/testing/selftests/cgroup/cgroup_util.c
> index 05853b0b8831..58e30f65df5e 100644
> --- a/tools/testing/selftests/cgroup/cgroup_util.c
> +++ b/tools/testing/selftests/cgroup/cgroup_util.c
> @@ -337,7 +337,7 @@ pid_t clone_into_cgroup(int cgroup_fd)
> #ifdef CLONE_ARGS_SIZE_VER2
> 	pid_t pid;
>=20
> -	struct clone_args args =3D {
> +	struct __clone_args args =3D {
> 		.flags =3D CLONE_INTO_CGROUP,
> 		.exit_signal =3D SIGCHLD,
> 		.cgroup =3D cgroup_fd,
>=20
> base-commit: cf7cd542d1b538f6e9e83490bc090dd773f4266d
> --=20
> 2.25.1
>=20