Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 4 Nov 2020 13:31:29 +0100
From:   Christian Brauner <christian.brauner@ubuntu.com>
To:     Sachin Sant <sachinp@linux.vnet.ibm.com>,
        Michael Ellerman <mpe@ellerman.id.au>
Cc:     linux-kselftest@vger.kernel.org, skhan@linuxfoundation.org,
        linux-kernel@vger.kernel.org, keescook@chromium.org,
        christian@brauner.io
Subject: Re: [PATCH] selftests/cgroup: Fix build on older distros
Message-ID: <20201104123129.qczj363jrqiljpvi@wittgenstein>
References: <20201104100545.657898-1-mpe@ellerman.id.au>
 <EC8A9B1A-B080-499D-B81C-31055E1C8BD8@linux.vnet.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <EC8A9B1A-B080-499D-B81C-31055E1C8BD8@linux.vnet.ibm.com>
Precedence: bulk

On Wed, Nov 04, 2020 at 05:50:40PM +0530, Sachin Sant wrote:
> 
> 
> > On 04-Nov-2020, at 3:35 PM, Michael Ellerman <mpe@ellerman.id.au> wrote:
> > 
> > On older distros struct clone_args does not have a cgroup member,
> > leading to build errors:
> > 
> >  cgroup_util.c: In function 'clone_into_cgroup':
> >  cgroup_util.c:343:4: error: 'struct clone_args' has no member named 'cgroup'
> > 
> > But the selftests already have a locally defined version of the
> > structure which is up to date, called __clone_args.
> > 
> > So use __clone_args which fixes the error.
> > 
> 
> Argument passed to sys_clone3() will also require a similar change.
> 
> -	pid = sys_clone3(&args, sizeof(struct clone_args));
> +	pid = sys_clone3(&args, sizeof(struct __clone_args));
> 
> Without this compilation still fails(at least for me) due to following error
> 
> cgroup_util.c: In function 'clone_into_cgroup':
> cgroup_util.c:346:33: error: invalid application of 'sizeof' to incomplete type 'struct clone_args'
>   pid = sys_clone3(&args, sizeof(struct clone_args));
> 
> > Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
> > ---

Thanks Michael for taking care fo this. Much appreciated. I think with
the fix that Sachin pointed out this should work out fine!

Once that's fixed up:
Acked-by: Christian Brauner <christian.brauner@ubuntu.com>

Thanks!
Christian