Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 4 Nov 2020 12:36:59 +0000
From:   Matthew Wilcox <willy@infradead.org>
To:     Eric Dumazet <eric.dumazet@gmail.com>
Cc:     Rama Nichanamatlu <rama.nichanamatlu@oracle.com>,
        Dongli Zhang <dongli.zhang@oracle.com>, linux-mm@kvack.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        akpm@linux-foundation.org, davem@davemloft.net, kuba@kernel.org,
        aruna.ramakrishna@oracle.com, bert.barbe@oracle.com,
        venkat.x.venkatsubra@oracle.com, manjunath.b.patil@oracle.com,
        joe.jin@oracle.com, srinivas.eeda@oracle.com
Subject: Re: [PATCH 1/1] mm: avoid re-using pfmemalloc page in
 page_frag_alloc()
Message-ID: <20201104123659.GA17076@casper.infradead.org>
References: <20201103193239.1807-1-dongli.zhang@oracle.com>
 <20201103203500.GG27442@casper.infradead.org>
 <7141038d-af06-70b2-9f50-bf9fdf252e22@oracle.com>
 <20201103211541.GH27442@casper.infradead.org>
 <20201104011640.GE2445@rnichana-ThinkPad-T480>
 <2bce996a-0a62-9d14-4310-a4c5cb1ddeae@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <2bce996a-0a62-9d14-4310-a4c5cb1ddeae@gmail.com>
Precedence: bulk

On Wed, Nov 04, 2020 at 09:50:30AM +0100, Eric Dumazet wrote:
> On 11/4/20 2:16 AM, Rama Nichanamatlu wrote:
> >> Thanks for providing the numbers.? Do you think that dropping (up to)
> >> 7 packets is acceptable?
> > 
> > net.ipv4.tcp_syn_retries = 6
> > 
> > tcp clients wouldn't even get that far leading to connect establish issues.
> 
> This does not really matter. If host was under memory pressure,
> dropping a few packets is really not an issue.
> 
> Please do not add expensive checks in fast path, just to "not drop a packet"
> even if the world is collapsing.

Right, that was my first patch -- to only recheck if we're about to
reuse the page.  Do you think that's acceptable, or is that still too
close to the fast path?

> Also consider that NIC typically have thousands of pre-allocated page/frags
> for their RX ring buffers, they might all have pfmemalloc set, so we are speaking
> of thousands of packet drops before the RX-ring can be refilled with normal (non pfmemalloc) page/frags.
> 
> If we want to solve this issue more generically, we would have to try
> to copy data into a non pfmemalloc frag instead of dropping skb that
> had frags allocated minutes ago under memory pressure.

I don't think we need to copy anything.  We need to figure out if the
system is still under memory pressure, and if not, we can clear the
pfmemalloc bit on the frag, as in my second patch.  The 'least change'
way of doing that is to try to allocate a page, but the VM could export
a symbol that says "we're not under memory pressure any more".

Did you want to move checking that into the networking layer, or do you
want to keep it in the pagefrag allocator?