Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp1297027pxb; Wed, 4 Nov 2020 05:27:45 -0800 (PST) X-Google-Smtp-Source: ABdhPJziSDjR2FvRAXvahqq/EV6bcJZ2+7M7WaHwS3lu1+m9h3K7qAoAbfAOLYXkrf5pgontXi7/ X-Received: by 2002:a17:906:6702:: with SMTP id a2mr24280113ejp.309.1604496465608; Wed, 04 Nov 2020 05:27:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604496465; cv=none; d=google.com; s=arc-20160816; b=tX96yHiLasjtOZXsjOYLMo/MCIu4lAErCTVlvGvN7NG3V+qbCkS+Hc31pkyDZ49Vt9 6FRufo/4YADNGS8OgjQNWNaIjxbaCqfAqd5bau7TVukA/d58zG+UYodWDmLEa+zCFq/N SAUoyDjOh6ejcGlZv70uA95/ZGPnAej+aTrSia1dXRDaRWW8yr/lnrt4N6zmxDILUBKk g+ZJcHkwVD+PqAccZ/v0W6innTni9VQqj1ybhDfihXZhXkCH1XBmO4RjP/h3kk/KTFgE 0e+G7EEsbJAi4eAF3WLEnfR/1dho3c80ygxcsrC8BiDgU482BcDcCUI/3ic9UgAHIGBs YZhg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=XWnHVD6FfHTnr73Ze/G0nsH3PvmwuZFXKffH8YnroHM=; b=XJ/DmNQPBj6gVR7uWVcDm9c+WWzEdTRBNyu40gkB3iyyhTbLQ6n0/FsVcBhIMpRzcJ nIqXF9t6mUCYGkfh2S8ZZsvzqUlwRybAv6cAPQYV4q9VX2PS2MXAWftFvlQynXA88aqr Gw2WjArk1Uu9dfSsvnFAUeeOKCIJwFrBX9yR0qsjKUrQtzNF+LSiIHiS+nqj/ov1z8qt xqtJ/mcdjOOPQwTIF3CBzzINRKwurM6AO90xz41er6lp8xuVu09nbOpHHWWs0sv6mu/g Wyxljj4rYBZJBGBukSkB+9ihGsBnNtUSjtVSHg7Mq1LtoItAc8kFB6/bIQrcaUMerhzT /FoQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c35si1209756edf.528.2020.11.04.05.27.22; Wed, 04 Nov 2020 05:27:45 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730018AbgKDNXd (ORCPT + 99 others); Wed, 4 Nov 2020 08:23:33 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:34664 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729836AbgKDNXc (ORCPT ); Wed, 4 Nov 2020 08:23:32 -0500 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1kaIl6-005CxM-8o; Wed, 04 Nov 2020 14:23:28 +0100 Date: Wed, 4 Nov 2020 14:23:28 +0100 From: Andrew Lunn To: Lee Jones Cc: davem@davemloft.net, kuba@kernel.org, Woojung Huh , netdev@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Microchip Linux Driver Support , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 01/12] net: usb: lan78xx: Remove lots of set but unused 'ret' variables Message-ID: <20201104132328.GX933237@lunn.ch> References: <20201104090610.1446616-1-lee.jones@linaro.org> <20201104090610.1446616-2-lee.jones@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20201104090610.1446616-2-lee.jones@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 04, 2020 at 09:05:59AM +0000, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/net/usb/lan78xx.c: In function ‘lan78xx_read_raw_otp’: > drivers/net/usb/lan78xx.c:825:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] > drivers/net/usb/lan78xx.c: In function ‘lan78xx_write_raw_otp’: > drivers/net/usb/lan78xx.c:879:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] > drivers/net/usb/lan78xx.c: In function ‘lan78xx_deferred_multicast_write’: > drivers/net/usb/lan78xx.c:1041:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] > drivers/net/usb/lan78xx.c: In function ‘lan78xx_update_flowcontrol’: > drivers/net/usb/lan78xx.c:1127:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] > drivers/net/usb/lan78xx.c: In function ‘lan78xx_init_mac_address’: > drivers/net/usb/lan78xx.c:1666:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] > drivers/net/usb/lan78xx.c: In function ‘lan78xx_link_status_change’: > drivers/net/usb/lan78xx.c:1841:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] > drivers/net/usb/lan78xx.c: In function ‘lan78xx_irq_bus_sync_unlock’: > drivers/net/usb/lan78xx.c:1920:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] > drivers/net/usb/lan78xx.c: In function ‘lan8835_fixup’: > drivers/net/usb/lan78xx.c:1994:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] > drivers/net/usb/lan78xx.c: In function ‘lan78xx_set_rx_max_frame_length’: > drivers/net/usb/lan78xx.c:2192:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] > drivers/net/usb/lan78xx.c: In function ‘lan78xx_change_mtu’: > drivers/net/usb/lan78xx.c:2270:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] > drivers/net/usb/lan78xx.c: In function ‘lan78xx_set_mac_addr’: > drivers/net/usb/lan78xx.c:2299:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] > drivers/net/usb/lan78xx.c: In function ‘lan78xx_set_features’: > drivers/net/usb/lan78xx.c:2333:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] > drivers/net/usb/lan78xx.c: In function ‘lan78xx_set_suspend’: > drivers/net/usb/lan78xx.c:3807:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] > > Cc: Woojung Huh > Cc: Microchip Linux Driver Support > Cc: "David S. Miller" > Cc: Jakub Kicinski > Cc: netdev@vger.kernel.org > Cc: linux-usb@vger.kernel.org > Signed-off-by: Lee Jones Reviewed-by: Andrew Lunn Andrew