Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964846AbWHRFwp (ORCPT ); Fri, 18 Aug 2006 01:52:45 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S964844AbWHRFwp (ORCPT ); Fri, 18 Aug 2006 01:52:45 -0400 Received: from msr3.hinet.net ([168.95.4.103]:49657 "EHLO msr3.hinet.net") by vger.kernel.org with ESMTP id S964841AbWHRFwo (ORCPT ); Fri, 18 Aug 2006 01:52:44 -0400 Message-ID: <02d101c6c28a$7c19d160$4964a8c0@icplus.com.tw> From: "Jesse Huang" To: "Jeff Garzik" Cc: , , References: <1155841247.4532.6.camel@localhost.localdomain> <44E480FA.70806@pobox.com> Subject: Re: [PATCH 1/6] IP100A, add end of pci id table Date: Fri, 18 Aug 2006 13:52:26 +0800 X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 6.00.2800.1807 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2800.1807 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1405 Lines: 46 Hi Jeff: Sorry for that. I will remove those. Am I need to resent all of those patch or send all in one patch? Jesse Huang. ----- Original Message ----- From: "Jeff Garzik" To: "Jesse Huang" Cc: ; ; Sent: Thursday, August 17, 2006 10:45 PM Subject: Re: [PATCH 1/6] IP100A, add end of pci id table Jesse Huang wrote: > @@ -212,7 +212,7 @@ static const struct pci_device_id sundan > { 0x1186, 0x1002, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 4 }, > { 0x13F0, 0x0201, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 5 }, > { 0x13F0, 0x0200, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 6 }, > - { } > + { 0,} > }; > MODULE_DEVICE_TABLE(pci, sundance_pci_tbl); > > @@ -231,7 +231,7 @@ static const struct pci_id_info pci_id_t > {"D-Link DL10050-based FAST Ethernet Adapter"}, > {"Sundance Technology Alta"}, > {"IC Plus Corporation IP100A FAST Ethernet Adapter"}, > - { } /* terminate list. */ > + { NULL,} /* terminate list. */ NAK. An empty array element "{ }" implies NULL. It is the kernel standard to prefer "{ }" over an explicit initialization. Looks cleaner. Jeff - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/