Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp1308875pxb; Wed, 4 Nov 2020 05:45:36 -0800 (PST) X-Google-Smtp-Source: ABdhPJyHq6WJFyNGqu/iczQXnonQv++N0V4KEPhlh8gEYywozVZ+x5uilcfZ8QjoN1LsWPZpllnz X-Received: by 2002:a50:fe18:: with SMTP id f24mr21004319edt.162.1604497536454; Wed, 04 Nov 2020 05:45:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604497536; cv=none; d=google.com; s=arc-20160816; b=miSkKpOrAHYU/5cI5g2SSZRoKGJGRtq4IAdVLMipPDG7uCUcV+zYHnosxLK7b6nPP1 vyBpQk2j9zbcBSbQy5kO9xDcp6/O7I41xySl1fK7cL5wpoBB3m3b7fEGXDPPdFjahQCu owqvQOoWtsTUNs5XbuHKGohPdkAb/YzHdFzLKhirz5zrmBvWkvMUDGBgp+ls2H7aef6t hW8A0+PhiWEGOhGm6VPMhgG/Jpj2A0f+pSWDU9KJM9iFv++PreYGp/daY7vCNOwRB8XI op0k4/GtX4z/gIu1yMv0wssT64E38Z6F9PSojsW28SWsQjoMIeR/aMdSlv14wfFvXXdH YoxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=smiG5MRyAXUKVO0VNPhgX+G7FNZci/gmsW5nH+Xj6wY=; b=XTh0zHM+aU008fa7UB9SsY6xIOIJW8jmOAC6dtfmFnQJWfTkEgCOBkgwm1/ySPjMah I1pDcmddayl8DJoZalujdZbEV9aTSWBVmXkEyGlbdRnLE/VAB/sv42Tkorx7miKBxrZP J2iYlZwGAP08P5JfG0zjL2BpLcl45JVFcUm2hogNsDYDVFfiKHf7nR4N2tkS1VMaHgNl 0N3fXAMftR1h/zrjbabgWDuswFJgs+MYGQCwd82qVUG6BnIlGcwEBi8DMHUxy/vYQseZ t9ehhlV6Ger2HVnx3r4sZgYkif1yE5DLFjB3t2EMXRzRck0ox8KTPw996a59NPTipBjU X/9w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g16si1390930ejw.559.2020.11.04.05.45.13; Wed, 04 Nov 2020 05:45:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729898AbgKDNn1 (ORCPT + 99 others); Wed, 4 Nov 2020 08:43:27 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:34962 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726608AbgKDNn0 (ORCPT ); Wed, 4 Nov 2020 08:43:26 -0500 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1kaJ4J-005DJC-9K; Wed, 04 Nov 2020 14:43:19 +0100 Date: Wed, 4 Nov 2020 14:43:19 +0100 From: Andrew Lunn To: Lee Jones Cc: davem@davemloft.net, kuba@kernel.org, Jens Osterkamp , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Utz Bacher , linux-arm-kernel@lists.infradead.org, Ishizaki Kou Subject: Re: [PATCH 11/12] net: ethernet: toshiba: spider_net: Document a whole bunch of function parameters Message-ID: <20201104134319.GE933237@lunn.ch> References: <20201104090610.1446616-1-lee.jones@linaro.org> <20201104090610.1446616-12-lee.jones@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201104090610.1446616-12-lee.jones@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 04, 2020 at 09:06:09AM +0000, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/net/ethernet/toshiba/spider_net.c:263: warning: Function parameter or member 'hwdescr' not described in 'spider_net_get_descr_status' > drivers/net/ethernet/toshiba/spider_net.c:263: warning: Excess function parameter 'descr' description in 'spider_net_get_descr_status' > drivers/net/ethernet/toshiba/spider_net.c:554: warning: Function parameter or member 'netdev' not described in 'spider_net_get_multicast_hash' > drivers/net/ethernet/toshiba/spider_net.c:902: warning: Function parameter or member 't' not described in 'spider_net_cleanup_tx_ring' > drivers/net/ethernet/toshiba/spider_net.c:902: warning: Excess function parameter 'card' description in 'spider_net_cleanup_tx_ring' > drivers/net/ethernet/toshiba/spider_net.c:1074: warning: Function parameter or member 'card' not described in 'spider_net_resync_head_ptr' > drivers/net/ethernet/toshiba/spider_net.c:1234: warning: Function parameter or member 'napi' not described in 'spider_net_poll' > drivers/net/ethernet/toshiba/spider_net.c:1234: warning: Excess function parameter 'netdev' description in 'spider_net_poll' > drivers/net/ethernet/toshiba/spider_net.c:1278: warning: Function parameter or member 'p' not described in 'spider_net_set_mac' > drivers/net/ethernet/toshiba/spider_net.c:1278: warning: Excess function parameter 'ptr' description in 'spider_net_set_mac' > drivers/net/ethernet/toshiba/spider_net.c:1350: warning: Function parameter or member 'error_reg1' not described in 'spider_net_handle_error_irq' > drivers/net/ethernet/toshiba/spider_net.c:1350: warning: Function parameter or member 'error_reg2' not described in 'spider_net_handle_error_irq' > drivers/net/ethernet/toshiba/spider_net.c:1968: warning: Function parameter or member 't' not described in 'spider_net_link_phy' > drivers/net/ethernet/toshiba/spider_net.c:1968: warning: Excess function parameter 'data' description in 'spider_net_link_phy' > drivers/net/ethernet/toshiba/spider_net.c:2149: warning: Function parameter or member 'work' not described in 'spider_net_tx_timeout_task' > drivers/net/ethernet/toshiba/spider_net.c:2149: warning: Excess function parameter 'data' description in 'spider_net_tx_timeout_task' > drivers/net/ethernet/toshiba/spider_net.c:2182: warning: Function parameter or member 'txqueue' not described in 'spider_net_tx_timeout' > > Cc: Ishizaki Kou > Cc: "David S. Miller" > Cc: Jakub Kicinski > Cc: Utz Bacher > Cc: Jens Osterkamp > Cc: netdev@vger.kernel.org > Signed-off-by: Lee Jones Reviewed-by: Andrew Lunn Andrew