Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Parshuram Raju Thombare <pthombar@cadence.com>
To:     "Nicolas.Ferre@microchip.com" <Nicolas.Ferre@microchip.com>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
CC:     "Claudiu.Beznea@microchip.com" <Claudiu.Beznea@microchip.com>,
        "Santiago.Esteban@microchip.com" <Santiago.Esteban@microchip.com>,
        "andrew@lunn.ch" <andrew@lunn.ch>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux@armlinux.org.uk" <linux@armlinux.org.uk>,
        "harini.katakam@xilinx.com" <harini.katakam@xilinx.com>,
        "michal.simek@xilinx.com" <michal.simek@xilinx.com>
Subject: RE: net: macb: linux-next: null pointer dereference in
 phylink_major_config()
Thread-Topic: net: macb: linux-next: null pointer dereference in
 phylink_major_config()
Thread-Index: AQHWsq6BvPM9dPOV2Uq2LXB0FhVdIqm3+1wwgAAIARA=
Date:   Wed, 4 Nov 2020 14:15:53 +0000
Message-ID: <DM5PR07MB31966C39424E0DEB4A5C5F6FC1EF0@DM5PR07MB3196.namprd07.prod.outlook.com>
References: <2db854c7-9ffb-328a-f346-f68982723d29@microchip.com>
 <DM5PR07MB31962607B69631EC5F742A54C1EF0@DM5PR07MB3196.namprd07.prod.outlook.com>
In-Reply-To: <DM5PR07MB31962607B69631EC5F742A54C1EF0@DM5PR07MB3196.namprd07.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 4e63a7d3-22ac-404a-40d1-08d880cc23f4
X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Nov 2020 14:15:53.6739
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: d36035c5-6ce6-4662-a3dc-e762e61ae4c9
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: IdKMvUvidTbnL4ucrME5fub2fc+LOKZsuL9vvgjc0ghnLelk2IHPJziEev1J+2LXxwMQ72KMdR9NxBdRAk3OAQHLso1q3plLnnNyKv/tGDI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR07MB6332
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.312,18.0.737
 definitions=2020-11-04_08:2020-11-04,2020-11-04 signatures=0
X-Proofpoint-Spam-Details: rule=outbound_check_notspam policy=outbound_check score=0 phishscore=0
 mlxlogscore=999 mlxscore=0 clxscore=1015 impostorscore=0 spamscore=0
 malwarescore=0 lowpriorityscore=0 adultscore=0 bulkscore=0 suspectscore=0
 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2009150000 definitions=main-2011040107
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Russell,

It seems apart from changes in driver, we also need check for NULL pcs_conf=
ig
below or make pcs_config as mandatory method for registering pcs_ops.

456         if (pl->pcs_ops) {
 457                 err =3D pl->pcs_ops->pcs_config(pl->pcs, pl->cur_link_=
an_mode,
 458                                               state->interface,
 459                                               state->advertising,
 460                                               !!(pl->link_config.pause=
 &
 461                                                  MLO_PAUSE_AN));
 462                 if (err < 0)
 463                         phylink_err(pl, "pcs_config failed: %pe\n",
 464                                     ERR_PTR(err));
 465                 if (err > 0)
 466                         restart =3D true;
 467         }

Please suggest.

Regards,
Parshuram Thombare