Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 4 Nov 2020 10:45:29 -0500
From:   William Breathitt Gray <vilhelm.gray@gmail.com>
To:     Arnaud de Turckheim <quarium@gmail.com>
Cc:     linus.walleij@linaro.org, bgolaszewski@baylibre.com,
        linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org
Subject: Re: [PATCH 0/3] gpio: pcie-idio-24: Fix IRQ handling
Message-ID: <20201104154529.GA406355@shinobu>
References: <20201104152455.40627-1-quarium@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="VbJkn9YxBvnuCH5J"
Content-Disposition: inline
In-Reply-To: <20201104152455.40627-1-quarium@gmail.com>
Precedence: bulk


--VbJkn9YxBvnuCH5J
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Nov 04, 2020 at 04:24:52PM +0100, Arnaud de Turckheim wrote:
> This patch set fixes the irq_mask/irq_unmask functions and enables the
> PLX PEX8311 local interrupts.
>=20
> With the current version of the driver, gpiomon (from libgpiod) or a
> poll(2) on the sysfs value are not working. According to
> /proc/interrupts, there is no interruption triggered.
> The main issue is that the local interrupts are not forwarded by the
> PEX8311 to the PCI.
>=20
> There is also two bugs:
>     - The IRQ mask is not correctly updated when unmasking an
>       interruption.
>     - The COS Enable Register value is not correctly updated when
>       masking/unmasking an interruption.
>=20
> It seems this problems exist since the initial commit.
>=20
> Arnaud de Turckheim (3):
>   gpio: pcie-idio-24: Fix irq mask when masking
>   gpio: pcie-idio-24: Fix IRQ Enable Register value
>   gpio: pcie-idio-24: Enable PEX8311 interrupts
>=20
>  drivers/gpio/gpio-pcie-idio-24.c | 62 ++++++++++++++++++++++++++++----
>  1 file changed, 56 insertions(+), 6 deletions(-)
>=20
> --=20
> 2.25.1
>=20

This patchset looks good to me and fixes several fundamental bugs. I'm
going to reply to each patch individually to give my Reviewed-by tags
for the benefit of those picking up the patches.

Thanks!

William Breathitt Gray

--VbJkn9YxBvnuCH5J
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEk5I4PDJ2w1cDf/bghvpINdm7VJIFAl+izHIACgkQhvpINdm7
VJJIXg//S/TIeMk+G+YlFHYyHYn0FwgG/2/ETVMgMBh5BG5ngJvf7lP08G1ntMMY
WIIr24GHIpyQn0fREOhtAO0vScusaXizpDxPkZit3OD7OYnO/HBb3cp4+dsC9yi/
t6YRpyruNiy+fObf5TYtFpg8SgSlfXe1djS03Ql1Ofaxjdj3CoV0lZM5iWRhrwJh
PDbWbmBHpyRlmn8m+Dzt6Uqjd6xbwhkb7k8YvUMuyf/3my4vftYPSP9EYBj7DXnE
a3Lg0wnjQ17rEpBjbpDhdpmGvhRXd0rek4SdJiX5L2c9wJYcUxVEyUmUrWUjUjZp
r2So/+9BG97wuF5UdDBr9A2KkXtBbrFP2j5Q9P2aMP0LWM/f+EXO6liN3aTrOh9Y
9U7sSJ5h63YccLAyn5p1TJWsvW5zfe9OxzhAPQpUL9AFAz7w+4m/h0pqWsQacuzS
NJkgBNMYErydifHh25PMN1AI6aeqomIS6R8Oo6f+0usSjiNFTm23WlZt282SlGtX
DMKFBHZemVn68xU6dWVzVTXS8Urx+AHOL+7lPdNZkvZh6ghdU2RH/ZoRWbLJJo9F
MFZ1tZTn7UXkcVLTghhnrfCPOvfQ008k0FhtiMsgEj3+VTlHFbQJy4WHPHTDseGe
6HUn0ialdpNlHwbJRz2j0FHz23+jj7mIgJpxK2yiAy6cFh5J8Qs=
=iy2L
-----END PGP SIGNATURE-----

--VbJkn9YxBvnuCH5J--