Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 4 Nov 2020 10:47:08 -0500
From:   William Breathitt Gray <vilhelm.gray@gmail.com>
To:     Arnaud de Turckheim <quarium@gmail.com>
Cc:     linus.walleij@linaro.org, bgolaszewski@baylibre.com,
        linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org
Subject: Re: [PATCH 1/3] gpio: pcie-idio-24: Fix irq mask when masking
Message-ID: <20201104154708.GB406355@shinobu>
References: <20201104152455.40627-1-quarium@gmail.com>
 <20201104152455.40627-2-quarium@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="qcHopEYAB45HaUaB"
Content-Disposition: inline
In-Reply-To: <20201104152455.40627-2-quarium@gmail.com>
Precedence: bulk


--qcHopEYAB45HaUaB
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Nov 04, 2020 at 04:24:53PM +0100, Arnaud de Turckheim wrote:
> Fix the bitwise operation to remove only the corresponding bit from the
> mask.
>=20
> Fixes: 585562046628 ("gpio: Add GPIO support for the ACCES PCIe-IDIO-24 f=
amily")
> Signed-off-by: Arnaud de Turckheim <quarium@gmail.com>

Reviewed-by: William Breathitt Gray <vilhelm.gray@gmail.com>

> ---
>  drivers/gpio/gpio-pcie-idio-24.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/gpio/gpio-pcie-idio-24.c b/drivers/gpio/gpio-pcie-id=
io-24.c
> index a68941d19ac6..5ea517416366 100644
> --- a/drivers/gpio/gpio-pcie-idio-24.c
> +++ b/drivers/gpio/gpio-pcie-idio-24.c
> @@ -339,7 +339,7 @@ static void idio_24_irq_mask(struct irq_data *data)
> =20
>  	raw_spin_lock_irqsave(&idio24gpio->lock, flags);
> =20
> -	idio24gpio->irq_mask &=3D BIT(bit_offset);
> +	idio24gpio->irq_mask &=3D ~BIT(bit_offset);
>  	new_irq_mask =3D idio24gpio->irq_mask >> bank_offset;
> =20
>  	if (!new_irq_mask) {
> --=20
> 2.25.1
>=20

--qcHopEYAB45HaUaB
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEk5I4PDJ2w1cDf/bghvpINdm7VJIFAl+izPsACgkQhvpINdm7
VJLTXhAAnRsqPsc2j18Y3YFH6nkX3Z1WbmixAbwJUGplfH1UfhdPzoExsXmHCmoU
uiDdAS3H8X/+IsIWatO70+Gy/n637PCmJ1830ASPIaXS4F18mseXkTxJginY0wdU
Mk0wEQPlKfZQhxrWCRJbEXwMmjxGuMKvx6ZnwseyaKo43MUREfTHRxPi+t07SMUP
0rQTdbCmBZ9yIeJYBsrEqdM/QrWVld0ANPlwwZzIIj4M77dOtopb2H3KvYg0q9s5
98t2400Fxk+Kn0imGDHkBRaKx6HadDAzDZhPoDekBfSk3e24W2ayg/fLglPH57WQ
c+BH/TAEASX+TutcuxhDan4O00cVMllBC9lhULu/aLpJs0iAd0RDVTptU8v6JFyk
Q0DavX2uh2LiB74XObW1BrkyGFnviY5KdnWxMxMzGbGpyzzEvvVi6qS9C0PFgGYV
d5WYmG2Ocv1rl4LqW7jvGR0UKOXnUc5Kneu4QzC9+aIkOiKWTqbxTCV9gab8iNOy
5XNASL/Jc3jLEXUcGka3x+ynUZWWmo46MNgB5DjzK4a5joI8oVdSDcU3R2+MPU9R
OV/AhvctVEIbikHtw3T33Dwtwo3CXSd8rJvvZC0gCNOyJZ36wt6kqyRbvj4cNElL
TmexmmJySSDfX0EvFth8yPxSHkzX0wrE/SR2xgy8MS2l95RK3do=
=3V7R
-----END PGP SIGNATURE-----

--qcHopEYAB45HaUaB--