Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp1408131pxb; Wed, 4 Nov 2020 08:09:44 -0800 (PST) X-Google-Smtp-Source: ABdhPJzBu/sIm2kxTnvPGLoAkTS805YcCfZgNcpP1gOh2V4tLF9JDW95Z5e6bJd1djOvQMwZRd50 X-Received: by 2002:a17:906:9459:: with SMTP id z25mr7313926ejx.88.1604506183891; Wed, 04 Nov 2020 08:09:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604506183; cv=none; d=google.com; s=arc-20160816; b=eElWxeIit2/Ylzx885nEvyQ+V/tUdoYnPSv939PTW1npMcgsOQMI5YRUvnD6x748l7 oByrVhk2ZHoV5C+JpK3uzk1ZXlS80As5MPPfh9OATvPV3XP8muvdYUi2cqvuQBE1IBtL /Ewh4NkEmNOMuyHQur1GrDBdJW4YBUEp2BzVUqzA9eL/cqnNMndm9uWG/c+Hq5vXaiDd VdyF7lvvchXU3+Zb6IBlh8s3iYInHJJpXE1FjccHyW1ttkU5fLijhnArpc5G/a5NMMJM GwpM1bTWSmKNeeci1jFuxDiw+qvHwk70QjA0Lma79OPqZSxAv9eGeNKYckA3IGV4HMKQ IZyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=VqjCeWNGiMMMDgfCQ+LZpzOPzsK/BdUKeSAKsbo3Mb0=; b=DhwHbOmLLLy7zFdf7xzIO75A5XohmbqnIleXvmgl8pFNcdwh7Ek+isYm+uYwtyx4v8 fBxV9B85cO0Ti3fYhTYMqh7a0wFqEZQgU+Cuc/sG525ORSzqOCgug+AHEbj9S2Dv/mHr q3Q4bKE47OpvWdewSIBgl5jYyyH7AcSQa2Si8GBw8hO+c5GuTRN7jXF69vhlxv0iscvT 37mxOvIPxroCOmKP8CE1w9GJ/1lexpT+uE8+IpqcEq8tdP4T8REvao3QbT5NQOP6GgFq J/0qs4j4Q8Tu4CvxpDjmPlPoZv/PAPZGFNE39ubGB+dleVvhjdIzvqkcSdYdy1IkBUDO YNQQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=kOXHXgXU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ot10si1671469ejb.244.2020.11.04.08.09.19; Wed, 04 Nov 2020 08:09:43 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=kOXHXgXU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729382AbgKDQEx (ORCPT + 99 others); Wed, 4 Nov 2020 11:04:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60752 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726564AbgKDQEw (ORCPT ); Wed, 4 Nov 2020 11:04:52 -0500 Received: from mail-pl1-x642.google.com (mail-pl1-x642.google.com [IPv6:2607:f8b0:4864:20::642]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 33539C0613D3; Wed, 4 Nov 2020 08:04:51 -0800 (PST) Received: by mail-pl1-x642.google.com with SMTP id b19so10507374pld.0; Wed, 04 Nov 2020 08:04:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=VqjCeWNGiMMMDgfCQ+LZpzOPzsK/BdUKeSAKsbo3Mb0=; b=kOXHXgXUOE75qVZxEVp6wAPzWSMdMEvUyLBaXeQgEhmMQV8Cug/HOHoT5OYKE+y5Yc eRxBc4lH3/+ywJxu8bTL4oRA3fwMPzxFvRcXK29ghaPE2QE2hd+T7KRFpeBTJwYKg9n4 TJs5JoknQ7YGtsTeooODRtRIl2f80aYvdYRzQc651LtOZEVN4Jq/vaEfhBJgj3C7E0ev Grun1t9woax/VhyrFfYBVYZuQ6+HBdygpOy7gjJ24Lq/umfd1tu3DrrtWEoO74lr7004 LWSaVI7KLveYA7R/BZKcem8i9eFDaHuwJZykV9O6svs9x3StQMv63l6REDzbVvwW84D5 F76A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=VqjCeWNGiMMMDgfCQ+LZpzOPzsK/BdUKeSAKsbo3Mb0=; b=hjqMnmqEmBtdPaxK4K+wni7VOJHSbyc5Xc62U+oMpndnFYhTuokMHJgTvJrSbt+iQN ymmCOsRPNQ1mDcIrRzuMME8WbGjVakiFu1CWz88fbo9we8VW34wlagokcGNTVPutqMC8 eE+6k1OIrql0VX94SxEupzyo7Ge/bGg2HwSgmUYMmekLDcPoCH6LODUevHRFnmOdfQC1 P/1mdtHXW6wCkquhHOf2KCwk17NnI7aX19qslf0UH3abaTaDA0KBzmDFVKAckBUXCe9j w/qWVN6YEEznDHJyxBXcVu2q6ppKqS6zn0b4NxvBLAd5mmvzln9NfaAqWeIGIGJHyeBh w+tQ== X-Gm-Message-State: AOAM531JdjvCP/8ap/gWkVVmx/sWNG8NMqIp5DLRF1d0VHpKJLWjHzfs PHYAOBURgZ6CWFVpjlkGL7fju9xZExHQ5w== X-Received: by 2002:a17:902:be0f:b029:d6:62a5:3b73 with SMTP id r15-20020a170902be0fb02900d662a53b73mr31244277pls.49.1604505890828; Wed, 04 Nov 2020 08:04:50 -0800 (PST) Received: from localhost ([2001:e42:102:1532:160:16:113:140]) by smtp.gmail.com with ESMTPSA id 12sm2817529pfh.88.2020.11.04.08.04.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Nov 2020 08:04:50 -0800 (PST) From: Coiby Xu To: Linus Walleij Cc: linux-gpio@vger.kernel.org (open list:PIN CONTROL SUBSYSTEM), linux-kernel@vger.kernel.org (open list) Subject: [PATCH 3/4] pinctrl: amd: print debounce filter info in debugfs Date: Thu, 5 Nov 2020 00:03:43 +0800 Message-Id: <20201104160344.4929-4-coiby.xu@gmail.com> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20201104160344.4929-1-coiby.xu@gmail.com> References: <20201104160344.4929-1-coiby.xu@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Print the status of debounce filter as follows, $ cat /sys/kernel/debug/gpio pin129 interrupt is disabled| interrupt is masked| disable wakeup in S0i3 state| disable wakeup in S3 state| disable wakeup in S4/S5 state| input is high| pull-up is disabled| Pull-down is disabled| output is disabled| debouncing filter disabled| 0x50000 ^^^^^^^^^^^^^^^^^^^^^^^^^^ pin130 interrupt is disabled| interrupt is masked| disable wakeup in S0i3 state| disable wakeup in S3 state| disable wakeup in S4/S5 state| input is high| pull-up is disabled| Pull-down is disabled| output is disabled| debouncing filter (high) enabled| debouncing timeout is 124800 (us)| 0x503c8 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Signed-off-by: Coiby Xu --- drivers/pinctrl/pinctrl-amd.c | 43 +++++++++++++++++++++++++++++++++-- 1 file changed, 41 insertions(+), 2 deletions(-) diff --git a/drivers/pinctrl/pinctrl-amd.c b/drivers/pinctrl/pinctrl-amd.c index 4aea3e05e8c6..524d55546b61 100644 --- a/drivers/pinctrl/pinctrl-amd.c +++ b/drivers/pinctrl/pinctrl-amd.c @@ -197,10 +197,16 @@ static int amd_gpio_set_config(struct gpio_chip *gc, unsigned offset, static void amd_gpio_dbg_show(struct seq_file *s, struct gpio_chip *gc) { u32 pin_reg; + u32 db_cntrl; unsigned long flags; unsigned int bank, i, pin_num; struct amd_gpio *gpio_dev = gpiochip_get_data(gc); + bool tmr_out_unit; + unsigned int time; + unsigned int unit; + bool tmr_large; + char *level_trig; char *active_level; char *interrupt_enable; @@ -214,6 +220,8 @@ static void amd_gpio_dbg_show(struct seq_file *s, struct gpio_chip *gc) char *pull_down_enable; char *output_value; char *output_enable; + char debounce_value[40]; + char *debounce_enable; for (bank = 0; bank < gpio_dev->hwbank_num; bank++) { seq_printf(s, "GPIO bank%d\t", bank); @@ -327,13 +335,44 @@ static void amd_gpio_dbg_show(struct seq_file *s, struct gpio_chip *gc) pin_sts = "input is low|"; } + db_cntrl = (DB_CNTRl_MASK << DB_CNTRL_OFF) & pin_reg; + if (db_cntrl) { + tmr_out_unit = pin_reg & BIT(DB_TMR_OUT_UNIT_OFF); + tmr_large = pin_reg & BIT(DB_TMR_LARGE_OFF); + time = pin_reg & DB_TMR_OUT_MASK; + if (tmr_large) { + if (tmr_out_unit) + unit = 62500; + else + unit = 15625; + } else { + if (tmr_out_unit) + unit = 244; + else + unit = 61; + } + if ((DB_TYPE_REMOVE_GLITCH << DB_CNTRL_OFF) == db_cntrl) + debounce_enable = "debouncing filter (high and low) enabled|"; + else if ((DB_TYPE_PRESERVE_LOW_GLITCH << DB_CNTRL_OFF) == db_cntrl) + debounce_enable = "debouncing filter (low) enabled|"; + else + debounce_enable = "debouncing filter (high) enabled|"; + + snprintf(debounce_value, sizeof(debounce_value), + "debouncing timeout is %u (us)|", time * unit); + } else { + debounce_enable = "debouncing filter disabled|"; + snprintf(debounce_value, sizeof(debounce_value), " "); + } + seq_printf(s, "%s %s %s %s %s %s\n" - " %s %s %s %s %s %s %s 0x%x\n", + " %s %s %s %s %s %s %s %s %s 0x%x\n", level_trig, active_level, interrupt_enable, interrupt_mask, wake_cntrl0, wake_cntrl1, wake_cntrl2, pin_sts, pull_up_sel, pull_up_enable, pull_down_enable, - output_value, output_enable, pin_reg); + output_value, output_enable, + debounce_enable, debounce_value, pin_reg); } } } -- 2.28.0