Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] ACPI: Remove trailing whitespace
To:     Joe Perches <joe@perches.com>, Bjorn Helgaas <helgaas@kernel.org>
Cc:     linux-acpi@vger.kernel.org,
        "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        Len Brown <lenb@kernel.org>,
        Bjorn Helgaas <bhelgaas@google.com>, linux-pci@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20201103211259.GA265488@bjorn-Precision-5520>
 <c92703e3-c964-b4a6-e3df-c4c0c28b44c1@gmail.com>
 <6e392d099bd8aaba14223aa770361dbdeeab271b.camel@perches.com>
From:   Maximilian Luz <luzmaximilian@gmail.com>
Message-ID: <6d888eb0-bfc5-28ff-c62f-9e769f77bc1f@gmail.com>
Date:   Wed, 4 Nov 2020 16:48:09 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.12.0
MIME-Version: 1.0
In-Reply-To: <6e392d099bd8aaba14223aa770361dbdeeab271b.camel@perches.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 11/4/20 6:13 AM, Joe Perches wrote:

[...]

>> Yes. I scanned drivers/acpi for trailing whitespaces after I noticed a
>> couple of them. I did not explicitly scan for other stuff like spaces
>> where there should be tabs, mostly because I haven't found a quick and
>> reliable solution for that. I only noticed an inconsistent indentation
>> when committing, so I fixed that too.
> 
> You could try:
> 
> $ git ls-files -- 'drivers/acpi/*.[ch]' | \
>    xargs ./scripts/checkpatch.pl -f --fix-inplace --types=CODE_INDENT

Thanks, that indeed looks like a decent solution.

> Right now that produces:
> ---

[...]

> diff --git a/drivers/acpi/ac.c b/drivers/acpi/ac.c
> index 46a64e9fa716..46be80976a03 100644
> --- a/drivers/acpi/ac.c
> +++ b/drivers/acpi/ac.c
> @@ -89,7 +89,7 @@ struct acpi_ac {
>   #define to_acpi_ac(x) power_supply_get_drvdata(x)
>   
>   /* --------------------------------------------------------------------------
> -                               AC Adapter Management
> +			       AC Adapter Management
>      -------------------------------------------------------------------------- */

I'm not too sure about the comments, but I can find the time to look
over the output and adjust that if that's something you'd want me to do.

Regards,
Max