Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 4 Nov 2020 09:15:36 -0800
From:   Benson Leung <bleung@google.com>
To:     Lee Jones <lee.jones@linaro.org>
Cc:     linux-kernel@vger.kernel.org,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        Benson Leung <bleung@chromium.org>,
        Enric Balletbo i Serra <enric.balletbo@collabora.com>,
        Guenter Roeck <groeck@chromium.org>,
        linux-input@vger.kernel.org
Subject: Re: [PATCH 07/20] input: keyboard: cros_ec_keyb: Struct headers
 should start with 'struct <name>'
Message-ID: <20201104171536.GB2322691@google.com>
References: <20201104162427.2984742-1-lee.jones@linaro.org>
 <20201104162427.2984742-8-lee.jones@linaro.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="yNb1oOkm5a9FJOVX"
Content-Disposition: inline
In-Reply-To: <20201104162427.2984742-8-lee.jones@linaro.org>
Precedence: bulk


--yNb1oOkm5a9FJOVX
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi Lee,

On Wed, Nov 04, 2020 at 04:24:14PM +0000, Lee Jones wrote:
> Fixes the following W=3D1 kernel build warning(s):
>=20
>  drivers/input/keyboard/cros_ec_keyb.c:72: warning: cannot understand fun=
ction prototype: 'struct cros_ec_bs_map '
>=20
> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> Cc: Benson Leung <bleung@chromium.org>
> Cc: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> Cc: Guenter Roeck <groeck@chromium.org>
> Cc: linux-input@vger.kernel.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>

Reviewed-by: Benson Leung <bleung@chromium.org>

> ---
>  drivers/input/keyboard/cros_ec_keyb.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>=20
> diff --git a/drivers/input/keyboard/cros_ec_keyb.c b/drivers/input/keyboa=
rd/cros_ec_keyb.c
> index 15d17c7170816..fce0c839e1430 100644
> --- a/drivers/input/keyboard/cros_ec_keyb.c
> +++ b/drivers/input/keyboard/cros_ec_keyb.c
> @@ -58,10 +58,9 @@ struct cros_ec_keyb {
>  	struct notifier_block notifier;
>  };
> =20
> -
>  /**
> - * cros_ec_bs_map - Struct mapping Linux keycodes to EC button/switch bi=
tmap
> - * #defines
> + * struct cros_ec_bs_map - Struct mapping Linux keycodes to EC button/sw=
itch
> + *			   bitmap #defines
>   *
>   * @ev_type: The type of the input event to generate (e.g., EV_KEY).
>   * @code: A linux keycode
> --=20
> 2.25.1
>=20

--=20
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
bleung@google.com
Chromium OS Project
bleung@chromium.org

--yNb1oOkm5a9FJOVX
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQQCtZK6p/AktxXfkOlzbaomhzOwwgUCX6LhuAAKCRBzbaomhzOw
wptiAP0aHVgx8uyB3PmgxMenVpt5IVR21RvYHC0n4xFss3vSLQD+Jp6JInb2JpDZ
l2pNvVRUz9msRgylNHA4sjDTilTyQQw=
=F0yq
-----END PGP SIGNATURE-----

--yNb1oOkm5a9FJOVX--