Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20201103211259.GA265488@bjorn-Precision-5520> <c92703e3-c964-b4a6-e3df-c4c0c28b44c1@gmail.com>
 <6e392d099bd8aaba14223aa770361dbdeeab271b.camel@perches.com>
 <6d888eb0-bfc5-28ff-c62f-9e769f77bc1f@gmail.com> <57b77f3a36f56e2ae7ab8fe367865b5412d4e11f.camel@perches.com>
In-Reply-To: <57b77f3a36f56e2ae7ab8fe367865b5412d4e11f.camel@perches.com>
From:   "Rafael J. Wysocki" <rafael@kernel.org>
Date:   Wed, 4 Nov 2020 18:20:06 +0100
Message-ID: <CAJZ5v0j3rboB1RmsEsuKJB38GwJDF-HjUMVZo=eTjWNMQRknRw@mail.gmail.com>
Subject: Re: [PATCH] ACPI: Remove trailing whitespace
To:     Joe Perches <joe@perches.com>
Cc:     Maximilian Luz <luzmaximilian@gmail.com>,
        Bjorn Helgaas <helgaas@kernel.org>,
        ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
        "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        Len Brown <lenb@kernel.org>,
        Bjorn Helgaas <bhelgaas@google.com>,
        Linux PCI <linux-pci@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, Nov 4, 2020 at 6:13 PM Joe Perches <joe@perches.com> wrote:
>
> On Wed, 2020-11-04 at 16:48 +0100, Maximilian Luz wrote:
> > On 11/4/20 6:13 AM, Joe Perches wrote:
> >
> > [...]
> >
> > > > Yes. I scanned drivers/acpi for trailing whitespaces after I noticed a
> > > > couple of them. I did not explicitly scan for other stuff like spaces
> > > > where there should be tabs, mostly because I haven't found a quick and
> > > > reliable solution for that. I only noticed an inconsistent indentation
> > > > when committing, so I fixed that too.
> > >
> > > You could try:
> > >
> > > $ git ls-files -- 'drivers/acpi/*.[ch]' | \
> > >    xargs ./scripts/checkpatch.pl -f --fix-inplace --types=CODE_INDENT
> >
> > Thanks, that indeed looks like a decent solution.
> >
> > > Right now that produces:
> > > ---
> >
> > [...]
> >
> > > diff --git a/drivers/acpi/ac.c b/drivers/acpi/ac.c
> []
> > > @@ -89,7 +89,7 @@ struct acpi_ac {
> > >   #define to_acpi_ac(x) power_supply_get_drvdata(x)
> > >
> > >
> > >   /* --------------------------------------------------------------------------
> > > -                               AC Adapter Management
> > > +                          AC Adapter Management
> > >      -------------------------------------------------------------------------- */
> >
> > I'm not too sure about the comments, but I can find the time to look
> > over the output and adjust that if that's something you'd want me to do.
>
> Up to you.  I hardly looked at the output.
>
> I'd generally prefer to use a single line comment like
>
> /* AC Adapter Management */
>
> but I don't know how often that dashed block is used in ACPI.
>
> grep seems to show the texts are not correctly centered so it seems like
> it was done by hand and not that some automation tool was used to create
> those blocks.
>
> Maybe a separate patch could be done to change those if desired.

If anyone has a problem with them.

> But not by me.
>
> As far as I know, acpi was once autogenerated from a common source tree
> and whitespace changes were once frowned on, but maybe that's changed or
> or perhaps that's only for files in drivers/acpi/acpica/.

The latter.